| Message ID | cover.1765615940.git.aburgess@redhat.com |
|---|---|
| Headers |
Return-Path: <gdb-patches-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id BB6E94BA2E1D for <patchwork@sourceware.org>; Sat, 13 Dec 2025 08:54:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB6E94BA2E1D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aHLD7ObS X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 98FA94BA2E05 for <gdb-patches@sourceware.org>; Sat, 13 Dec 2025 08:53:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98FA94BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 98FA94BA2E05 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765616023; cv=none; b=Gqufc4KhvWQFJtiJcCHPcTf49EIwVw7cCspW5z66PQczjI4tBbtciRo2faRt3esZNq8kOaMTWAu0nLbyGIRSl/6F+FLg/uQXzkHfhVTl4I3QQw4H4nuyBYAxQy78QK8kiJigSQSoHzGGG/B6Qh/K4VRwd+d4UskoE3fvfsxc4ig= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765616023; c=relaxed/simple; bh=OxraRAPVBbbCj/S2puHtfenkjUGsdvrmQBxXUXI9A6Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GUGZffAx2t/zkrt/HmReUzspbM0MLLON0YMxb0DptTJn9Nw/QtY28+5L0zEvDXex7VSPqc+VJa8i4tzBid4HEQbSEpoG/6+bdWlZlRBVNexSpyjBEEyN+E9YvD5OaNAk/SbqC1pl9AS0sqKzi3fnAagGblBBx9rpg2z+oElN+N4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98FA94BA2E05 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765616023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ei4JCHskNYHqyWQBCtYm0+3/43ko6UEWD4FXEJilJig=; b=aHLD7ObSkV7Vk0dlIjtg30VMdttqihsYVcZcqYRTdJZw52MTDUfpUpHZLxZO4XyTtSgERU G/DAAmTVlnhBZJ7IwZ2z7Lq5ObK5KD936yw6oG21S+7GJIVUF21teHjo0ZfKSaztOa3/X3 7buKQxQq6kQbT5HUJ61cJ6lAgWzRJ/0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-751p7jC4NYGOC8Rz5SVdDA-1; Sat, 13 Dec 2025 03:53:41 -0500 X-MC-Unique: 751p7jC4NYGOC8Rz5SVdDA-1 X-Mimecast-MFC-AGG-ID: 751p7jC4NYGOC8Rz5SVdDA_1765616020 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-42e29783a15so1091422f8f.1 for <gdb-patches@sourceware.org>; Sat, 13 Dec 2025 00:53:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765616020; x=1766220820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ei4JCHskNYHqyWQBCtYm0+3/43ko6UEWD4FXEJilJig=; b=p1Jm0SzuZyBSZ6hRLMSOGvkah0TgpC5G9lm1JxgTg63hHbi0vpGhLmuXvTujrTzElj 2QWeDtXRaMT8zltf8JnNe1Dd5NCX2hlnZ2ohR64ifV3ehRPbNe4/qBJVUrJQOshvrJ3M S6QDAGVGGQPZBdxLjHyhOKLZX2QxgJad9WKgh+XTY9Xpq2psPvwZL1zVZ2YJqH2kelUv 5BANrzxcwpMtkd1z6xkiRAfwLNSTuK2BNNURJPLEezjihZM0qiWvhMZ328CuKjDznrsq izgBzHvsSEyMz4MTafgVGLQCUCoH/UaMB8wbO7VixxH5kXQxC99DmcM7K2Ei7nz+nWIS dmVQ== X-Gm-Message-State: AOJu0Yww3cJXhtXkN/pIEkURxEfKfaAgQ0Sw0L6pJW2eeqRpnchF5NYF toZW4sfm2kSk0haJvWaTfZXfG34HsrL6ScZOEmDutb0PMvPgNl9dWwONHEU0JPIFH1XmJtC5jwW Jcax4U29v2Oo1gL+nyv9cGYy3lw6dZQPVVRxamt9xA4eFEPfdNJL9rltO4AEOyGTrXLm8lYKBp1 MB8EihuAbdZCwPOjNPwHXZYeQBPbFa+R7afndAr4WN+9zl770= X-Gm-Gg: AY/fxX6Z3xVC0UHFauqO2c+2gw7Ki4O3xel07mSgc+3+tU4889uHKgiCSUbld76GYLL EEq6PkVs50A0/WGHAczttHFjG48AWZKOI5cS2pQi8DNZKBKQsFVRFQCk8yu/ENWCgjSTlGb+j6F 1SmXkCFqxA4wpo7CwTwAXg/2IuSyVDolMet9hchl9OQn+C9zpajop6UdBVWcWZP39iyScMXGCje uE/qVp50AaEFTJKBBd8GvVLESpC5816R0ovHxcSXjryNJkYb+R/0XUZJvWJZDONEuX3g82chJts 2WiErf81sWEEWZeaCXOrbyT0MDHPk5rd6QRzG95MVJFB3lvz4zby2B9m5qHioN66FH7I57M4Ai4 5JZIm X-Received: by 2002:a05:6000:4014:b0:42b:48bc:49b0 with SMTP id ffacd0b85a97d-42fab27707bmr9900706f8f.21.1765616020057; Sat, 13 Dec 2025 00:53:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEbYsgCAo4aoPGVU/5Hfzx18Jtm4czYPpwfBJbkOboGT+K4YNPnDLdqmw8XmTVVAY8HtWpk3g== X-Received: by 2002:a05:6000:4014:b0:42b:48bc:49b0 with SMTP id ffacd0b85a97d-42fab27707bmr9900690f8f.21.1765616019590; Sat, 13 Dec 2025 00:53:39 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8b8a851sm17396861f8f.29.2025.12.13.00.53.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Dec 2025 00:53:39 -0800 (PST) From: Andrew Burgess <aburgess@redhat.com> To: gdb-patches@sourceware.org Cc: Andrew Burgess <aburgess@redhat.com> Subject: [PATCHv2 GDB 17 0/2] Fixes for scoped_gdb_ttystate class Date: Sat, 13 Dec 2025 08:53:32 +0000 Message-ID: <cover.1765615940.git.aburgess@redhat.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <562d1cc3615faad72139c6974a4e76b292285f77.1765556713.git.aburgess@redhat.com> References: <562d1cc3615faad72139c6974a4e76b292285f77.1765556713.git.aburgess@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: estSYhxvbNhoH1QHGM7qEpUVOzCngoKQ-IQ1CbWTDl0_1765616020 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org |
| Series |
Fixes for scoped_gdb_ttystate class
|
|
Message
Andrew Burgess
Dec. 13, 2025, 8:53 a.m. UTC
In v2:
- New first patch, renames scoped_gdb_ttystate and makes it non-copyable.
- Second patch is update of v1. No longer uses std::optional,
instead check for NULL. Some updates to comments to match.
Thanks,
Andrew
---
Andrew Burgess (2):
gdb: rename scoped_gdb_tty_state, and make it non-copyable
gdb: fix crash from 'shell' when GDB has no terminal
gdb/cli/cli-cmds.c | 2 +-
gdb/inflow.c | 12 ++--
gdb/ser-unix.c | 1 +
gdb/serial.h | 3 +-
gdb/terminal.h | 15 +++--
gdb/testsuite/gdb.base/shell-no-terminal.exp | 60 ++++++++++++++++++++
6 files changed, 82 insertions(+), 11 deletions(-)
create mode 100644 gdb/testsuite/gdb.base/shell-no-terminal.exp
base-commit: 5f69c00a6e0704627ab1b529d3a2fcdf244da3e8