From patchwork Tue Mar 18 17:00:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 58141 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B3E03858404 for ; Tue, 18 Mar 2025 17:02:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B3E03858404 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dClcG692 X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A0FD73858D1E for ; Tue, 18 Mar 2025 17:00:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0FD73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0FD73858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742317257; cv=none; b=F4HTsuEp+G4p37yNHUqshh1yPLOuJwG78chf05eP6OXjZ3eO59qZ9m9XMompYz2CopBuuCPScRpzqKTgykX9UMYBm0SyzoCy6NcAU3cn8HULTfmRS8rLNvKVyA6FodG66v46n0uWPStm2wzkDVh45fqRRFbWjXRr45sW0T3vupQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742317257; c=relaxed/simple; bh=xUfrmjtL5tLIBbT9czgAMucEtspZmPl5BLe6xWYUPaU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q9yUOWJolrVCuIKbpQ/ORKpYXrLFH9DddBam7+NRAYA+toL7PHI7leqvd+s3QXkW5kn1xyCX2vyib3EWetpa2sEqlN0pUTfNu7ZOxYWHS3LsDstmWEGOT722jl2bawn6yPtb7sK79V7u8LTIfFdzZJ8nivYnKYL5Xn6cvWUkEAY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0FD73858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742317257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YDrSRC/HIa1iX/O0esSIvIf9bZ8THmR5LR3wvTItvJY=; b=dClcG692xEVnGO9GV9SFOkU8j/E+TaiZvR1CerDhNpy2jCKI2yni/68WXjhAeJsJO8rSmT 133VB6bJVLUJRN3ru+fvXKvI+CId5csuYFHps73UVCHb7fqAVnjt6s4MtvfROyoUzAW0Zr wUrjcneH1yvuIK/ruwHu24jNGeGpu5k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-E6-On1CFP4iGtk8l1eWpWQ-1; Tue, 18 Mar 2025 13:00:56 -0400 X-MC-Unique: E6-On1CFP4iGtk8l1eWpWQ-1 X-Mimecast-MFC-AGG-ID: E6-On1CFP4iGtk8l1eWpWQ_1742317255 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3933ab5b1d5so3543229f8f.2 for ; Tue, 18 Mar 2025 10:00:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742317254; x=1742922054; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YDrSRC/HIa1iX/O0esSIvIf9bZ8THmR5LR3wvTItvJY=; b=wyhJazqxxxEGwpjScp229Id4CgTCJitcoY6PZqGTcBcbW4AuC4ZMJfG7L1aX0t/p18 5q6tvO7t7Ai2I1A5NqSIxNKXuO3EI5z8WvMd7YnsZR2ZchYnfaYLy/pWsYiOQYnyF2+0 gOoiOJwzIUveSNjI5kktOKLB9U3pxxV6P9P6NGODdD05KrSluASpF5XhcrGWXzvtp/LP GslEzaqHWwq9RQhPHIQhLnLNtdgPbxwfY5xfOC+h7QrnuMfGXlfWxPdGP1Y/ZSGTJ4vW Dri8soPolge1sQQXHiqMb5C3ohAS6jsKIl8MDSROTWXcQAvAMikgHkTEeB6+9DLXtcf/ n0sg== X-Gm-Message-State: AOJu0YwdyjATmghwhkOZ44ETJorNpRYjtzO5UAo1wDOqx3yQQtcpWP5s jLiyi7Crgc+qIFIgc5mJNHGydGZKV+bnM13TqTD5YsZWDVRJPCDz/BgCsDdqEkmSsXxpf9oVxb8 IPyah13AQV4HCwJv7dLWwjsP6s8wvIRreCLen29vmhm17Tob+d9ZJhd4MH7SBjdNyEvvc3qgSGy z4c9yS8ORhiXXW2ourl/8WW8mctZZXR37oiAmSyloVM/c= X-Gm-Gg: ASbGncuT2hUj0wGlsd2tHp2XKv2hHBUwF5T3yeMKr80cnUlxnEtS8P38odXi0XLhcI2 30dE4q/+4YUKFajgqEYv8TaTQJpaazj74G0s2rwVeTtRkKTtm1/SQ9iizuLimPISSBp9B3zKkTj 2UAop0AAjyR9iwndw17B1bHmSnojbnWcdGqbXUNdjl7JzWgeyz8d5eyZ5F/R9oEWxQkgc7Uiev3 qjH3OXKptHn+ECTX+zOYXdddsGeVJdMTm9AOpHG5t3Zpif2wCnUpiIxYCspdFd2KmB2qHpwoPEi uY11XpWQbBeewz0CJDzA5j/vnOE8ZOzp3bU= X-Received: by 2002:a05:6000:144d:b0:398:9e96:e798 with SMTP id ffacd0b85a97d-3989e96e883mr12189942f8f.13.1742317254213; Tue, 18 Mar 2025 10:00:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyfi0Q8VqzbTpIIvp/Wq0m2ivajknA0+CZZV9gt+Vf9VNix9fFztD5hVthJBMU8mvXpSZ5qQ== X-Received: by 2002:a05:6000:144d:b0:398:9e96:e798 with SMTP id ffacd0b85a97d-3989e96e883mr12189591f8f.13.1742317250721; Tue, 18 Mar 2025 10:00:50 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395cb7ea16csm18475656f8f.82.2025.03.18.10.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 10:00:50 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/2] Add some unit tests for remote argument passing Date: Tue, 18 Mar 2025 17:00:46 +0000 Message-ID: X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hhoRa_vhMcSxPDUcy9Rek4xJRDku3mEbUc6HZ0bPFVc_1742317255 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org First patch refactors some code to allow for reuse in the second patch, where I add some remote argument passing unit tests. Right now there are only a few tests, but I'd like to add more later as I fix some issues with the remote argument passing code. Thanks, Andrew --- Andrew Burgess (2): gdb: move remote arg splitting and joining into gdbsupport/ gdb: add remote argument passing unit tests gdb/Makefile.in | 1 + gdb/remote.c | 12 +- gdb/unittests/remote-arg-selftests.c | 166 +++++++++++++++++++++++++++ gdbserver/server.cc | 3 +- gdbsupport/Makefile.am | 1 + gdbsupport/Makefile.in | 14 ++- gdbsupport/remote-args.cc | 43 +++++++ gdbsupport/remote-args.h | 55 +++++++++ 8 files changed, 282 insertions(+), 13 deletions(-) create mode 100644 gdb/unittests/remote-arg-selftests.c create mode 100644 gdbsupport/remote-args.cc create mode 100644 gdbsupport/remote-args.h base-commit: 512ca2fca4b6674d51706d0d7fe21ed72f733fb5