mbox series

[0/2] Add some unit tests for remote argument passing

Message ID cover.1742317144.git.aburgess@redhat.com
Headers
Series Add some unit tests for remote argument passing |

Message

Andrew Burgess March 18, 2025, 5 p.m. UTC 
  First patch refactors some code to allow for reuse in the second
patch, where I add some remote argument passing unit tests.

Right now there are only a few tests, but I'd like to add more later
as I fix some issues with the remote argument passing code.

Thanks,
Andrew

---

Andrew Burgess (2):
  gdb: move remote arg splitting and joining into gdbsupport/
  gdb: add remote argument passing unit tests

 gdb/Makefile.in                      |   1 +
 gdb/remote.c                         |  12 +-
 gdb/unittests/remote-arg-selftests.c | 166 +++++++++++++++++++++++++++
 gdbserver/server.cc                  |   3 +-
 gdbsupport/Makefile.am               |   1 +
 gdbsupport/Makefile.in               |  14 ++-
 gdbsupport/remote-args.cc            |  43 +++++++
 gdbsupport/remote-args.h             |  55 +++++++++
 8 files changed, 282 insertions(+), 13 deletions(-)
 create mode 100644 gdb/unittests/remote-arg-selftests.c
 create mode 100644 gdbsupport/remote-args.cc
 create mode 100644 gdbsupport/remote-args.h


base-commit: 512ca2fca4b6674d51706d0d7fe21ed72f733fb5

Comments

Andrew Burgess April 24, 2025, 3:54 p.m. UTC | #1 
Andrew Burgess <aburgess@redhat.com> writes:

> First patch refactors some code to allow for reuse in the second
> patch, where I add some remote argument passing unit tests.
>
> Right now there are only a few tests, but I'd like to add more later
> as I fix some issues with the remote argument passing code.
>

I've checked this series in.  There's no real changes in GDB's
functionality here, it's really just moving things out into gdbsupport
so that it can be shared between gdb and gdbserver.  If there's
disagreement on the naming of the shared things, I'm happy to rename
things later, just let me know.

Thanks,
Andrew