Message ID | cover.1733742925.git.aburgess@redhat.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2FA9C3858424 for <patchwork@sourceware.org>; Mon, 9 Dec 2024 11:19:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2FA9C3858424 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=F6jZm9pY X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 81FF4385840C for <gdb-patches@sourceware.org>; Mon, 9 Dec 2024 11:18:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81FF4385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81FF4385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733743090; cv=none; b=RAhCUjDPfaorWMUfG2ImPmoh3bovcb1h3OinEIoKlZ73PmujfiEbT3l5zl3fYmnyBbIkf3aReIcpJZVet7JDHBEFDRmGJ2ZvZf0G/w4yKWVrnS9+1Y5ExzIcy67F9vEmGapCjiBK5oLUdpSODACVsw9muX6/pPHuCC6bZHahyiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733743090; c=relaxed/simple; bh=2eQLBhZ0krqk+oE7aTlkxqhgYx15i2UG5HwgquhMsas=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=XcIDZaPo2Py2h3TtJucBqedmPzM26lgDCsyFOgo8Dq/bXeLoiUYRCvlfwye9Ru0cLZPi1ocQwcWRpdmNrasWTFEMx+V9oUWSN3BuQYQFr17cnuxOQIWCOH+Yu3WWD8qgDOGDH2zTSHqYsOBdo/pFWBMcj4EbS0+YqTtd44NCC1g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81FF4385840C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733743090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPDj7BP8Ynq0wAmleYFBw/4Z2hgM4dfC5f+U7fsgvv8=; b=F6jZm9pYeDLlYeELftEqZG+2PfvsrHhfJOlpwjNjM0nBwQHvYDTmmgnWq5b2kRfNrg05pf VvUMSAyfZkmpoz/XHA43g4LtRLNQFi4GLH+d7MPjToAkLyimRD/hwtUB/f2imZYnUGWIrU 0XZrvs474QB3b+j7Di40kWuA4tAV42s= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-uDujrNe8NImJGsrR-Pnv1w-1; Mon, 09 Dec 2024 06:18:09 -0500 X-MC-Unique: uDujrNe8NImJGsrR-Pnv1w-1 X-Mimecast-MFC-AGG-ID: uDujrNe8NImJGsrR-Pnv1w Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-385df115288so1739864f8f.2 for <gdb-patches@sourceware.org>; Mon, 09 Dec 2024 03:18:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733743088; x=1734347888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uPDj7BP8Ynq0wAmleYFBw/4Z2hgM4dfC5f+U7fsgvv8=; b=V8tWxPOiUW0RwfmGiC4aYoas6rarNynkiww3Ifoi87wGxPI6I2uoD0aBGxFgsMLSnd BBba7HxXoIsZJItNl9c1pfrDATPME/MPAx/2zjA5oXaDKq4jPZq66cmq55VZXF9TYkzf 4HPPnHdMjtJMgLrX2VPucnW9FuBhXTINp95CIqOhi12xsJf5GHS4bJd0tb4l/REWEg1/ k1rZSZbsvq3oGH0kbqBfU9XfLpIK3n+/k3bpmuVC+S9vRQBKSMCqWP1d6CYTp2rExHIk tfRzXGR9ZI8FiX0x0RckQX2IwKo/lQK5mRaoLDy4FvCqlQyXM2uL/CSHZ6M0spw94mul /ROw== X-Gm-Message-State: AOJu0Yyvf5X6DC0E8GFaCFNi0mMZK1vNxsEEBFebXB3P9CrXyUNn9Vue giJL+JqNb4Nyypm+XFbB97d9qTbhijfqRle01lu/8QSgo/e8w0GNRaECqN/be+vWYmpSGPGXIo3 0WEiKap9CZms3KksOAxJ08h1uWcC6A8MSUonxvcb5zVy9KFKTl3rF+eEnkuo/RA/qUMOjXxbc5x JPKaLKr9OqpAMbruAGwwf63LqSrO5iktcTOVeoGE3ip7A= X-Gm-Gg: ASbGncvH2uypFUzS/blvuoSfOzsThGsccfKqe16YU7rhhBqot9CnNSOu8UFPVVctxnL gytGfdg9Qkni6GPXpNWbbh2+CYAo9YasDcnr7EF5wWtEzysM+Aji3F6MVyjJionDQ691zGVWl0L 8YE4QnSW96/dOVrFZGTy7Mcbx3sOTpJfcuoFX+X+VR6fZZrPtbAeahD61KNmteg6nrWkDZFt0iU iZ6833oU2SJB7QkIZW0hxrqkmX8XovDJ0sgDMkDa/XaNeZXDhp+uTPh9TzEiBQ3CbPav3r8fAFz 1w== X-Received: by 2002:a05:6000:1842:b0:386:32cb:4aa with SMTP id ffacd0b85a97d-38632cb06f1mr7215708f8f.45.1733743087877; Mon, 09 Dec 2024 03:18:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiPIEgz3qR8lmlz0FTeyS/MApopWGdf0UU291mruaVMDORKsn6TmioHxMnlw/HI8nKIbLI6A== X-Received: by 2002:a05:6000:1842:b0:386:32cb:4aa with SMTP id ffacd0b85a97d-38632cb06f1mr7215683f8f.45.1733743087502; Mon, 09 Dec 2024 03:18:07 -0800 (PST) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38637ab4ae8sm6292033f8f.110.2024.12.09.03.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 03:18:07 -0800 (PST) From: Andrew Burgess <aburgess@redhat.com> To: gdb-patches@sourceware.org Cc: Andrew Burgess <aburgess@redhat.com> Subject: [PATCHv5 0/7] disabled_by_cond fixes for breakpoints Date: Mon, 9 Dec 2024 11:17:57 +0000 Message-Id: <cover.1733742925.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <cover.1733499582.git.aburgess@redhat.com> References: <cover.1733499582.git.aburgess@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 47zhVxYHlyXWi5TDJ2u9QitGrNMJZl47O9nKXCDQqH8_1733743088 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org |
Series |
disabled_by_cond fixes for breakpoints
|
|
Message
Andrew Burgess
Dec. 9, 2024, 11:17 a.m. UTC
In v5: - Rebased onto current HEAD of master. The new patch #7 now actually builds! No code changes since v4. In v4: - Patches #5 and #7 are new. Linaro CI showed a regression on gdb.base/nostdlib.exp with patch #6. The new patch #5 fixes this issue. Then while testing patch #5/#6 I ran into another issue with a maintenance command, which patch #7 fixes. In v3: - Rebased onto current HEAD of master. - Added some KFAIL for bug PR gdb/32404 in #2 and #3. - Retested. -- I found some small problems with the disabled_by_cond logic for breakpoints, these are fixed in patch #2. Writing a test for patch #2 exposed a problem with an existing test related to disabled_by_cond, though in this case it was the test that was making some assumptions that turned out to be invalid on my machine. By making the test a little stricter the issue can be avoided. This is patch #1. During review of the v1 series Tom pointed me at PR gdb/32079, which was partially fixed by patch #2. The final fixes are in patch #6. And while working on patch #6 I spotted the bugs which are fixed in patches #3, #4, and #5. The first patch from the v1 series has been merged as this was a standalone testsuite improvement. Thanks, Andrew -- Andrew Burgess (7): gdb/testsuite: avoid incorrect symbols in gdb.base/condbreak-multi-context.cc gdb: fixes for code_breakpoint::disabled_by_cond logic gdb: restructure disable_breakpoints_in_unloaded_shlib gdb: handle dprintf breakpoints when unloading a shared library gdb: don't clear inserted flag in disable_breakpoints_in_unloaded_shlib gdb: disable internal b/p when a solib is unloaded gdb: handle empty locspec when printing breakpoints gdb/breakpoint.c | 118 +++++++-- gdb/doc/gdb.texinfo | 5 + gdb/solib.c | 2 +- .../gdb.base/bp-disabled-by-cond-lib.c | 24 ++ gdb/testsuite/gdb.base/bp-disabled-by-cond.c | 64 +++++ .../gdb.base/bp-disabled-by-cond.exp | 206 ++++++++++++++++ gdb/testsuite/gdb.base/bp-disabled-by-cond.py | 21 ++ .../gdb.base/condbreak-multi-context.cc | 6 +- .../gdb.base/condbreak-multi-context.exp | 231 ++++++++++++------ gdb/testsuite/gdb.base/dlmopen.exp | 76 ++++-- gdb/testsuite/gdb.base/nostdlib.exp | 69 ++++-- gdb/testsuite/gdb.base/shlib-unload-lib.c | 30 +++ gdb/testsuite/gdb.base/shlib-unload.c | 63 +++++ gdb/testsuite/gdb.base/shlib-unload.exp | 143 +++++++++++ gdb/testsuite/gdb.base/shlib-unload.h | 26 ++ gdb/testsuite/gdb.base/shlib-unload.py | 31 +++ gdb/testsuite/gdb.trace/change-loc.exp | 2 + 17 files changed, 980 insertions(+), 137 deletions(-) create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond-lib.c create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond.c create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond.exp create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond.py create mode 100644 gdb/testsuite/gdb.base/shlib-unload-lib.c create mode 100644 gdb/testsuite/gdb.base/shlib-unload.c create mode 100644 gdb/testsuite/gdb.base/shlib-unload.exp create mode 100644 gdb/testsuite/gdb.base/shlib-unload.h create mode 100644 gdb/testsuite/gdb.base/shlib-unload.py base-commit: d9df3857da0cef29ed9c0ef75f90700c5f392986