mbox series

[PATCHv3,0/5] disabled_by_cond fixes for breakpoints

Message ID cover.1733221992.git.aburgess@redhat.com
Headers
Series disabled_by_cond fixes for breakpoints |

Message

Andrew Burgess Dec. 3, 2024, 10:35 a.m. UTC 
  In v2:

  - Rebased onto current HEAD of master.

  - Added some KFAIL for bug PR gdb/32404 in #2 and #3.

  - Retested.

--

I found some small problems with the disabled_by_cond logic for
breakpoints, these are fixed in patch #2.

Writing a test for patch #2 exposed a problem with an existing test
related to disabled_by_cond, though in this case it was the test that
was making some assumptions that turned out to be invalid on my
machine.  By making the test a little stricter the issue can be
avoided.  This is patch #1.

During review of the v1 series Tom pointed me at PR gdb/32079, which
was partially fixed by patch #2.  The final fixes are in patch #6.

And while working on patch #6 I spotted the bugs which are fixed in
patches #3, #4, and #5.

The first patch from the v1 series has been merged as this was a
standalone testsuite improvement.

Thanks,
Andrew

--

Andrew Burgess (5):
  gdb/testsuite: avoid incorrect symbols in
    gdb.base/condbreak-multi-context.cc
  gdb: fixes for code_breakpoint::disabled_by_cond logic
  gdb: restructure disable_breakpoints_in_unloaded_shlib
  gdb: handle dprintf breakpoints when unloading a shared library
  gdb: disable internal b/p when a solib is unloaded

 gdb/breakpoint.c                              |  78 ++++--
 gdb/solib.c                                   |   2 +-
 .../gdb.base/bp-disabled-by-cond-lib.c        |  24 ++
 gdb/testsuite/gdb.base/bp-disabled-by-cond.c  |  64 +++++
 .../gdb.base/bp-disabled-by-cond.exp          | 206 ++++++++++++++++
 gdb/testsuite/gdb.base/bp-disabled-by-cond.py |  21 ++
 .../gdb.base/condbreak-multi-context.cc       |   6 +-
 .../gdb.base/condbreak-multi-context.exp      | 231 ++++++++++++------
 gdb/testsuite/gdb.base/dlmopen.exp            |  76 ++++--
 gdb/testsuite/gdb.base/shlib-unload-lib.c     |  30 +++
 gdb/testsuite/gdb.base/shlib-unload.c         |  63 +++++
 gdb/testsuite/gdb.base/shlib-unload.exp       | 143 +++++++++++
 gdb/testsuite/gdb.base/shlib-unload.h         |  26 ++
 gdb/testsuite/gdb.base/shlib-unload.py        |  31 +++
 gdb/testsuite/gdb.trace/change-loc.exp        |   2 +
 15 files changed, 894 insertions(+), 109 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond-lib.c
 create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond.c
 create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond.exp
 create mode 100644 gdb/testsuite/gdb.base/bp-disabled-by-cond.py
 create mode 100644 gdb/testsuite/gdb.base/shlib-unload-lib.c
 create mode 100644 gdb/testsuite/gdb.base/shlib-unload.c
 create mode 100644 gdb/testsuite/gdb.base/shlib-unload.exp
 create mode 100644 gdb/testsuite/gdb.base/shlib-unload.h
 create mode 100644 gdb/testsuite/gdb.base/shlib-unload.py


base-commit: 5930bcb592a599ec7182cdc9c2f47511e6082a5e