[PATCHv3,0/2] Filename completion fixes

Message ID cover.1727343658.git.aburgess@redhat.com
Headers
Series Filename completion fixes |

Message

Andrew Burgess Sept. 26, 2024, 9:43 a.m. UTC
  After pushing my filename completion series I started working on
filename option support .... and promptly discovered a couple of
(minor) issues in the filename completion code.  Neither are huge, the
first is a regression, though not a critical one I think, and the
second issue is a problem that existed before my recent changes, but
still I think should be fixed.

The filename option support is not included in this series, but is in
progress and will likely be ready to post once these are merged.

In v3:

  - The good news is that the fix I added in v2 did seem to fix half
    of the Linaro CI regressions.  But I forgot that I had two
    different cases, one for a single completion, and one for multiple
    completions.  I only fixed the single completion case in v2.

    So, in this iteration I've also tried to fix the multi-completion
    case.  Hopefully this will make the CI happy.

In v2:

  - The Linaro CI testing highlighted an issue with the additional
    completion tets I'd added.  I guess depending on either how
    readline is configured, or the version of readline in use, we see
    different control characters emitted.  The v2 update extends the
    regexp to hopefully cover both cases.

---

Andrew Burgess (2):
  gdb: fix for completing a second filename for a command
  gdb: fix filename completion in the middle of a line

 gdb/completer.c                               |  32 +-
 .../gdb.base/filename-completion.exp          | 382 +++++++++++++-----
 2 files changed, 308 insertions(+), 106 deletions(-)


base-commit: 43a1fffa62060ce640749dcc9fc17058069ccba6