Message ID | cover.1727343658.git.aburgess@redhat.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10F4F385828E for <patchwork@sourceware.org>; Thu, 26 Sep 2024 09:44:11 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 270EA3858D29 for <gdb-patches@sourceware.org>; Thu, 26 Sep 2024 09:43:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 270EA3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 270EA3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727343820; cv=none; b=vXpoBocg4IO6cWUuVOeNGk7JwVGAXEmofSWkEox2tvMYOgp29fNiIsLFQbnewbusE2OwtiSMPAzSKV6NlIwyysDay8qnztq/kC7//z1pTb8RGIWxgDXE1Ir1zaQ8qKFj0qcEQPVErW2wZKI8DOg2cVwJiC7IBnGfR6JyEKuY3xQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727343820; c=relaxed/simple; bh=hpkXzJAwmhDTzRsMJuYCqou9L2GYPgwMKBhCMjG/uow=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=SK1R0sanK4o85f29t30SY097YLkEyM4mpw0w1WYtugsjQxUn34IdhU0JjvsoTC7eRRH2nxdRcwve7OPUdmrmmjROWc1Fo/kVwXYhhsqNvWnBbcubKelbZY+UvT3AplrvAgplxG7XzmJJVe0VmAXOyQgUXw+5xmirHZCe1cEJcqA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727343818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EOyth6pENWEk4A+6VDb5XPru35NStR5RZa2a2yiLphM=; b=UYKC74zcJp2cdfjmLfLTKiBPU7QzcO7UjJt0XwMgJwf+kuLqfwOHO/9IcJx+v+L4dNcXB5 25zaF3ikMD8my5wLatDKIVSFuhlJQdVoNNxIVphgoawUPZnvfoM6ONlpNkrVI7SwtQ3M9t nbmg6z2NOpjGrs75PfO+kWhbr9VULpk= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-mrUhFKznN7WEsvlWJnLpCQ-1; Thu, 26 Sep 2024 05:43:38 -0400 X-MC-Unique: mrUhFKznN7WEsvlWJnLpCQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a7d2d414949so59402066b.0 for <gdb-patches@sourceware.org>; Thu, 26 Sep 2024 02:43:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727343816; x=1727948616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EOyth6pENWEk4A+6VDb5XPru35NStR5RZa2a2yiLphM=; b=I4RKkwvm0k1J21Ih1yuelM+NQORfuyxvMGSjr8RYqTgsxRrEW1CJRi7pKy/2+mrzW9 NWwMuG1RnOFmKw+hrIe2+IpzmibHjY/mmF6US5ALLoOKq0jqSB8FI/D/qPtQaQ/y3FhP vF0JzM3cRLRqJi8QfXnwPKONJfWQHwxqf5VcJOyHkwmPxigMiEub7HSbTHO7pz92MTmM N0ExtlIrkyG3LY6tL4kTeRtBo7ZhboSLKvZeFK32hXX8Q2m6yGG5UFRSWAbP0PcOFkcW 91il03irbJ7e6fAUdrtqnWZFxJuyS3BDbexUjT9DEKpRXApLipLWlkGv0P6vTDvhxnDu 6mng== X-Gm-Message-State: AOJu0Yytk4EG/FkInT3BK9mieE/RGJBxiHX7pR9WlMZ932c/8u87LS1v O4gsTNydlr9wy3D74vC0J4vEwva4XJ8M4hbwH3xX9tehUuPcnl8zGUrCP2d6lOMu/yR8jIWfWCh QcHn1U7eb1NBRz+nEJpT3kWTiTd0JzjUEjVY4PqP5NeS8zNLns7qQkdJg07oUiA4srgqjsIMB8l lGsmkkD460k+adaQOmnoIPbf0LTvCNqzfPdEbsIhj7ydM= X-Received: by 2002:a17:907:94c2:b0:a8b:154b:7649 with SMTP id a640c23a62f3a-a93a0369f4cmr466310566b.15.1727343815656; Thu, 26 Sep 2024 02:43:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETpRyQMfqK7oXX4TTY1ZM2F69UZ6b3hm9R5GlkLPR5t/MHTswlSbvlkq1DJOovWvcFu+Hsbw== X-Received: by 2002:a17:907:94c2:b0:a8b:154b:7649 with SMTP id a640c23a62f3a-a93a0369f4cmr466308366b.15.1727343815169; Thu, 26 Sep 2024 02:43:35 -0700 (PDT) Received: from localhost ([62.31.95.162]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9393138ac4sm328292966b.216.2024.09.26.02.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 02:43:34 -0700 (PDT) From: Andrew Burgess <aburgess@redhat.com> To: gdb-patches@sourceware.org Cc: Andrew Burgess <aburgess@redhat.com> Subject: [PATCHv3 0/2] Filename completion fixes Date: Thu, 26 Sep 2024 10:43:31 +0100 Message-Id: <cover.1727343658.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <cover.1727259767.git.aburgess@redhat.com> References: <cover.1727259767.git.aburgess@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org |
Series |
Filename completion fixes
|
|
Message
Andrew Burgess
Sept. 26, 2024, 9:43 a.m. UTC
After pushing my filename completion series I started working on filename option support .... and promptly discovered a couple of (minor) issues in the filename completion code. Neither are huge, the first is a regression, though not a critical one I think, and the second issue is a problem that existed before my recent changes, but still I think should be fixed. The filename option support is not included in this series, but is in progress and will likely be ready to post once these are merged. In v3: - The good news is that the fix I added in v2 did seem to fix half of the Linaro CI regressions. But I forgot that I had two different cases, one for a single completion, and one for multiple completions. I only fixed the single completion case in v2. So, in this iteration I've also tried to fix the multi-completion case. Hopefully this will make the CI happy. In v2: - The Linaro CI testing highlighted an issue with the additional completion tets I'd added. I guess depending on either how readline is configured, or the version of readline in use, we see different control characters emitted. The v2 update extends the regexp to hopefully cover both cases. --- Andrew Burgess (2): gdb: fix for completing a second filename for a command gdb: fix filename completion in the middle of a line gdb/completer.c | 32 +- .../gdb.base/filename-completion.exp | 382 +++++++++++++----- 2 files changed, 308 insertions(+), 106 deletions(-) base-commit: 43a1fffa62060ce640749dcc9fc17058069ccba6