From patchwork Sat Sep 14 11:51:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 57452 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 66AA8385DDC0 for ; Sat, 14 Sep 2024 11:52:36 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 08B1C385841C for ; Sat, 14 Sep 2024 11:51:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08B1C385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08B1C385841C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726314720; cv=none; b=P0lkNeKuuEJ+7/0mms4O9Md1NX5kWjd/r3SYkPxsL67ed0Z2UKvHQvdMovq3W3G3suy08l5n76igy6SWPRjyWPz03kFYDOv1J0AfNsr/GN6udZAgUk4mKhYtK0mKDJnesX4QRuhQKv7+WuL4CEKS9adb1tGG1IkWMWe4E2mzJyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726314720; c=relaxed/simple; bh=ARpXxW1XIo7GcTP0OjkJiZOOdkBGMNn6ulqKt6Qatmw=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=RhAIeHLDQV4KUidQgOqdC+hy0qTkdvj0gnbOk1LUMo/zydrUb2RKXZ2wb9tpA4/s6bi30eY7AZ+sqYAuc0hd8bPwoHq2WkMLcStJD/Vwdls/9aCdPVwcBItMrBMsl7uw2UVyS2T0E4W7vgV+dWO1UZT6DbNA1ycaM3zBufB2GAo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726314718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ByKx6KGbDP7k76EC/8M10Y9OSrWxKOQQQw1LWb1MofE=; b=IERQGy10ixLO5i983p62neBNMlo8K7rpi/i7ACjgBj4GHldQSXUpBEGQq6iS1uEWSO2d8G 3/sBL8LdAc7pfIAzHGRpG2cQrvqiDWZQACVR2yldEpPZU0XAaV7IzbkIc1BT1I5qk70+jo u1XGO5bFtkJdln9m3/+MQEr6lW1/RQo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-5mcwHZtvPSmGrBbk-bLWxQ-1; Sat, 14 Sep 2024 07:51:56 -0400 X-MC-Unique: 5mcwHZtvPSmGrBbk-bLWxQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3756212a589so1222498f8f.2 for ; Sat, 14 Sep 2024 04:51:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726314714; x=1726919514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ByKx6KGbDP7k76EC/8M10Y9OSrWxKOQQQw1LWb1MofE=; b=WHskW1VhRjOWFSxNQWNZzxlNvC9XDHZsbRBrnI02DCxCYjIdv+775N5srbp1Hq+10n 5grUGpae2r1QylRXTrQHA7cLB8qmvqhC6BUPe0arWHl6rxo8dpbc7SgSDtB/BoIE1/b1 DsZbviJFwxlXJw4CS7n467rzEFU3sxvf6m9JpvEV6pshksbrY3yv7jsb7jZGHbAvgoWQ mZcssXFsnGbeT/vErGFjW/2SIo+iez6byMfLdTE0G6E9sUcPI+v4XodToQwMod3DZhD9 ZpnbiGy0ueknOnEt1JqPF9m2bCXigxyw2t+BKMTPGwz8K8d0rNbdodebR2aO95pN1WNJ mKVQ== X-Gm-Message-State: AOJu0YwfKmklToBbDywMJZP89xexS7fvIg51TaPbeq+Vx3mKRXochQC1 HTAUS01SrJ+3gwqjGogVzOXwAVJKTni6WE9xfu6egbqtoHeqXEJ1Y4BkKYVdvZszOTlLvLaodea HYl5Bkc533WzEZ0NyNCDjqVnEp53wd4yT6sy1L/Zaa67zLXIhMQ9nKZBlqntD+V+yGLXnjDQs16 PID1j8Kx+NuZg+Q5LlC6YNRHde2YOkl3RXhuaWzJeVG3s= X-Received: by 2002:a05:6000:b82:b0:377:4aa2:3af8 with SMTP id ffacd0b85a97d-378d61e251dmr5300988f8f.13.1726314714511; Sat, 14 Sep 2024 04:51:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHeMIwyGicGq231Y8NskIHf47v/O8p94L2+hbI9z5F5FzUqQ2fdiZgpj/tqEUTjY2pGBBYL9A== X-Received: by 2002:a05:6000:b82:b0:377:4aa2:3af8 with SMTP id ffacd0b85a97d-378d61e251dmr5300941f8f.13.1726314713140; Sat, 14 Sep 2024 04:51:53 -0700 (PDT) Received: from localhost (92.40.184.202.threembb.co.uk. [92.40.184.202]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9061096896sm72704966b.23.2024.09.14.04.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Sep 2024 04:51:52 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/2] Filename completion fixes Date: Sat, 14 Sep 2024 12:51:47 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org After pushing my filename completion series I started working on filename option support .... and promptly discovered a couple of (minor) issues in the filename completion code. Neither are huge, the first is a regression, though not a critical one I think, and the second issue is a problem that existed before my recent changes, but still I think should be fixed. The filename option support is not included in this series, but is in progress and will likely be ready to post once these are merged. Thanks, Andrew --- Andrew Burgess (2): gdb: fix for completing a second filename for a command gdb: fix filename completion in the middle of a line gdb/completer.c | 32 +- .../gdb.base/filename-completion.exp | 343 ++++++++++++------ 2 files changed, 269 insertions(+), 106 deletions(-) base-commit: dbddec2a8e0265b77fe331d9c173a4e99d1fccab