From patchwork Sat Apr 20 09:10:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 56902 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11A37384AB63 for ; Sat, 20 Apr 2024 09:10:49 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EC7CD3858D33 for ; Sat, 20 Apr 2024 09:10:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC7CD3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EC7CD3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713604219; cv=none; b=UZMQgh43rbcLdFEPim6DZJquBcUaFLzAE2V+NuY+6p5NTk85pD0vzjwaBvaZVDpfYAvsB3+F9y4JcssrzStlgbL/y/onEjagR0MUvogXXc3G6x1VH0xBSsnvoAbfMkovQJKBfTwyISgv6/aZQiy5Glj+hsaORevQKfOkYfRcDbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713604219; c=relaxed/simple; bh=GzY8maallfOTBflEi4BgcuGLlRVmaYwHYt9U4LzBLGU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=KZmEzMy+0fxZIr5Zeet2IBurnQUQLfnC/JJtPJ6vSyzRsui/9/VkBIklpHXp/QetGTqZ9dSA+fCmXCrHOz3YYD1He4cj0P1n/s+fcbD9BulAYF0P3IoDg/cB7CPjADGFxjpRQI1r/yyCnlqbZNwi2diehnNVpPsQT+kG+LP0yyQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713604216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UC8FlFAfCgNjULXXyFQRFZipsE/SyhVKk22eZk6vLLU=; b=i3WG9bD6tiJmdXPuXLmwmwFgHJee7RYNtkVJYIl4kzZzfnowa/D8xPZWN4uE6rsuA0YlXc gEWA9+SQhkmyDjZsgTsyKxEJmlB+OC4CkP7Ax7jb7xH5fO8JqZ1hCnbnpKyOgrX6rGqMqw DabC+ODZTxAeR3E2+19nf7Ec16heyqQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-Q3YyvfKQNe6J2NDUiINO2g-1; Sat, 20 Apr 2024 05:10:15 -0400 X-MC-Unique: Q3YyvfKQNe6J2NDUiINO2g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-419f572bdbdso1059385e9.2 for ; Sat, 20 Apr 2024 02:10:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713604213; x=1714209013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UC8FlFAfCgNjULXXyFQRFZipsE/SyhVKk22eZk6vLLU=; b=vf9UNHgcK1GYhgu05F9Nc8pP/u0OylEg26zgI6resFq35tjN2wfoeICZ/NBHxlO9Y6 f6rDgXm92pGzXMicaxRKSlzzJIEXp8Fhy7Up+AWsFEyfUGXnimPUIemsji8ga/ry/oDE k2fILUWY+KUjmD9jYv/evec1ScbzNfMQSw56RSynuuOlmV/KTZX0xCbaSXswmrBGgSow O7iyXFS/Tg1ffH2A6p3/0Bg5iXJk9uP90+LDL1qFlql1UL4rXgwitFIzrXbtlo5s7u4x gV+njz4DkQ2r/YVONLh0SOcqdD5YrzGJCSOmdlk33HsWmECZCLyX+tcSRO/uzdl8Glco 7nWA== X-Gm-Message-State: AOJu0Ywgmd58L1ekr8kHUFr2pML098k+f7eF7MOA9SFfIj5UjLNSk/0Z p1l/gljiiQ0qfLAeqCcXPqX7vUpygP9kLV45Zvz1eU/P+8+HxKwTPUlVgdJhcLCf484vd15p2ny ezniKMGPOJ8lS2oj8coI0H/+hgEAczj/uLGNhtKMqVAKx3JI3TneqMYBGh3qM6xWqpUXM9/Ytji XjoGc3jCgQ90ehYuOy423gsaG/y5qR9QhfRG5SPaRl/0c= X-Received: by 2002:a05:600c:468d:b0:419:5a9c:1d86 with SMTP id p13-20020a05600c468d00b004195a9c1d86mr3694041wmo.28.1713604213191; Sat, 20 Apr 2024 02:10:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIOCgIL/+QAMPr5GRptYOrULHplrLuhrlJfYmPmzrgkktsbBYpym6NdmStfxvTcXvdGTS4fg== X-Received: by 2002:a05:600c:468d:b0:419:5a9c:1d86 with SMTP id p13-20020a05600c468d00b004195a9c1d86mr3694020wmo.28.1713604212596; Sat, 20 Apr 2024 02:10:12 -0700 (PDT) Received: from localhost (92.40.185.25.threembb.co.uk. [92.40.185.25]) by smtp.gmail.com with ESMTPSA id i4-20020a05600c354400b0041902ebc87esm6058580wmq.35.2024.04.20.02.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Apr 2024 02:10:12 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess , Lancelot SIX , Eli Zaretskii Subject: [PATCHv2 0/8] Further filename completion improvements Date: Sat, 20 Apr 2024 10:10:00 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org In V2: - Patches #1 and #2 are new in this iteration. Patches #3 to #8 are the patches from V1 rebased onto these two new patches, - Patch #1 adds documentation for the formatting of filename arguments, this tries to explain the two diffent ways that GDB expects filename arguments to be formatted. - Patch #2 addresses the problem that Lancelot pointed out: some commands don't expect filename arguments to be quoted, or to contain escapes. In this patch I split the filename completion in two so the two different filename argument formats are handled separately... - This clears the way for the rest of the series, which updates how completion works for those filename arguments that do accept quoting and escaping, - Patches #3 to #8 are in principle the same as in V1, but there were some changes after rebasing onto the new patch #2. --- Andrew Burgess (8): gdb/doc: document how filename arguments are formatted gdb: split apart two different types of filename completion gdb: improve escaping when completing filenames gdb: move display of completion results into completion_result class gdb: simplify completion_result::print_matches gdb: add match formatter mechanism for 'complete' command output gdb: apply escaping to filenames in 'complete' results gdb: improve gdb_rl_find_completion_word for quoted words gdb/auto-load.c | 4 +- gdb/breakpoint.c | 5 +- gdb/cli/cli-cmds.c | 34 +- gdb/cli/cli-decode.c | 12 +- gdb/cli/cli-dump.c | 6 +- gdb/compile/compile.c | 3 +- gdb/completer.c | 501 +++++++++++++++--- gdb/completer.h | 79 ++- gdb/corefile.c | 4 +- gdb/corelow.c | 4 +- gdb/doc/gdb.texinfo | 66 +++ gdb/dwarf2/index-write.c | 3 +- gdb/exec.c | 7 +- gdb/guile/scm-cmd.c | 2 +- gdb/infcmd.c | 15 +- gdb/inferior.c | 2 +- gdb/jit.c | 2 +- gdb/python/py-cmd.c | 2 +- gdb/record-full.c | 5 +- gdb/record.c | 2 +- gdb/skip.c | 2 +- gdb/source.c | 3 +- gdb/symfile.c | 7 +- gdb/target-descriptions.c | 7 +- gdb/target.c | 4 +- gdb/target.h | 9 +- .../gdb.base/filename-completion.exp | 257 +++++++-- gdb/tracectf.c | 3 +- gdb/tracefile-tfile.c | 4 +- 29 files changed, 857 insertions(+), 197 deletions(-) base-commit: 7a59cf956369336eb9346196a85976e4042019f5