From patchwork Tue Mar 5 15:21:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 56757 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 897A8385800C for ; Tue, 5 Mar 2024 15:22:27 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 352353858404 for ; Tue, 5 Mar 2024 15:21:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 352353858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 352353858404 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709652116; cv=none; b=vUaKAx5AGo9RF/NIOzKCGFS95uTZJk+kQ2c0yXiKF5/ZyxdY13UJ03adpkgyNQy0ERZn4bJh3Du5oa7QLZvU5cegTN3G+RyeC1v74cU4cvUz7z7AjpZnp+Gl38GFZKfMdxYfX9SSuRoXXSHTuqP3TyiECh0Xie41c9AZ6bByvT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709652116; c=relaxed/simple; bh=G9ld5mOl6LIdWwrHzPlEnCqRv41LsWnt045vxIS8LOU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=FSV8uBDgSudGpn1ODZvC0Z3Y/4g3c/RuCKiuQp3iShqokp2bBnzSZF3XgC+MuL3AlsXxgzEqRR9L3YOyOGU1CeEsJPhMw+EBtT+2UqxnTbfmzjMjxSDv7sLvC93nALcgbUKoBXWcieyHwDzX6bCm4qfeGsA4HLlP91MS3RdFpAo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oHpxW3POWQHXRkviXaiHEiFurSb0wCHe50R9BnUSE7U=; b=Eh4bT4vpjNcd389J/LNR7n/+j1Hozia10FxiPOqjy2VdPFJ/R0zi2NhtwmYxCqLaWW0gRH OFmMAkXz3aA75ALhp4buu02DCow5LeY8wbOZhJ8GrYv98MTBdKKuGDcXBej1CT3nDDLrky 5dXcTE3yA8MrXxKyLv1WWh7dFpgxbPg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-O11hIMolMH-ADqVgQtWgkA-1; Tue, 05 Mar 2024 10:21:52 -0500 X-MC-Unique: O11hIMolMH-ADqVgQtWgkA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a44143c8908so552881266b.1 for ; Tue, 05 Mar 2024 07:21:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709652110; x=1710256910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oHpxW3POWQHXRkviXaiHEiFurSb0wCHe50R9BnUSE7U=; b=e8apRwxNgV24KVKiipDD9L205i06X0hhJqbl8zj/Ok16U2v80wHa3hhG1V7dtiNLTL +WoBndS5D6ko+sxXywsdayKIhQMe2yh0SbTUR8RVDw4eoBVLt/6WWRbpJfBlHs62jbUG O8iT9xriX10POQSt6t7RAPHsUk2gny9Pjb6rKbtFORzWK5vQ0w8yt9EvlBjgOpDLG0xR EBJoz2demK/H1jF8IiBRO5f2mD8QPklEFF1HRate6CqKlffiPXAxsA8HbL9SpYXH/31i RbU4TziUOFgRWmMXExzjN1/tqtYVkV/TTtiiSoYoYXC65n3Dhhh/JvklNKGyv5qwImEi hVlw== X-Gm-Message-State: AOJu0YwNYTojAuYI+fv2zUYBsJgHo1vE8sBgScXNI1MHMg00JPdLiMXo /OV+rwnpkpAInvJr3hMGmpZ/pQK0l9Y70AXLpJCpzcPDyM4yo+FNcZnquofeARR7Vy/CvIpkbTI sVtWsxdVrz9p1jIl6E3QQ3c1UGVtdGiellM9O4/+/EHM5dPJjCiLyMhaR/Fewi2FlMwfhZ5s7Cf LG1AfPgcZNdUy9lfGF5vbfJQqYcbbDkl82KkZdum99MQs= X-Received: by 2002:a17:906:2c44:b0:a45:ab1a:4c2e with SMTP id f4-20020a1709062c4400b00a45ab1a4c2emr1831797ejh.19.1709652109886; Tue, 05 Mar 2024 07:21:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKB+wp74GRKzweE8gry+3WSnySbbA/xxFlwKMY0IzQHp1T9TMj3XOy2LUvUwNULWLaHuiJ8Q== X-Received: by 2002:a17:906:2c44:b0:a45:ab1a:4c2e with SMTP id f4-20020a1709062c4400b00a45ab1a4c2emr1831760ejh.19.1709652109290; Tue, 05 Mar 2024 07:21:49 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id f18-20020a170906049200b00a44ebb34851sm3860012eja.10.2024.03.05.07.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 07:21:48 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv9 00/14] thread-specific breakpoints in just some inferiors Date: Tue, 5 Mar 2024 15:21:31 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TVD_PH_BODY_ACCOUNTS_PRE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org In v9: - Rebased onto current upstream/master branch, - Minor testsuite fix to account for updated output from GDB, - No other changes since v8. In v8: - Rebased onto current upstream/master branch. - Reordered the patches a little. Patches 0 to 8 are unchanged from previous. If there's no objections then I'm planning to merge these some point soon as I think these are all good cleanup patches. - Patches 9, 10, and 11 are new. These are also refactoring commits, but are all tied pretty tightly to what is now patch 12. - Patch 12 is the most important patch. This has had a complete rewrite since V7 in order to address Tom's feedback. The general idea is unchanged; the breakpoint condition string is parsed first forwards, and then backwards, but we now have a two phase analysis, rather than immediately parsing things like the thread-id as we find them. This resolves this problem: (gdb) break some_function if ( 3 == thread ) Previous GDB would try to match 'thread )' as a thread-id and give an error that ')' as invalid. Now GDB correctly understands that the 'thread )' is likely part of the 'if' condition, and parses it as such. - Patches 13 and 14 are unchanged from V7. These patches depend on the changes in patch 12 so can't be merged without that patch. In v7: - Addressed all the issues except one that Baris pointed out, this includes typos, some minor testsuite cleanups, and reformatting an assert (but not changing the meaning). - As requested, switched to use std::string_view in break-parse-cond.c file instead of a custom class, I agree that this is an improvement. - I've not changed the handling of -force-condition flag. I replied to the review email with my thoughts, TLDR: fixing this would be a bigger task which I'd rather leave for ... the future. - Rebased and retested. In v6: - Rebased to current master, one minor fix due to the C++17 changes, nothing major. Retested. In v5: - Updates after Lancelot's feedback, including, -force-condition can no longer be abbreviated to '-', and can't be used immediately after the breakpoint condition. - More tests to check some of the edge cases. In v4: - Big update, this series now handles thread-specific and inferior-specific breakpoints. In v3: - Rebased on to current upstream/master, this includes all Simon's recent breakpoint changes. Retested with no regressions seen. In v2: - Rebased on current upstream/master and retested, - No changes to code or docs. --- Andrew Burgess (14): gdb: create_breakpoint: add asserts and additional comments gdb: create_breakpoint: asserts relating to extra_string/parse_extra gdb: change 'if' to gdb_assert in update_dprintf_command_list gdb: the extra_string in a dprintf breakpoint is never nullptr gdb: build dprintf commands just once in code_breakpoint constructor gdb: don't display inferior list for pending breakpoints gdb: remove breakpoint_re_set_one gdb: remove tracepoint_probe_create_sals_from_location_spec gdb: make breakpoint_debug_printf global gdb: add another overload of startswith gdb: create new is_thread_id helper function gdb: parse pending breakpoint thread/task immediately gdb: don't set breakpoint::pspace in create_breakpoint gdb: only insert thread-specific breakpoints in the relevant inferior gdb/Makefile.in | 2 + gdb/NEWS | 11 + gdb/ada-lang.c | 6 +- gdb/break-catch-throw.c | 6 +- gdb/break-cond-parse.c | 701 ++++++++++++++++ gdb/break-cond-parse.h | 52 ++ gdb/breakpoint.c | 773 ++++++++---------- gdb/breakpoint.h | 109 ++- gdb/testsuite/gdb.ada/tasks.exp | 6 +- gdb/testsuite/gdb.base/condbreak.exp | 57 +- gdb/testsuite/gdb.base/pending.exp | 23 +- gdb/testsuite/gdb.linespec/explicit.exp | 4 +- gdb/testsuite/gdb.linespec/keywords.exp | 8 +- gdb/testsuite/gdb.mi/mi-dprintf-pending.exp | 3 +- gdb/testsuite/gdb.mi/new-ui-bp-deleted.exp | 8 +- .../gdb.mi/user-selected-context-sync.exp | 4 +- .../gdb.multi/bp-thread-specific.exp | 7 +- .../gdb.multi/inferior-specific-bp.exp | 16 +- .../gdb.multi/multi-target-continue.exp | 2 +- .../gdb.multi/multi-target-ping-pong-next.exp | 4 +- .../gdb.multi/pending-bp-del-inferior.c | 28 + .../gdb.multi/pending-bp-del-inferior.exp | 214 +++++ gdb/testsuite/gdb.multi/pending-bp-lib.c | 22 + gdb/testsuite/gdb.multi/pending-bp.c | 66 ++ gdb/testsuite/gdb.multi/pending-bp.exp | 332 ++++++++ gdb/testsuite/gdb.multi/tids.exp | 6 +- .../gdb.threads/del-pending-thread-bp-lib.c | 22 + .../gdb.threads/del-pending-thread-bp.c | 85 ++ .../gdb.threads/del-pending-thread-bp.exp | 108 +++ gdb/tid-parse.c | 82 +- gdb/tid-parse.h | 8 + gdbsupport/common-utils.h | 10 + 32 files changed, 2279 insertions(+), 506 deletions(-) create mode 100644 gdb/break-cond-parse.c create mode 100644 gdb/break-cond-parse.h create mode 100644 gdb/testsuite/gdb.multi/pending-bp-del-inferior.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp-del-inferior.exp create mode 100644 gdb/testsuite/gdb.multi/pending-bp-lib.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp.exp create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp-lib.c create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.c create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.exp base-commit: a7ea089b0bccb6379e079e2ab764c2012d94b472