Message ID | cover.1701107594.git.aburgess@redhat.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 05898385782A for <patchwork@sourceware.org>; Mon, 27 Nov 2023 17:56:41 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 56E46385829E for <gdb-patches@sourceware.org>; Mon, 27 Nov 2023 17:56:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 56E46385829E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 56E46385829E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701107773; cv=none; b=aBrPipqcfxLZauESYVCA+Z5W+x5DCrzK9Kiw9xsWl3EpTrGlIGOaJ7Ufh0Fvkv4jquCR3nxGRBgp2h9X0HKqEgwykBLoC4ywn7PZvDt6nQX4ckVT0bDIqEoxi42cvfGZfCW7wIEwE+h10NxBJJbIGezjVukPnU3W9gXYr7huxgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701107773; c=relaxed/simple; bh=JclkzKaweRgzRSwajYT9O7ekKqcUXZYuLnUD+p8Z7p8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=kX64fnQttzgp8hkw9+Lo9mxqpCOy6B/fFnq+iGWCjSPgNttSegRmYkQdY/7JgZafta1r8ox+4RrzMGW0PFWmLCmh5y5yssIeLXVNUAb3hwgMH3oLXJD+By5CXydye+EjkwdV9YwUSU6LcO5R1JjN23rqj+6NbzbLWlNvECknBHI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701107767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/Jp8rgljFVKDpuJqcoadractaQsvj9mcLr9B/Vbw5jU=; b=RGkCBqN3Vy94La6glWaiIcEe1SRnt7KO6pme9BSghnTaE36dH5PHnBjMu40QxnVzusZFRo vUdtF9ZxKO7vvACdv2z60iZ+UBR8xKI2JOdjEiSHF6HIn4lmclSsXx3Dzw/ibyctQNGTd6 3meiD/mxQEpCC9OdF/V0H3v+KfyydQU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-YqVnnyKnMCG6qIsbnId_1A-1; Mon, 27 Nov 2023 12:56:05 -0500 X-MC-Unique: YqVnnyKnMCG6qIsbnId_1A-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c8321310b6so38242881fa.3 for <gdb-patches@sourceware.org>; Mon, 27 Nov 2023 09:56:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701107763; x=1701712563; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/Jp8rgljFVKDpuJqcoadractaQsvj9mcLr9B/Vbw5jU=; b=tKSulM8RK5FePxzFXXvXeZoMkMhLJ69DKeA1mKxWx7V2WGrBhrwjPEbelhnZbq2htV VohorMH39FEijLw7F1ZjZwTD+0+MTL+rlAz4PAatSBPz4VBCWKkuH1BdnP1PUPHFyOyc B+120GN0HqmWbr9YLtROTuJwwwTEB6MfjsiOyQjL+h+cOg6rRDgJF/5+iWUjmtTvPd/Z Izuk10eJ0men53cYkP50yS4cufC8s5gAxPnCRULGUtElk2FCDas9XtV6QobAzWYeQizc og6UQM6mB36X6zK8ZRue50+WJvw8lOQiNvosF5V87wLGBXN+TSjKs5cEd4Q/+s1sT4qi fmeQ== X-Gm-Message-State: AOJu0YyBCZ7Ts21kqNEcC+35NsVvKwEKvX1jEpn85mggVnRREl08xwR9 qDnfeYDo6wD2tNVo4W44pCi1qPViewymHmuu4M32UwPmAe5JcttVyUXuHMAttnKxKMA490T4fki 0rqogNUBd4nV8BkgA8yFfPLcIJ7oQvbidub486vmUKL262gj/uTeQ7rJTkKxOzNMiCTh9zNo7ts PkRZtnhw== X-Received: by 2002:a2e:b043:0:b0:2c8:71b4:f8b5 with SMTP id d3-20020a2eb043000000b002c871b4f8b5mr8627680ljl.48.1701107763797; Mon, 27 Nov 2023 09:56:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjZ2vklhO5y5WBDRB9WrjNskLIyFIfmN1xLkOyrXqNLVTISjBasDTujnFWipogwXvDOLoGYw== X-Received: by 2002:a2e:b043:0:b0:2c8:71b4:f8b5 with SMTP id d3-20020a2eb043000000b002c871b4f8b5mr8627659ljl.48.1701107763335; Mon, 27 Nov 2023 09:56:03 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id t4-20020a0560001a4400b003316eb9db40sm12659346wry.51.2023.11.27.09.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 09:56:03 -0800 (PST) From: Andrew Burgess <aburgess@redhat.com> To: gdb-patches@sourceware.org Cc: Andrew Burgess <aburgess@redhat.com> Subject: [PATCH 0/7] Changes to gdb-index creation Date: Mon, 27 Nov 2023 17:55:54 +0000 Message-Id: <cover.1701107594.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Changes to gdb-index creation
|
|
Message
Andrew Burgess
Nov. 27, 2023, 5:55 p.m. UTC
Patches #1 and #2 are pretty straight forward improvements; don't think they will be controversial. Patch #4 is an interesting bug fix. Patches #6 and #7 are what this series is really all about. Making the indexes created by 'save gdb-index' be determenistic as the number of worker-threads that GDB uses changes. --- Andrew Burgess (7): gdb: allow use of ~ in 'save gdb-index' command gdb: option completion for 'save gdb-index' command gdb/testsuite: small refactor in selftest-support.exp gdb: reduce size of generated gdb-index file gdb: C++-ify mapped_symtab from dwarf2/index-write.c gdb: generate gdb-index identically regardless of work thread count gdb: generate dwarf-5 index identically as worker-thread count changes gdb/dwarf2/index-write.c | 315 ++++++++++++++----- gdb/testsuite/gdb.dwarf2/gdb-index-tilde.exp | 91 ++++++ gdb/testsuite/gdb.gdb/index-file.exp | 162 ++++++++++ gdb/testsuite/lib/gdb.exp | 15 + gdb/testsuite/lib/selftest-support.exp | 32 +- 5 files changed, 536 insertions(+), 79 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/gdb-index-tilde.exp create mode 100644 gdb/testsuite/gdb.gdb/index-file.exp base-commit: 935dc9ff652ca256c10672412c1df3da95cadbfb
Comments
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Patches #1 and #2 are pretty straight forward improvements; don't
Andrew> think they will be controversial.
Andrew> Patch #4 is an interesting bug fix.
Andrew> Patches #6 and #7 are what this series is really all about. Making
Andrew> the indexes created by 'save gdb-index' be determenistic as the number
Andrew> of worker-threads that GDB uses changes.
I read through this. I was a bit worried about new gdb.gdb tests (I
feel those are often more trouble than they're worth), but this one
avoids the problem stuff and anyway there doesn't seem to be a better
way to do it.
Anyway, I sent a nit or two, everything looks good to me.
Thanks for doing this, and nice find on the hash table bug.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
Tom Tromey <tom@tromey.com> writes: >>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes: > > Andrew> Patches #1 and #2 are pretty straight forward improvements; don't > Andrew> think they will be controversial. > > Andrew> Patch #4 is an interesting bug fix. > > Andrew> Patches #6 and #7 are what this series is really all about. Making > Andrew> the indexes created by 'save gdb-index' be determenistic as the number > Andrew> of worker-threads that GDB uses changes. > > I read through this. I was a bit worried about new gdb.gdb tests (I > feel those are often more trouble than they're worth), but this one > avoids the problem stuff and anyway there doesn't seem to be a better > way to do it. > > Anyway, I sent a nit or two, everything looks good to me. > Thanks for doing this, and nice find on the hash table bug. > > Approved-By: Tom Tromey <tom@tromey.com> I pushed this series. Thanks, Andrew