From patchwork Mon May 15 19:27:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 55766 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91A4F3857718 for ; Mon, 15 May 2023 19:28:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91A4F3857718 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684178897; bh=YdyUr0RIlddlj2imu7afBkbOUYd70ZYq/iM03eOTcn4=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=SSxIG2qyFWtPi1mBrELnCsiRAE9qQ+8r2vC9slpW9LgClRlstfSIFX6xoy5Zj4AW9 ODax5vlNvAbRQnqmrmMrcKSxJ3p23FQ2pii5uE4kcj2sJ0toAnPyjCDOahjgPwFbMH tzBktI94zsWV2i38VsqLx0I8dJv+H8ZOMb2eUUyo= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 335AC3858D20 for ; Mon, 15 May 2023 19:27:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 335AC3858D20 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-7rDxj8i6OEW5bq_IpGjZQw-1; Mon, 15 May 2023 15:27:50 -0400 X-MC-Unique: 7rDxj8i6OEW5bq_IpGjZQw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f420742d40so35262045e9.2 for ; Mon, 15 May 2023 12:27:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684178869; x=1686770869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YdyUr0RIlddlj2imu7afBkbOUYd70ZYq/iM03eOTcn4=; b=jJGyDcc7TQPDfnoCr/jSITVvBf09FQQ08nSX5BAscgCBVXLM9WpkCkCVV2kVFzgWNG ET3dX0Qz1CpVsv+fLQDsaPkIlV2FtkYnhyYaigcKQnoMf2NQO7ewYqoXJRM7En/uSPze tUm6DhTU4SD+ZSKKSJAFacG/i+ATvdD2s+pmihOmpKhJDZNCJXVD0ObntD4DAbgFZwVX K6nToQxq+ux2FN6Da/95BOes37CAlNv2DuUH/rm6zPkNJLLjYLlON+4kZOgOLl+MtsSl HR+bjSExWaqTgyPRZvni3amGYLIcevvGWR9JIqrLNAxTbZOWpssuUVjbb5RYJToMbFrZ i8aw== X-Gm-Message-State: AC+VfDzXuxQ+yc3YgNTWr7KKTplxNMh0VjH0/78eKDSsFLo+FzGd76Sd A+HPr9kKPeJ5Z25gG8n6O7YH8zDujJnuGXD7CBarLPDJ6Jn3VTyceTyRqvaHQ53Bc0uAIBgdq/J SUPtWjHKWs7nJ0XYLv2CHaS7X8MReGoSuQCp2piF6bZV6ghPztmY04jgSodG0lA+IYNKDiqxbns oG15L40A== X-Received: by 2002:a1c:f616:0:b0:3f4:20ea:d778 with SMTP id w22-20020a1cf616000000b003f420ead778mr21534578wmc.37.1684178869332; Mon, 15 May 2023 12:27:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7MQ/YBH4Y/dkkJtolyxs6NiDw8squrHILpLuBI23KYzOP6Fzj1ALG2L3WiyItrpVV2hcN6kA== X-Received: by 2002:a1c:f616:0:b0:3f4:20ea:d778 with SMTP id w22-20020a1cf616000000b003f420ead778mr21534566wmc.37.1684178869002; Mon, 15 May 2023 12:27:49 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id c16-20020a5d4f10000000b0030732d6e104sm60259wru.105.2023.05.15.12.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 12:27:48 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/9] thread-specific breakpoints in just some inferiors Date: Mon, 15 May 2023 20:27:36 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" In v2: - Rebased on current upstream/master and retested, - No changes to code or docs. --- Andrew Burgess (9): gdb: create_breakpoint: assert for a valid thread-id gdb: create_breakpoint: asserts relating to extra_string/parse_extra gdb: change 'if' to gdb_assert in update_dprintf_command_list gdb: build dprintf commands just once in code_breakpoint constructor gdb: don't display inferior list for pending breakpoints gdb: parse pending breakpoint thread/task immediately gdb: remove breakpoint_re_set_one gdb: remove tracepoint_probe_create_sals_from_location_spec gdb: only insert thread-specific breakpoints in the relevant inferior gdb/Makefile.in | 2 + gdb/NEWS | 11 + gdb/ada-lang.c | 6 +- gdb/break-catch-throw.c | 6 +- gdb/break-cond-parse.c | 403 +++++++++++ gdb/break-cond-parse.h | 47 ++ gdb/breakpoint.c | 666 ++++++++---------- gdb/breakpoint.h | 64 +- gdb/testsuite/gdb.base/condbreak.exp | 20 +- gdb/testsuite/gdb.base/pending.exp | 23 +- gdb/testsuite/gdb.linespec/explicit.exp | 4 +- gdb/testsuite/gdb.mi/mi-dprintf-pending.exp | 3 +- .../gdb.mi/user-selected-context-sync.exp | 2 +- .../gdb.multi/bp-thread-specific.exp | 7 +- .../gdb.multi/multi-target-continue.exp | 2 +- .../gdb.multi/multi-target-ping-pong-next.exp | 4 +- gdb/testsuite/gdb.multi/pending-bp-lib.c | 22 + gdb/testsuite/gdb.multi/pending-bp.c | 66 ++ gdb/testsuite/gdb.multi/pending-bp.exp | 321 +++++++++ gdb/testsuite/gdb.multi/tids.exp | 6 +- .../gdb.threads/del-pending-thread-bp-lib.c | 22 + .../gdb.threads/del-pending-thread-bp.c | 85 +++ .../gdb.threads/del-pending-thread-bp.exp | 108 +++ 23 files changed, 1498 insertions(+), 402 deletions(-) create mode 100644 gdb/break-cond-parse.c create mode 100644 gdb/break-cond-parse.h create mode 100644 gdb/testsuite/gdb.multi/pending-bp-lib.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp.exp create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp-lib.c create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.c create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.exp base-commit: 6a1cf1bfedbcdb977d9ead3bf6a228360d78cc1b