From patchwork Fri Mar 31 20:20:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 55643 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 65BB9385781F for ; Fri, 31 Mar 2023 20:21:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 65BB9385781F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680294089; bh=6VSA72n81sqouw930bQVriQB99ciMaHIJZrKPAND+xw=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=nDmYfMGjlor7kF9UAZaNlAIAl77clmQEdNfkC20+a4sg21UuFjog5RIcSvK32xOTQ GFh7l4/lVv4Qsna1e+C0sojiNrxImuTP7hB+e9+xbfv9OeNWpF1yDpkKjrEUEHwfEk KuElJwDQEuB7IbZlBgs/ZWci3zdKbzJ9DAq0UC0A= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E62CE3858409 for ; Fri, 31 Mar 2023 20:21:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E62CE3858409 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-IeUakS0pMZuXI_QQUknXkA-1; Fri, 31 Mar 2023 16:21:02 -0400 X-MC-Unique: IeUakS0pMZuXI_QQUknXkA-1 Received: by mail-wr1-f71.google.com with SMTP id d5-20020adfa345000000b002d716fc080fso2662884wrb.22 for ; Fri, 31 Mar 2023 13:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680294061; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6VSA72n81sqouw930bQVriQB99ciMaHIJZrKPAND+xw=; b=v+MobJUvwQQkkk2nxqj4ShbW7kb5Hxl0/laOwu99eLd9t9e9+PcjFQyKvBW4hpfXIf CG8BTqLggVidprntZ7rMDQCSOOhpdvbZzuQhw/m80Jl8Nr2f7Z2E1SGO3F+Mve+BvpDE tPKsAQPWLf+gN9vw/WrZqospe+EoVqA/XqbWsYcioS8Zdw60UNY1mRrtEI/+hcgYl2DC 9tsJPNgFqqYj+RvXL9ZqPcKEqxh+puVld1ukzi5n0lFxZw1EukSIDGrFZegaGUQ3Br9C mvc5B1DMDCUopvR/gJl3wqIZckxsuCAP+Sw+ehvTYLyEnPHs5q783QtCi6RQSDu3xYas mJBA== X-Gm-Message-State: AO0yUKW7wilxnmLI/Kb1qhbeQ39rrH7rEEKCevSkrqXCrD/IyN7JGfah qeVow8U3cTKb2x1WIAIoCIhfaxn4MbonHchT3ymv7McV+UWkQMZ+Fz2DOGE/8nfgo4TTYFzEZIr gwMhg4i8LEUpILbZfFzOY22utFmqfWstqhFcnSH/Ja/Iw8XE14shGrR/NSQ7h2QcLicDSCyeHVc sKK+9Lfw== X-Received: by 2002:a7b:ce0a:0:b0:3ed:237f:3da with SMTP id m10-20020a7bce0a000000b003ed237f03damr22380926wmc.22.1680294060974; Fri, 31 Mar 2023 13:21:00 -0700 (PDT) X-Google-Smtp-Source: AK7set9jVDgq8nNjlqXkKyqP4/7O7Z+BQQd9CjQn/36BcrXeYSOBe+mteUZGQmgWXJiLgnUFtKBu/g== X-Received: by 2002:a7b:ce0a:0:b0:3ed:237f:3da with SMTP id m10-20020a7bce0a000000b003ed237f03damr22380910wmc.22.1680294060542; Fri, 31 Mar 2023 13:21:00 -0700 (PDT) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id r16-20020a05600c459000b003f03d483966sm5517969wmo.44.2023.03.31.13.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 13:21:00 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/5] gdb/testsuite: stricter matching for gdb_test Date: Fri, 31 Mar 2023 21:20:53 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The goal of this series is to make the pattern matching in gdb_test stricter with respect to end of line sequences. This encourages us all to be a little more precise when writting the output patterns for use in gdb_test, but I think this is a good thing for GDB - our tests will get a little stricter. The final patch adds a new feature to gdb_test, a modified version of the '^' anchor, which again, should (I hope) allow us to write stricter output patterns, which I think is a good thing for GDB. Thanks, Andrew Reviewed-By: Tom Tromey --- Andrew Burgess (5): gdb/testsuite: fix occasional failure in gdb.base/clear_non_user_bp.exp gdb: remove some trailing newlines from warning messages gdb/testsuite: use 'return' in gdb_test_no_output gdb/testsuite: change newline patterns used in gdb_test gdb/testsuite: special case '^' in gdb_test pattern gdb/language.c | 8 +- gdb/remote.c | 4 +- gdb/testsuite/gdb.ada/varsize_limit.exp | 2 +- gdb/testsuite/gdb.arch/amd64-entry-value.exp | 59 +++++++--- .../gdb.arch/amd64-invalid-stack-middle.exp | 4 +- .../gdb.arch/amd64-invalid-stack-top.exp | 4 +- gdb/testsuite/gdb.base/call-rt-st.exp | 2 +- gdb/testsuite/gdb.base/charset.exp | 4 +- gdb/testsuite/gdb.base/clear_non_user_bp.exp | 2 +- gdb/testsuite/gdb.base/compare-sections.exp | 2 +- gdb/testsuite/gdb.base/default.exp | 4 +- gdb/testsuite/gdb.base/display.exp | 10 +- gdb/testsuite/gdb.base/foll-fork.exp | 2 +- gdb/testsuite/gdb.base/fullpath-expand.exp | 4 +- gdb/testsuite/gdb.base/info-macros.exp | 12 +- .../gdb.base/multi-line-starts-subshell.exp | 2 +- gdb/testsuite/gdb.base/new-ui-echo.exp | 4 +- gdb/testsuite/gdb.base/new-ui.exp | 6 +- gdb/testsuite/gdb.base/pc-fp.exp | 2 +- gdb/testsuite/gdb.base/pending.exp | 2 +- gdb/testsuite/gdb.base/rtld-step.exp | 4 +- gdb/testsuite/gdb.base/setshow.exp | 4 +- gdb/testsuite/gdb.base/settings.exp | 9 +- gdb/testsuite/gdb.base/signals.exp | 2 +- gdb/testsuite/gdb.base/until.exp | 2 +- gdb/testsuite/gdb.base/watch-bitfields.exp | 4 +- gdb/testsuite/gdb.base/watchpoint.exp | 17 +-- gdb/testsuite/gdb.base/with.exp | 15 ++- .../gdb.base/wrong_frame_bt_full.exp | 4 +- gdb/testsuite/gdb.btrace/buffer-size.exp | 4 +- .../gdb.btrace/function_call_history.exp | 2 +- .../gdb.btrace/instruction_history.exp | 10 +- gdb/testsuite/gdb.btrace/record_goto.exp | 8 +- .../gdb.cp/incomplete-type-overload.exp | 2 +- gdb/testsuite/gdb.cp/maint.exp | 8 +- gdb/testsuite/gdb.cp/ovldbreak.exp | 14 +-- gdb/testsuite/gdb.cp/userdef.exp | 20 ++-- gdb/testsuite/gdb.cp/virtfunc.exp | 23 +++- gdb/testsuite/gdb.guile/scm-breakpoint.exp | 2 +- gdb/testsuite/gdb.guile/scm-cmd.exp | 2 +- gdb/testsuite/gdb.linespec/break-ask.exp | 4 +- .../gdb.mi/user-selected-context-sync.exp | 2 +- gdb/testsuite/gdb.opt/inline-break.exp | 6 +- gdb/testsuite/gdb.python/py-breakpoint.exp | 6 +- gdb/testsuite/gdb.python/py-framefilter.exp | 2 +- gdb/testsuite/gdb.python/python.exp | 2 +- .../gdb.reverse/machinestate-precsave.exp | 60 +++++----- gdb/testsuite/gdb.reverse/machinestate.exp | 60 +++++----- gdb/testsuite/gdb.stabs/exclfwd.exp | 4 +- .../gdb.threads/foll-fork-other-thread.exp | 2 +- gdb/testsuite/gdb.threads/gcore-thread.exp | 4 +- gdb/testsuite/gdb.trace/actions.exp | 109 +++++++++--------- gdb/testsuite/gdb.trace/deltrace.exp | 73 ++++++------ gdb/testsuite/gdb.trace/infotrace.exp | 6 +- gdb/testsuite/gdb.trace/passcount.exp | 8 +- gdb/testsuite/gdb.trace/tracecmd.exp | 8 +- gdb/testsuite/gdb.trace/while-stepping.exp | 2 +- gdb/testsuite/lib/gdb.exp | 35 ++++-- 58 files changed, 385 insertions(+), 303 deletions(-) base-commit: 3712e78cab09017bf59105d44e2f745c5e608c5a