From patchwork Mon Mar 6 15:31:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 55557 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B8443385B51B for ; Mon, 6 Mar 2023 15:32:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B8443385B51B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678116749; bh=Ug72mP7f8M7zBj9n7nFATqQeU56eYLyEPERPkYuu87U=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BcEYtsLPnbMhsGqfTnZX9QKllCi3C/c9qCpgDDKPDHumXNRdE+zDNut0k2q6lIYgq cvLW2gYm0/01Mmkn0ffJgJrvExCdFkzd/SwJ1X16kh8VGWghhDJnLWiyy9VhLdXCld pp1zbCiFYSf9eugzuuxNSkiiECROgbeBQ/IK/ch4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C149D3858D39 for ; Mon, 6 Mar 2023 15:32:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C149D3858D39 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-bBxZ7SmTMWOx9lA1TFLAaQ-1; Mon, 06 Mar 2023 10:32:02 -0500 X-MC-Unique: bBxZ7SmTMWOx9lA1TFLAaQ-1 Received: by mail-ed1-f72.google.com with SMTP id ev6-20020a056402540600b004bc2358ac04so14510509edb.21 for ; Mon, 06 Mar 2023 07:32:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678116721; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ug72mP7f8M7zBj9n7nFATqQeU56eYLyEPERPkYuu87U=; b=ttL+lrw5rmMrQhbLKi6h8rnLXulMKeqSw/lXHJ+4zFIvddpj0rKzqILqmSfPGJRP0+ Y+0jnhPJ7+k/UzGb1+c/EfC+cO73K/Ueu5XLiOE+/Lf+JKc6Cwz+LZtIB0YCGKaHTaqU T2toT9v/Da3p9jyXm/92KhExrDSHN7bIRR8nLQPFK0S07ckNg18E2UYVAVOq9rWyNX4Y AhNQsyMWbCrY+8tyfCWl7sr5gfh5toeZhw2ZjxbNx8C2hrHnUmVFtG8leG/xnKWPry46 A8OhpgSlUj5PCXHYlUh6IYEEtnLr4R0Fo6o41OxROcHvlQu7EwZIpZ1CX4IrA7GGTQE4 VIlw== X-Gm-Message-State: AO0yUKU7UG1XvJQ4zgGhTZJoeymERdCvg9DGP1x2MOIKUp6xhBgNuoz5 jFjnuH4zijveqr+3SwyrOSdqLPubl/x8lZLqhuuLp+3SGKeJz5VEgJW7sSCSkBpKC+2AGtoZFTm 6E/slCN/twet5uzQv2JGUCEomWftJHmkD7b1yn1l1KcpLJ9/YKpbqJe+aX/QK2WV20s6NwzrXGv tVkvOliw== X-Received: by 2002:a17:906:99d3:b0:880:a42d:dfb4 with SMTP id s19-20020a17090699d300b00880a42ddfb4mr12344699ejn.16.1678116720861; Mon, 06 Mar 2023 07:32:00 -0800 (PST) X-Google-Smtp-Source: AK7set9dZs89LAbb8oWjWbdRFcN931xLFl5NQOmLCrgXnfGGHhUik0yhHh+4q1SBUPGk8rmBw/XPNg== X-Received: by 2002:a17:906:99d3:b0:880:a42d:dfb4 with SMTP id s19-20020a17090699d300b00880a42ddfb4mr12344683ejn.16.1678116720454; Mon, 06 Mar 2023 07:32:00 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id c15-20020a170906170f00b008c6c47f59c1sm4658928eje.48.2023.03.06.07.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 07:32:00 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/5] Add new gdbarch::displaced_step_buffer_length field Date: Mon, 6 Mar 2023 15:31:52 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Changes in v2: - The final patch (#5), actually adding displaced_step_buffer_length has been updated inline with Simon's feedback. The changes are pretty minor so I've added the Approved-By tag. - Patches #1 and #2 are new in this version. These two patches are removing fields from gdbarch_components.py that have no effect on the generated source. Removing these fields makes it easier to refactor the gdbarch.py code in later commits. - Patch #3 is from the v1 series and hasn't changed significantly. I dropped the comment change on max_insn_length. Simon was correct in his feedback, the changes I made to this comment made little sense. The rest of the patch is basically unchagned. - Patch #4 is new in this version. This makes the changes Simon wanted to see about the 'invalid' field no longer being able to take the value 'None', and also we can now have both a predicate and a string 'invalid' field. I did play with splitting these two changes (invalid can't be None and predicate+string invalid), but this made little sense, and was really forced. Allowing the second seems to fall naturally out of refactoring the 'invalid' field to stop it taking the value 'None'. Thoughts? Thanks, Andrew --- Andrew Burgess (5): gdb/gdbarch: remove unused 'invalid=True' from gdbarch_components.py gdb/gdbarch: remove yet more 'invalid=True' from gdbarch_components.py gdb/gdbarch: split postdefault setup from invalid check in gdbarch.py gdb/gdbarch: remove the 'invalid=None' state from gdbarch_components.py gdb: add gdbarch::displaced_step_buffer_length gdb/aarch64-linux-tdep.c | 4 +- gdb/arm-tdep.c | 4 +- gdb/displaced-stepping.c | 6 +- gdb/gdbarch-gen.h | 12 +++- gdb/gdbarch.c | 42 ++++++++++++ gdb/gdbarch.py | 60 ++++++++--------- gdb/gdbarch_components.py | 131 ++++++++++---------------------------- gdb/gdbarch_types.py | 7 +- gdb/linux-tdep.c | 2 +- gdb/rs6000-tdep.c | 6 +- 10 files changed, 134 insertions(+), 140 deletions(-) base-commit: 6a208145d24c47912c8beb4f1f4b9abeb8d51134