mbox series

[PATCHv3,0/3] Python/TUI Window Creation / Destruction Fixes

Message ID cover.1674837139.git.aburgess@redhat.com
Headers
Series Python/TUI Window Creation / Destruction Fixes |

Message

Andrew Burgess Jan. 27, 2023, 4:34 p.m. UTC 
  This series conflicted with my other TUI series, that I just merged.
No real changes in v3, just resolved the merge conflicts.

Changes since v2:

  - Rebased onto HEAD of upsstream, resolved merged conflicts in patch
    #3.

Changes since v1:

  - Rebased onto HEAD of upstream,

  - Reworded the commit message for patch #2.

---

Andrew Burgess (3):
  gdb/python: allow Python TUI windows to be replaced
  gdb/python: deallocate tui window factories at Python shut down
  gdb/tui: don't leak the known_window_types map

 gdb/python/py-tui.c                           |  52 ++++++++-
 gdb/python/python-internal.h                  |   1 +
 gdb/python/python.c                           |   1 +
 .../gdb.python/tui-window-factory.exp         | 105 ++++++++++++++++++
 .../gdb.python/tui-window-factory.py          |  48 ++++++++
 gdb/tui/tui-layout.c                          |  43 +++----
 6 files changed, 227 insertions(+), 23 deletions(-)
 create mode 100644 gdb/testsuite/gdb.python/tui-window-factory.exp
 create mode 100644 gdb/testsuite/gdb.python/tui-window-factory.py


base-commit: 2d46b103a52e4597ee60aa224ef4e5fb225ba893

Comments

Andrew Burgess Feb. 13, 2023, 12:32 p.m. UTC | #1 
Andrew Burgess <aburgess@redhat.com> writes:

> This series conflicted with my other TUI series, that I just merged.
> No real changes in v3, just resolved the merge conflicts.
>
> Changes since v2:
>
>   - Rebased onto HEAD of upsstream, resolved merged conflicts in patch
>     #3.
>
> Changes since v1:
>
>   - Rebased onto HEAD of upstream,
>
>   - Reworded the commit message for patch #2.
>

Ping!  If it helps at all, only patch #2 is really interesting.

Thanks,
Andrew



> ---
>
> Andrew Burgess (3):
>   gdb/python: allow Python TUI windows to be replaced
>   gdb/python: deallocate tui window factories at Python shut down
>   gdb/tui: don't leak the known_window_types map
>
>  gdb/python/py-tui.c                           |  52 ++++++++-
>  gdb/python/python-internal.h                  |   1 +
>  gdb/python/python.c                           |   1 +
>  .../gdb.python/tui-window-factory.exp         | 105 ++++++++++++++++++
>  .../gdb.python/tui-window-factory.py          |  48 ++++++++
>  gdb/tui/tui-layout.c                          |  43 +++----
>  6 files changed, 227 insertions(+), 23 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.python/tui-window-factory.exp
>  create mode 100644 gdb/testsuite/gdb.python/tui-window-factory.py
>
>
> base-commit: 2d46b103a52e4597ee60aa224ef4e5fb225ba893
> -- 
> 2.25.4
Tom Tromey Feb. 13, 2023, 2:11 p.m. UTC | #2 
Andrew> Ping!  If it helps at all, only patch #2 is really interesting.

This all looked good to me.

Reviewed-By: Tom Tromey <tom@tromey.com>

Tom
Andrew Burgess Feb. 13, 2023, 2:52 p.m. UTC | #3 
Tom Tromey <tom@tromey.com> writes:

> Andrew> Ping!  If it helps at all, only patch #2 is really interesting.
>
> This all looked good to me.
>
> Reviewed-By: Tom Tromey <tom@tromey.com>

Pushed.

Thanks,
Andrew