mbox series

[0/6] The DWARF assembler and Clang

Message ID cover.1668184173.git.aburgess@redhat.com
Headers
Series The DWARF assembler and Clang |

Message

Andrew Burgess Nov. 11, 2022, 4:36 p.m. UTC 
  In a reply to a recent mailing list message of mine, it was mentioned
that the DWARF assembler doesn't work with Clang.

I know that once upon a time this was the case, but I thought those
problems had long been fixed, but I did some investigation anyway.

I ran all the tests that mention 'Dwarf::assemble' and compared the
results between gcc and Clang.  This series addresses all the
regressions that I found.

The general summary is that the DWARF assembler works fine with Clang.
All the issues I found were minor, and specific to individual tests.

The final patch converts an existing test to use the DWARF assembler,
when I proposed this earlier the feedback was the DWARF assembler
doesn't work with Clang.  My claim is that it's fine, and switching to
the DWARF assembler will increase test coverage.

Thanks,
Andrew

---

Andrew Burgess (6):
  gdb/testsuite: don't avoid DWARF assembler tests with Clang
  gdb/testsuite: fix gdb.trace/unavailable-dwarf-piece.exp with Clang
  gdb/testsuite: fix gdb.compile/compile-ops.exp with clang
  gdb/testsuite: add (and use) a new build-id compile option
  gdb/testsuite: fix gdb.debuginfod/fetch_src_and_symbols.exp with Clang
  gdb/testsuite: rewrite gdb.cp/call-method-register.exp with dwarf
    assembler

 .../gdb.base/until-trailing-insns.exp         |   6 -
 gdb/testsuite/gdb.compile/compile-ops.c       |   8 +-
 gdb/testsuite/gdb.compile/compile-ops.exp     |  18 ++-
 gdb/testsuite/gdb.cp/call-method-register.cc  |  49 +-------
 gdb/testsuite/gdb.cp/call-method-register.exp | 108 +++++++++++++-----
 .../gdb.cp/incomplete-type-overload.exp       |   5 -
 .../gdb.debuginfod/fetch_src_and_symbols.exp  |  25 +++-
 .../gdb.trace/unavailable-dwarf-piece.exp     |   4 +-
 gdb/testsuite/lib/gdb.exp                     |   9 ++
 9 files changed, 130 insertions(+), 102 deletions(-)


base-commit: db2e277d1a840091f56185d94f9d39c6736d2556

Comments

Tom Tromey Nov. 16, 2022, 4:32 p.m. UTC | #1 
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> The general summary is that the DWARF assembler works fine with Clang.
Andrew> All the issues I found were minor, and specific to individual tests.

I sent a couple of notes; but aside from those and the other responses,
everything looks good to me.  Thank you for doing this.

Tom
Andrew Burgess Nov. 18, 2022, 11:48 a.m. UTC | #2 
Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> The general summary is that the DWARF assembler works fine with Clang.
> Andrew> All the issues I found were minor, and specific to individual tests.
>
> I sent a couple of notes; but aside from those and the other responses,
> everything looks good to me.  Thank you for doing this.

Thanks for the reviews.  I made the changes Lancelot suggested, and
pushed this series.

Andrew