| Message ID | 20250411175022.2379494-1-guinevere@redhat.com |
|---|---|
| Headers |
Return-Path: <gdb-patches-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72E9B382FAE3 for <patchwork@sourceware.org>; Fri, 11 Apr 2025 17:52:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72E9B382FAE3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D4YO5dy6 X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F40FC384D1AC for <gdb-patches@sourceware.org>; Fri, 11 Apr 2025 17:50:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F40FC384D1AC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F40FC384D1AC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744393855; cv=none; b=itqYeCbMtujw1v87xBckmqoQNcFpTAk+V8SJz4QsBKm1QTut9IHLBYkWQ9Uz7A5G7vUX70mm1SZ8hj93+yxgNS8iM6TM/9Vk/5XkO+t7G2RpAIrH8t4a9qaWmP13J/krS2eLMcfteRIq7QRMxA9PL4Gx3hRe/yn3G4da7gHenyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744393855; c=relaxed/simple; bh=Y0plx/lQbUCfZE2tYgbmB1aIcl5TCF9Z0FMw4uK2wcY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VxOMXZGLnaSE+lQmSZbzJeAl+sX7iElUNh7W69Jn3ZS7JLRPnmDegPHN0GIsRvkciK3AnxyGB+rJsfdwPk/SwjyeHzdtXvY9RsBY6itXQZ2AMsJRR2g4oOI8sWfMJUihjlIhEiChdf3lcMH/nBUyjmVGmOwd+MVTK8BouY3xkRY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F40FC384D1AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744393854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TYvmvZS3MHW64Z5mQtU6xHVj/z7Bc7gCyZ0cXNQb0jw=; b=D4YO5dy6XNYGsclqYNUpmfKy2u8G9D0sAa6xUhXdUFvTzUSXbqS9UcEdkseLOxkHFXjr47 gH3kY7XdSHBmHMjxZmLX6Gp0/7wSYF9zpcqrJaLAaRu4q1gvO9ZG8mVW3L6pQJCaxmK/g0 akRB+nZ6hepWinxBJJC11SGSvKN9nIg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-326-t_61F2MxP7G_Jo2MVaLu4w-1; Fri, 11 Apr 2025 13:50:53 -0400 X-MC-Unique: t_61F2MxP7G_Jo2MVaLu4w-1 X-Mimecast-MFC-AGG-ID: t_61F2MxP7G_Jo2MVaLu4w_1744393851 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9E497180AF7C for <gdb-patches@sourceware.org>; Fri, 11 Apr 2025 17:50:51 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.43]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B3F0192C7C6; Fri, 11 Apr 2025 17:50:49 +0000 (UTC) From: Guinevere Larsen <guinevere@redhat.com> To: gdb-patches@sourceware.org Cc: Guinevere Larsen <guinevere@redhat.com> Subject: [PATCH v3 0/3] Add some linker namespaces conveniences Date: Fri, 11 Apr 2025 14:50:19 -0300 Message-ID: <20250411175022.2379494-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yiIjTR7sv4tmJqsTDOAlEPuEYEOolMmzi3Q9ySvTBgA_1744393851 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org |
| Series |
Add some linker namespaces conveniences
|
|
Message
Guinevere Larsen
April 11, 2025, 5:50 p.m. UTC
This series is a second step in improving the User Experience of debugging inferiors with multiple namespaces. It adds 2 things to make it more convenient for users to understand what the inferior is doing. The first patch adds convenience variables, specifically _active_linker_namespaces and _current_linker_namespaces. These can be used to track where in the execution of an inferior the user is, and could be used in breakpoint conditions to stop at a specific namespace. The third patch adds a new command, "info linker-namespaces", to help the user check what solibs are loaded, and where. To make the patch more readable, the second patch is a minor refactor of the command "info sharedlibrary". The documentation changes have already been reviewed by Eli. Changes for v3: * Changed the final gdb.base/dlmopen-ns-ids.exp test to allow for linker namespaces that don't load libc and libm, since some systems may not do it. Changes for v2: * Renamed new command and variables to explicitly mention linker namespaces Guinevere Larsen (3): gdb: add convenience variables around linker namespace debugging gdb: factor out printing a table of solibs for info sharedlibrary GDB: Introduce "info namespaces" command gdb/NEWS | 11 + gdb/doc/gdb.texinfo | 28 ++ gdb/solib-svr4.c | 55 ++++ gdb/solib.c | 267 ++++++++++++++----- gdb/solist.h | 4 + gdb/testsuite/gdb.base/default.exp | 2 + gdb/testsuite/gdb.base/dlmopen-ns-ids-main.c | 6 + gdb/testsuite/gdb.base/dlmopen-ns-ids.exp | 129 +++++++++ 8 files changed, 442 insertions(+), 60 deletions(-) base-commit: 52c5091dfb18113156d645500ab86b600f1cdfe0
Comments
On Fri, 11 Apr 2025 14:50:19 -0300 Guinevere Larsen <guinevere@redhat.com> wrote: > This series is a second step in improving the User Experience of > debugging inferiors with multiple namespaces. It adds 2 things to make > it more convenient for users to understand what the inferior is doing. > > The first patch adds convenience variables, specifically > _active_linker_namespaces and _current_linker_namespaces. These can be > used to track where in the execution of an inferior the user is, and > could be used in breakpoint conditions to stop at a specific namespace. > > The third patch adds a new command, "info linker-namespaces", to help the > user check what solibs are loaded, and where. To make the patch more > readable, the second patch is a minor refactor of the command "info > sharedlibrary". > > The documentation changes have already been reviewed by Eli. > > Changes for v3: > * Changed the final gdb.base/dlmopen-ns-ids.exp test to allow for linker > namespaces that don't load libc and libm, since some systems may not > do it. > > Changes for v2: > * Renamed new command and variables to explicitly mention linker > namespaces > > Guinevere Larsen (3): > gdb: add convenience variables around linker namespace debugging > gdb: factor out printing a table of solibs for info sharedlibrary > GDB: Introduce "info namespaces" command > > gdb/NEWS | 11 + > gdb/doc/gdb.texinfo | 28 ++ > gdb/solib-svr4.c | 55 ++++ > gdb/solib.c | 267 ++++++++++++++----- > gdb/solist.h | 4 + > gdb/testsuite/gdb.base/default.exp | 2 + > gdb/testsuite/gdb.base/dlmopen-ns-ids-main.c | 6 + > gdb/testsuite/gdb.base/dlmopen-ns-ids.exp | 129 +++++++++ > 8 files changed, 442 insertions(+), 60 deletions(-) I'm still comfortable with the approvals that I provided earlier for the v2 series. Approved-by: Kevin Buettner <kevinb@redhat.com>
On 4/17/25 8:43 PM, Kevin Buettner wrote: > On Fri, 11 Apr 2025 14:50:19 -0300 > Guinevere Larsen <guinevere@redhat.com> wrote: > >> This series is a second step in improving the User Experience of >> debugging inferiors with multiple namespaces. It adds 2 things to make >> it more convenient for users to understand what the inferior is doing. >> >> The first patch adds convenience variables, specifically >> _active_linker_namespaces and _current_linker_namespaces. These can be >> used to track where in the execution of an inferior the user is, and >> could be used in breakpoint conditions to stop at a specific namespace. >> >> The third patch adds a new command, "info linker-namespaces", to help the >> user check what solibs are loaded, and where. To make the patch more >> readable, the second patch is a minor refactor of the command "info >> sharedlibrary". >> >> The documentation changes have already been reviewed by Eli. >> >> Changes for v3: >> * Changed the final gdb.base/dlmopen-ns-ids.exp test to allow for linker >> namespaces that don't load libc and libm, since some systems may not >> do it. >> >> Changes for v2: >> * Renamed new command and variables to explicitly mention linker >> namespaces >> >> Guinevere Larsen (3): >> gdb: add convenience variables around linker namespace debugging >> gdb: factor out printing a table of solibs for info sharedlibrary >> GDB: Introduce "info namespaces" command >> >> gdb/NEWS | 11 + >> gdb/doc/gdb.texinfo | 28 ++ >> gdb/solib-svr4.c | 55 ++++ >> gdb/solib.c | 267 ++++++++++++++----- >> gdb/solist.h | 4 + >> gdb/testsuite/gdb.base/default.exp | 2 + >> gdb/testsuite/gdb.base/dlmopen-ns-ids-main.c | 6 + >> gdb/testsuite/gdb.base/dlmopen-ns-ids.exp | 129 +++++++++ >> 8 files changed, 442 insertions(+), 60 deletions(-) > I'm still comfortable with the approvals that I provided earlier for > the v2 series. > > Approved-by: Kevin Buettner <kevinb@redhat.com> > I pushed this patch. There was some conversation on IRC about details, but since Simon said he didn't have the time to review in depth, and didn't show interest in me delaying pushing, I figured I could push it. And anyway, in my opinion, as long as we haven't branched for GDB 17 yet, I think we should be ok with changing those details, so if the changes are requested, I think a future patch could change with little overhead (for now).