mbox series

[0/4] Fix split DWARF + type unit regression

Message ID 20250407175247.3312551-1-simon.marchi@polymtl.ca
Headers
Series Fix split DWARF + type unit regression |

Message

Simon Marchi April 7, 2025, 5:51 p.m. UTC 
  From: Simon Marchi <simon.marchi@polymtl.ca>

This fixes a regression introduced by 71a48752660b ("gdb/dwarf: remove
create_dwo_cu_reader").  See the last patch for more details.

Simon Marchi (4):
  gdb/testsuite: add DWARF 5 + split DWARF + type units board
  gdb/testsuite/dwarf: add support to generate DWARF 5 split compile
    units
  gdb/testsuite/dwarf: fix abbrev section name when putting type unit in
    DWO file
  gdb/dwarf2: pass correct dwarf2_cu to lookup_dwo_id in
    create_cus_hash_table

 gdb/dwarf2/read.c                             |   2 +-
 .../boards/dwarf5-fission-debug-types.exp     |  33 ++++++
 .../gdb.dwarf2/fission-with-type-unit.c       |  23 ++++
 .../gdb.dwarf2/fission-with-type-unit.exp     | 105 ++++++++++++++++++
 gdb/testsuite/lib/dwarf.exp                   |  50 ++++++++-
 gdb/testsuite/make-check-all.sh               |   1 +
 6 files changed, 211 insertions(+), 3 deletions(-)
 create mode 100644 gdb/testsuite/boards/dwarf5-fission-debug-types.exp
 create mode 100644 gdb/testsuite/gdb.dwarf2/fission-with-type-unit.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/fission-with-type-unit.exp


base-commit: 2707d55e539ef323dd14a1293e762bf3d9739ee7

Comments

Tom Tromey April 8, 2025, 3:49 p.m. UTC | #1 
>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:

Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
Simon> This fixes a regression introduced by 71a48752660b ("gdb/dwarf: remove
Simon> create_dwo_cu_reader").  See the last patch for more details.

Thanks.  I had one minor note but the rest looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Simon Marchi April 8, 2025, 6:03 p.m. UTC | #2 
On 4/8/25 11:49 AM, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
> Simon> This fixes a regression introduced by 71a48752660b ("gdb/dwarf: remove
> Simon> create_dwo_cu_reader").  See the last patch for more details.
> 
> Thanks.  I had one minor note but the rest looks good to me.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, will push with that fixed.

Simon