From patchwork Mon Mar 10 15:10:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 58104 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD17D3858C56 for ; Mon, 10 Mar 2025 15:12:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD17D3858C56 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=lzlKPHqw X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3DF063858D38 for ; Mon, 10 Mar 2025 15:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DF063858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3DF063858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741619539; cv=none; b=ZWrx1HGGO78dkQa0yEzP8qSsW8vxk3JALBSKSUp/1wdnk7O9wdfsnv0tSHv5ODieiPa82xdOkVvYHOTAU8NdE+goKstYLumEjbr3M8ww5+10jtG79bfOq+ZRn7J0OjOuPZPhVpEl632N4B5wNzvkKbMDnl2BmRsD7IwbNvkGgnU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741619539; c=relaxed/simple; bh=tQREHt6fcufC6YGppuSy+XMoL1QUP42NkQm5F3KHteM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VoRD+J+JsrIrp9GwdcQVkndWJIWX6d8VezNJIvmhVidSL5DqQnXP/mmWqt5+tgHNVrVIcQBMYjlQazZttaQ0g+NNUXRzh/s8xKoarAIROw1YQKkYnwj/IG7Fg/2XvwsfhQY7tJcq4Zvp+ANwWjFHXdAml2o8YLHtDaWQBMrxDV0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DF063858D38 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 52AFCD0D236255 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Mar 2025 11:12:18 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 52AFCD0D236255 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1741619538; bh=SSpMLKlss3Kjxts7cX+04/6cq8AJsravuyB6lVZm/7M=; h=From:To:Cc:Subject:Date:From; b=lzlKPHqwh/TOq3MWvyi3scEFEb/5twk1aMim1TxtDhL1ecWXe4srfBXAB+/wZoAE6 SOac48lkfsPj9layvjmW80gdl67PheXNPP6zzSkmO0gRhdC96HgXLXgIaBdrsmgmQr OlI1afTLtos5UmSbAQrF530PPfwbRpJVtRfpBvPw= Received: by simark.ca (Postfix, from userid 112) id ADA741E11B; Mon, 10 Mar 2025 11:12:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-Spam-Level: X-Spam-Status: No, score=-3181.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 Received: from simark.localdomain (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 961241E08E; Mon, 10 Mar 2025 11:12:12 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 0/4] Modernize and fix leaks around internal_function Date: Mon, 10 Mar 2025 11:10:45 -0400 Message-ID: <20250310151211.2708331-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 10 Mar 2025 15:12:14 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org From: Simon Marchi This series fixes a small leak around internalvar_function, and does some mild C++-ification. When running: $ ./gdb -q -nx --data-directory=data-directory -batch I go from: SUMMARY: AddressSanitizer: 150845 byte(s) leaked in 1390 allocation(s). to: SUMMARY: AddressSanitizer: 149282 byte(s) leaked in 1340 allocation(s). Woohoo, almost there! Simon Marchi (4): gdb: C++-ify internal_function gdb: clear internalvar on destruction gdb: handle INTERNALVAR_FUNCTION in clear_internalvar gdb: change set_internalvar_function to take a unique pointer gdb/value.c | 54 ++++++++++++++++++++++++++++++++--------------------- 1 file changed, 33 insertions(+), 21 deletions(-) base-commit: 48691f6650bbae30d702faa2fddb666763ee4995