From patchwork Tue Dec 10 01:54:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Buettner X-Patchwork-Id: 57820 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8C8503858039 for ; Tue, 10 Dec 2024 02:05:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C8503858039 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GxPmk7AF X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8491C3858D33 for ; Tue, 10 Dec 2024 02:03:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8491C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8491C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733796217; cv=none; b=tCfh83VqEXcaLtfHTMeyzMxV9876Ih4+y9FSx3gaaOVPZucl67OOg6fA4vD+BNI6tX8IObMEQilFaAkBKysCtiWJCfqYiSYnWGU13c4r+Pg4fbqVSlpsdTkdqQKtDyY2skjHQ4uMhJHoHNV/auOieOUGZQxt1LV3ekiVkFWFcdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733796217; c=relaxed/simple; bh=4JRLReK4vmPndchKQW9Fux0wOoi8NYR9IEAiCPbfUkk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uX8zLja+gyVM5YlQECnv2KxLXZcbrZXDrp+Bv0H+ibgynyVj3erirKRvlYmjmYrJnfVReLSNrvU6C+ZlZNJnyfvp1IZbgrLVTWRLlK1eCJgQQ5wK9jm1BlnSTdw+u+pjHcayleYPgUMO+LZVQ7IYGYzk985GhzCLonjTJeixPII= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8491C3858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733796217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Wc3cEkdpa9VQl+XxKM1jaTCgcSegHk6a/l6+XBfnXs8=; b=GxPmk7AFuUJtwvBzFpNUu2/PcGDdp8Vxa1gkfjF+yNvzEXLKy+J6GvzyHjYAQ5wNNSUMcc tj4e5aafdBGXWCm6siTIS/qAR2NA9vAeJfXpIy6sV6wT/jLZpM9t+nbhdsm7SiV+wunokh XBLPhxWrmuwWDtr3cv891wUwzO5pgyg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-x1yhBCQwNByRbVf6OCFUlQ-1; Mon, 09 Dec 2024 21:03:36 -0500 X-MC-Unique: x1yhBCQwNByRbVf6OCFUlQ-1 X-Mimecast-MFC-AGG-ID: x1yhBCQwNByRbVf6OCFUlQ Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 085B91956058; Tue, 10 Dec 2024 02:03:35 +0000 (UTC) Received: from f41-1.lan (unknown [10.22.80.92]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E2ED21956089; Tue, 10 Dec 2024 02:03:33 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Cc: pedro@palves.net, Kevin Buettner Subject: [PATCH v5 0/4] Make linux checkpoints work with multiple inferiors Date: Mon, 9 Dec 2024 18:54:03 -0700 Message-ID: <20241210020313.584564-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: niW2FcnetYkIXAZDtAev9-T3ulPMGYPKbG_YlhcS2W4_1733796215 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org This series fixes some problems with the current checkpoint code. The first patch makes the checkpoint code inferior aware, fixing a number of bugs. The second and third patches are largely cosmetic - they make changes to checkpoint related output. The fourth patch updates the documentation. The v2 series incorporated Pedro's suggestions regarding the numbering of checkpoint ids. See the first patch for details. The tests have been revised to account for these changes and new tests have been added as well. The v3 series split out a cosmetic change from the first patch. It capitalized the output of a successful checkpoint command. This was prompted by the Linaro regression tester, which, due to the capitalization change, found two regressions in gdb.base/kill-during-detach.exp. (I had made a mistake during my own testing causing this to not be caught.) The v4 series addressed Pedro's concerns from his review of the v3 series. It also adds a NEWS entry and updates the GDB manual with regard to checkpoint identifiers. This v5 series makes several changes to the output for the "info checkpoints" command. As a consequence, both checkpoint related tests as well as the documentation were adjusted for these changes. Kevin Buettner (4): Make linux checkpoints work with multiple inferiors Capitalize output of successful checkpoint command Print only process ptids from linux-fork.c Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple inferiors gdb/NEWS | 2 + gdb/doc/gdb.texinfo | 20 +- gdb/linux-fork.c | 590 +++++++++---- gdb/linux-fork.h | 15 +- gdb/linux-nat.c | 18 +- gdb/testsuite/gdb.base/checkpoint.exp | 26 +- gdb/testsuite/gdb.base/kill-during-detach.exp | 2 +- gdb/testsuite/gdb.multi/checkpoint-multi.exp | 800 ++++++++++++++++++ 8 files changed, 1277 insertions(+), 196 deletions(-) create mode 100644 gdb/testsuite/gdb.multi/checkpoint-multi.exp Reviewed-By: Tom Tromey