mbox series

[v5,0/4] Make linux checkpoints work with multiple inferiors

Message ID 20241210020313.584564-1-kevinb@redhat.com
Headers
Series Make linux checkpoints work with multiple inferiors |

Message

Kevin Buettner Dec. 10, 2024, 1:54 a.m. UTC 
  This series fixes some problems with the current checkpoint code.  The
first patch makes the checkpoint code inferior aware, fixing a number
of bugs.  The second and third patches are largely cosmetic - they
make changes to checkpoint related output.  The fourth patch updates
the documentation.

The v2 series incorporated Pedro's suggestions regarding the
numbering of checkpoint ids.  See the first patch for details.  The
tests have been revised to account for these changes and new tests
have been added as well.

The v3 series split out a cosmetic change from the first patch.  It
capitalized the output of a successful checkpoint command.  This was
prompted by the Linaro regression tester, which, due to the
capitalization change, found two regressions in
gdb.base/kill-during-detach.exp.  (I had made a mistake during my own
testing causing this to not be caught.)

The v4 series addressed Pedro's concerns from his review of the v3
series.  It also adds a NEWS entry and updates the GDB manual with
regard to checkpoint identifiers.

This v5 series makes several changes to the output for the
"info checkpoints" command.  As a consequence, both checkpoint related
tests as well as the documentation were adjusted for these changes.

Kevin Buettner (4):
  Make linux checkpoints work with multiple inferiors
  Capitalize output of successful checkpoint command
  Print only process ptids from linux-fork.c
  Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple
    inferiors

 gdb/NEWS                                      |   2 +
 gdb/doc/gdb.texinfo                           |  20 +-
 gdb/linux-fork.c                              | 590 +++++++++----
 gdb/linux-fork.h                              |  15 +-
 gdb/linux-nat.c                               |  18 +-
 gdb/testsuite/gdb.base/checkpoint.exp         |  26 +-
 gdb/testsuite/gdb.base/kill-during-detach.exp |   2 +-
 gdb/testsuite/gdb.multi/checkpoint-multi.exp  | 800 ++++++++++++++++++
 8 files changed, 1277 insertions(+), 196 deletions(-)
 create mode 100644 gdb/testsuite/gdb.multi/checkpoint-multi.exp

Comments

Tom Tromey Dec. 19, 2024, 7:32 p.m. UTC | #1 
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

Kevin> This v5 series makes several changes to the output for the
Kevin> "info checkpoints" command.  As a consequence, both checkpoint related
Kevin> tests as well as the documentation were adjusted for these changes.

I read through this series and it looks good to me.
Thank you for doing this.

Reviewed-By: Tom Tromey <tom@tromey.com>

Tom
Andrew Burgess Jan. 30, 2025, 5:46 p.m. UTC | #2 
Kevin Buettner <kevinb@redhat.com> writes:

> This series fixes some problems with the current checkpoint code.  The
> first patch makes the checkpoint code inferior aware, fixing a number
> of bugs.  The second and third patches are largely cosmetic - they
> make changes to checkpoint related output.  The fourth patch updates
> the documentation.

I had some specific comments for patch #1.  But I've looked through all
the patches in this series, and they look good.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


>
> The v2 series incorporated Pedro's suggestions regarding the
> numbering of checkpoint ids.  See the first patch for details.  The
> tests have been revised to account for these changes and new tests
> have been added as well.
>
> The v3 series split out a cosmetic change from the first patch.  It
> capitalized the output of a successful checkpoint command.  This was
> prompted by the Linaro regression tester, which, due to the
> capitalization change, found two regressions in
> gdb.base/kill-during-detach.exp.  (I had made a mistake during my own
> testing causing this to not be caught.)
>
> The v4 series addressed Pedro's concerns from his review of the v3
> series.  It also adds a NEWS entry and updates the GDB manual with
> regard to checkpoint identifiers.
>
> This v5 series makes several changes to the output for the
> "info checkpoints" command.  As a consequence, both checkpoint related
> tests as well as the documentation were adjusted for these changes.
>
> Kevin Buettner (4):
>   Make linux checkpoints work with multiple inferiors
>   Capitalize output of successful checkpoint command
>   Print only process ptids from linux-fork.c
>   Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple
>     inferiors
>
>  gdb/NEWS                                      |   2 +
>  gdb/doc/gdb.texinfo                           |  20 +-
>  gdb/linux-fork.c                              | 590 +++++++++----
>  gdb/linux-fork.h                              |  15 +-
>  gdb/linux-nat.c                               |  18 +-
>  gdb/testsuite/gdb.base/checkpoint.exp         |  26 +-
>  gdb/testsuite/gdb.base/kill-during-detach.exp |   2 +-
>  gdb/testsuite/gdb.multi/checkpoint-multi.exp  | 800 ++++++++++++++++++
>  8 files changed, 1277 insertions(+), 196 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.multi/checkpoint-multi.exp
>
> -- 
> 2.46.2