mbox series

[v9,00/10] GDB support for DW_AT_trampoline

Message ID 20241124220353.3465-1-abdul.b.ijaz@intel.com
Headers
Series GDB support for DW_AT_trampoline |

Message

Abdul Basit Ijaz Nov. 24, 2024, 10:03 p.m. UTC 
  Hi All,

please find attached a series of patches that attempts to enable GDB to handle the DW_AT_trampoline attribute on functions and inlined functions.

DW_AT_trampoline can be emitted by the compiler for functions that are compiler generated trampolines (e.g. wrapping other function calls).
In doing so, the compiler can specify a target as the value of DW_AT_trampoline which the trampoline is wrapping.

This series enables GDB to recognize the DW_AT_trampoline and store the target for a given function.  Patch 3 adapts GDB's stepping behavior when dealing with trampolines and attempts to - by default - hide these trampolines from the user.  When about to step into a trampoline, instead, GDB will try and step through the trampoline and directly towards the target.  For rest of the patches as the name of the patch indicates it implements skipping of trampolines for the command mentioned in the patch name.

A new setting has also been introduced in this change to turn off this modified stepping behavior or printing of stack for trampolines.

The motivation for these patches comes from ifx which emits the attribute for some of its compiler generated functions.  As I do not know of any other compiler (especially gcc/gfortran) emitting DW_AT_trampoline, I added a gdb.dwarf2 test to this series in order to test the trampoline handling within GDB.

No changes in the approved documentation since V8 patch:
https://sourceware.org/pipermail/gdb-patches/2024-May/209395.html
https://sourceware.org/pipermail/gdb-patches/2024-May/209396.html

Changes since V8:
  * Update in 2nd patch only to handle a case if JIT compiler may have
    generated a duplicated symbol.

No regression seen on testing x64/(-m32)/x32 configurations.

Thanks & Best Regards
Abdul Basit Ijaz

Ijaz, Abdul B (7):
  gdb: Skip trampoline frames for the backtrace command.
  gdb: Skip trampoline functions for the finish and reverse-finish
    commands.
  gdb: Skip trampoline functions for the up command.
  gdb: Skip trampoline functions for the return command.
  gdb, mi: Skip trampoline functions for the -stack-list-frames command.
  gdb, mi: Skip trampoline functions for the -stack-list-arguments
    command.
  gdb: Filter trampoline frames in backtrace when using Python
    frame-filters.

Nils-Christian Kempke (3):
  gdb, dwarf: add support for DW_AT_trampoline in DWARF reader
  gdb/symtab: add lookup for trampoline functions
  gdb: handle stepping through functions with DW_AT_trampoline

 gdb/NEWS                                      |  13 +
 gdb/doc/gdb.texinfo                           |  52 +++-
 gdb/dwarf2/read.c                             |  39 ++-
 gdb/gdbtypes.c                                |  34 ++-
 gdb/gdbtypes.h                                | 113 +++++++-
 gdb/infcmd.c                                  |  12 +
 gdb/infrun.c                                  |  95 ++++++-
 gdb/infrun.h                                  |  16 ++
 gdb/mi/mi-cmd-stack.c                         |  14 +
 gdb/python/py-frame.c                         |  11 +
 gdb/stack.c                                   |  26 ++
 gdb/symtab.c                                  |  89 +++++++
 gdb/symtab.h                                  |  19 ++
 .../gdb.dwarf2/dw2-function-trampolines.c     |  80 ++++++
 .../gdb.dwarf2/dw2-function-trampolines.exp   | 245 ++++++++++++++++++
 gdb/testsuite/gdb.fortran/func-trampoline.exp | 102 ++++++++
 gdb/testsuite/gdb.fortran/func-trampoline.f90 |  39 +++
 .../gdb.fortran/mixed-lang-stack.exp          |  10 +-
 gdb/testsuite/gdb.mi/mi-func-trampoline.exp   |  75 ++++++
 .../gdb.python/py-framefilter-trampoline.exp  |  77 ++++++
 .../gdb.python/py-framefilter-trampoline.py   |  31 +++
 .../gdb.reverse/finish-reverse-trampoline.exp |  56 ++++
 22 files changed, 1233 insertions(+), 15 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-function-trampolines.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-function-trampolines.exp
 create mode 100644 gdb/testsuite/gdb.fortran/func-trampoline.exp
 create mode 100644 gdb/testsuite/gdb.fortran/func-trampoline.f90
 create mode 100644 gdb/testsuite/gdb.mi/mi-func-trampoline.exp
 create mode 100644 gdb/testsuite/gdb.python/py-framefilter-trampoline.exp
 create mode 100644 gdb/testsuite/gdb.python/py-framefilter-trampoline.py
 create mode 100644 gdb/testsuite/gdb.reverse/finish-reverse-trampoline.exp