[v6,0/2] Add amd64 LAM watchpoint support

  Hi all,

this is my v6 of the series "Add amd64 LAM watchpoint support".
I just rebased it on latest master since the posting of v5 has been a
while and there were some conflicts in gdb/aarch64-tdep.c and
loongarch-linux-nat.c.

Besides that only the review for patch 1 is open, patch 2 has already
been approved by Felix and Eli for the docs parts.

v5 of this series can be found here:
https://sourceware.org/pipermail/gdb-patches/2024-July/210414.html

Best Regards
Christina

Christina Schimpe (2):
  gdb: Make tagged pointer support configurable.
  LAM: Enable tagged pointer support for watchpoints.

 gdb/NEWS                             |  5 +++
 gdb/aarch64-linux-nat.c              |  2 +-
 gdb/aarch64-linux-tdep.c             |  7 +--
 gdb/aarch64-tdep.c                   | 23 ++++++----
 gdb/aarch64-tdep.h                   |  6 +++
 gdb/amd64-linux-tdep.c               | 64 +++++++++++++++++++++++++++
 gdb/breakpoint.c                     |  5 ++-
 gdb/gdbarch-gen.c                    | 66 +++++++++++++++++++++++-----
 gdb/gdbarch-gen.h                    | 49 ++++++++++++++++-----
 gdb/gdbarch_components.py            | 53 ++++++++++++++++++----
 gdb/loongarch-linux-nat.c            |  2 +-
 gdb/target.c                         |  3 +-
 gdb/testsuite/gdb.arch/amd64-lam.c   | 49 +++++++++++++++++++++
 gdb/testsuite/gdb.arch/amd64-lam.exp | 46 +++++++++++++++++++
 gdb/testsuite/lib/gdb.exp            | 63 ++++++++++++++++++++++++++
 15 files changed, 396 insertions(+), 47 deletions(-)
 create mode 100755 gdb/testsuite/gdb.arch/amd64-lam.c
 create mode 100644 gdb/testsuite/gdb.arch/amd64-lam.exp
  

Hi Luis, 

Is it possible that you would have a look at the remaining non-architecture specific parts of patch 1?
Note: There were also some conflicts for the aarch64* parts of patch 1 during the latest rebase. So that could would need a re-review as well, I think.

Best Regards + thank you very much in advance,
Christina

> -----Original Message-----
> From: Schimpe, Christina <christina.schimpe@intel.com>
> Sent: Monday, October 28, 2024 9:46 AM
> To: gdb-patches@sourceware.org
> Subject: [PATCH v6 0/2] Add amd64 LAM watchpoint support
> 
> Hi all,
> 
> this is my v6 of the series "Add amd64 LAM watchpoint support".
> I just rebased it on latest master since the posting of v5 has been a while and
> there were some conflicts in gdb/aarch64-tdep.c and loongarch-linux-nat.c.
> 
> Besides that only the review for patch 1 is open, patch 2 has already been
> approved by Felix and Eli for the docs parts.
> 
> v5 of this series can be found here:
> https://sourceware.org/pipermail/gdb-patches/2024-July/210414.html
> 
> Best Regards
> Christina
> 
> Christina Schimpe (2):
>   gdb: Make tagged pointer support configurable.
>   LAM: Enable tagged pointer support for watchpoints.
> 
>  gdb/NEWS                             |  5 +++
>  gdb/aarch64-linux-nat.c              |  2 +-
>  gdb/aarch64-linux-tdep.c             |  7 +--
>  gdb/aarch64-tdep.c                   | 23 ++++++----
>  gdb/aarch64-tdep.h                   |  6 +++
>  gdb/amd64-linux-tdep.c               | 64 +++++++++++++++++++++++++++
>  gdb/breakpoint.c                     |  5 ++-
>  gdb/gdbarch-gen.c                    | 66 +++++++++++++++++++++++-----
>  gdb/gdbarch-gen.h                    | 49 ++++++++++++++++-----
>  gdb/gdbarch_components.py            | 53 ++++++++++++++++++----
>  gdb/loongarch-linux-nat.c            |  2 +-
>  gdb/target.c                         |  3 +-
>  gdb/testsuite/gdb.arch/amd64-lam.c   | 49 +++++++++++++++++++++
>  gdb/testsuite/gdb.arch/amd64-lam.exp | 46 +++++++++++++++++++
>  gdb/testsuite/lib/gdb.exp            | 63 ++++++++++++++++++++++++++
>  15 files changed, 396 insertions(+), 47 deletions(-)  create mode 100755
> gdb/testsuite/gdb.arch/amd64-lam.c
>  create mode 100644 gdb/testsuite/gdb.arch/amd64-lam.exp
> 
> --
> 2.34.1
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928