mbox series

[0/3] More use of ui-out tables

Message ID 20241011-even-more-ui-out-v1-0-e1f92f01bacb@tromey.com
Headers
Series More use of ui-out tables |

Message

Tom Tromey Oct. 11, 2024, 11:24 p.m. UTC 
  This series fixes a couple more spots to use ui-out tables.
It also fixes another buglet I found while working on those.

Regression tested on x86-64 Fedora 40

---
Tom Tromey (3):
      Use ui-out tables in some "maint print" commands
      Use ui-out table in "maint print reggroups"
      Fix "maint print" error messages

 gdb/regcache-dump.c                             | 228 ++++++++++++++----------
 gdb/regcache.c                                  | 132 ++++++--------
 gdb/regcache.h                                  |  11 +-
 gdb/reggroups.c                                 |  22 ++-
 gdb/testsuite/gdb.base/completion.exp           |   2 +-
 gdb/testsuite/gdb.base/maint.exp                |   4 +-
 gdb/testsuite/gdb.base/reggroups.exp            |   4 +-
 gdb/testsuite/gdb.python/py-arch-reg-groups.exp |   6 +-
 gdb/testsuite/gdb.server/server-run.exp         |   2 +-
 gdb/testsuite/gdb.xml/tdesc-regs.exp            |   2 +-
 10 files changed, 222 insertions(+), 191 deletions(-)
---
base-commit: 5bc1b13676bc5eeefc50d25379991f5f9255eb80
change-id: 20241011-even-more-ui-out-ed4e79a223a3

Best regards,

Comments

Andrew Burgess Oct. 21, 2024, 5:05 p.m. UTC | #1 
Tom Tromey <tom@tromey.com> writes:

> This series fixes a couple more spots to use ui-out tables.
> It also fixes another buglet I found while working on those.
>
> Regression tested on x86-64 Fedora 40

I took a look through this series.  It might be nice to start the
function comment on patch #3, even if you just document your new
argument.

Put either way:

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


>
> ---
> Tom Tromey (3):
>       Use ui-out tables in some "maint print" commands
>       Use ui-out table in "maint print reggroups"
>       Fix "maint print" error messages
>
>  gdb/regcache-dump.c                             | 228 ++++++++++++++----------
>  gdb/regcache.c                                  | 132 ++++++--------
>  gdb/regcache.h                                  |  11 +-
>  gdb/reggroups.c                                 |  22 ++-
>  gdb/testsuite/gdb.base/completion.exp           |   2 +-
>  gdb/testsuite/gdb.base/maint.exp                |   4 +-
>  gdb/testsuite/gdb.base/reggroups.exp            |   4 +-
>  gdb/testsuite/gdb.python/py-arch-reg-groups.exp |   6 +-
>  gdb/testsuite/gdb.server/server-run.exp         |   2 +-
>  gdb/testsuite/gdb.xml/tdesc-regs.exp            |   2 +-
>  10 files changed, 222 insertions(+), 191 deletions(-)
> ---
> base-commit: 5bc1b13676bc5eeefc50d25379991f5f9255eb80
> change-id: 20241011-even-more-ui-out-ed4e79a223a3
>
> Best regards,
> -- 
> Tom Tromey <tom@tromey.com>
Tom Tromey Dec. 4, 2024, 1:41 a.m. UTC | #2 
>>>>> Andrew Burgess <aburgess@redhat.com> writes:

> I took a look through this series.  It might be nice to start the
> function comment on patch #3, even if you just document your new
> argument.

I did this.

> Put either way:
> Approved-By: Andrew Burgess <aburgess@redhat.com>

I'm going to check it in shortly.

Tom