mbox series

[0/3] Add more styling to some "maint" output

Message ID 20240927-dwarf-incl-stuff-v1-0-cb925fa76af3@tromey.com
Headers
Series Add more styling to some "maint" output |

Message

Tom Tromey Sept. 27, 2024, 7:50 p.m. UTC 
  This series adds some styling to "maint" output, and also includes a
small patch to add a bit more information to cooked_index::dump.

---
Tom Tromey (3):
      Add styling to symmisc.c
      Add styling to cooked_index::dump
      Print the CU index in cooked_index::dump

 gdb/dwarf2/cooked-index.c | 18 +++++++++--
 gdb/symmisc.c             | 81 +++++++++++++++++++++++++++++++----------------
 2 files changed, 68 insertions(+), 31 deletions(-)
---
base-commit: 802c2244afaa65d20a18c10d2d3e1823b466f357
change-id: 20240927-dwarf-incl-stuff-bc31738210cd

Best regards,

Comments

Gerlicher, Klaus Sept. 28, 2024, 8:47 a.m. UTC | #1 
Hi Tom,

Just curious, I see _() used inconsistently all over the place in gdb_printf(). Since you are working on
amending some of this gdb_printf lines, would it make sense to add the _()?

Thanks
Klaus

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Friday, September 27, 2024 9:51 PM
> To: gdb-patches@sourceware.org
> Subject: [PATCH 0/3] Add more styling to some "maint" output
> 
> This series adds some styling to "maint" output, and also includes a
> small patch to add a bit more information to cooked_index::dump.
> 
> ---
> Tom Tromey (3):
>       Add styling to symmisc.c
>       Add styling to cooked_index::dump
>       Print the CU index in cooked_index::dump
> 
>  gdb/dwarf2/cooked-index.c | 18 +++++++++--
>  gdb/symmisc.c             | 81 +++++++++++++++++++++++++++++++------------
> ----
>  2 files changed, 68 insertions(+), 31 deletions(-)
> ---
> base-commit: 802c2244afaa65d20a18c10d2d3e1823b466f357
> change-id: 20240927-dwarf-incl-stuff-bc31738210cd
> 
> Best regards,
> --
> Tom Tromey <tom@tromey.com>
> 

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928