mbox series

[0/7] Some more passing down program space

Message ID 20240717035307.2299961-1-simon.marchi@polymtl.ca
Headers
Series Some more passing down program space |

Message

Simon Marchi July 17, 2024, 3:51 a.m. UTC 
  Here's another batch of patches I had laying around.

Simon Marchi (7):
  gdb: drop struct keyword when using bound_minimal_symbol
  gdb: make lookup_minimal_symbol objf and sfile parameters optional
  gdb: remove lookup_bound_minimal_symbol
  gdb: add program_space parameter to lookup_minimal_symbol
  gdb: add program_space parameter to get_symbol_leading_char
  gdb: add program_space parameter to lookup_minimal_symbol_linkage
  gdb: add program_space parameter to lookup_minimal_symbol_text

 gdb/ada-exp.y                       |  2 +-
 gdb/ada-lang.c                      | 19 ++++++----
 gdb/ada-lang.h                      |  3 +-
 gdb/ada-tasks.c                     | 12 +++---
 gdb/aix-thread.c                    |  8 ++--
 gdb/amd64-windows-tdep.c            |  3 +-
 gdb/arc-linux-tdep.c                |  4 +-
 gdb/arm-tdep.c                      | 18 ++++-----
 gdb/arm-wince-tdep.c                |  5 +--
 gdb/auxv.c                          |  4 +-
 gdb/avr-tdep.c                      |  4 +-
 gdb/ax-gdb.c                        |  6 +--
 gdb/block.c                         |  2 +-
 gdb/blockframe.c                    |  5 +--
 gdb/breakpoint.c                    | 33 ++++++++--------
 gdb/bsd-uthread.c                   |  5 +--
 gdb/btrace.c                        |  3 +-
 gdb/c-exp.y                         |  4 +-
 gdb/c-valprint.c                    |  3 +-
 gdb/coff-pe-read.c                  |  9 +++--
 gdb/coffread.c                      |  5 ++-
 gdb/compile/compile-c-symbols.c     | 13 +++----
 gdb/compile/compile-cplus-symbols.c |  7 ++--
 gdb/compile/compile-object-load.c   |  4 +-
 gdb/csky-tdep.c                     |  2 +-
 gdb/ctfread.c                       |  5 +--
 gdb/d-exp.y                         |  5 ++-
 gdb/d-lang.c                        |  5 +--
 gdb/dbxread.c                       | 33 ++++++++--------
 gdb/dwarf2/ada-imported.c           |  4 +-
 gdb/dwarf2/cooked-index.h           |  2 +-
 gdb/dwarf2/loc.c                    | 35 ++++++++---------
 gdb/dwarf2/read.c                   |  2 +-
 gdb/dwarf2/read.h                   |  2 +-
 gdb/elfread.c                       |  8 ++--
 gdb/eval.c                          |  3 +-
 gdb/fbsd-tdep.c                     |  6 ++-
 gdb/findvar.c                       |  4 +-
 gdb/frame.c                         |  2 +-
 gdb/frv-tdep.c                      |  7 ++--
 gdb/ft32-tdep.c                     |  5 ++-
 gdb/gcore.c                         |  5 ++-
 gdb/glibc-tdep.c                    | 14 ++++---
 gdb/gnu-v2-abi.c                    |  3 +-
 gdb/gnu-v3-abi.c                    | 11 +++---
 gdb/go-exp.y                        |  5 +--
 gdb/go-lang.c                       |  5 +--
 gdb/hppa-tdep.c                     |  5 +--
 gdb/i386-tdep.c                     |  3 +-
 gdb/ia64-tdep.c                     |  4 +-
 gdb/infcall.c                       |  2 +-
 gdb/infcmd.c                        |  2 +-
 gdb/jit.c                           |  2 +-
 gdb/linespec.c                      |  4 +-
 gdb/linux-fork.c                    | 15 ++++----
 gdb/linux-thread-db.c               |  9 ++---
 gdb/m32c-tdep.c                     | 22 +++++------
 gdb/m32r-tdep.c                     |  4 +-
 gdb/m68hc11-tdep.c                  |  9 ++---
 gdb/machoread.c                     |  5 ++-
 gdb/maint.c                         |  2 +-
 gdb/mi/mi-symbol-cmds.c             |  3 +-
 gdb/minsyms.c                       | 58 ++++++++++++++---------------
 gdb/minsyms.h                       | 36 +++++++++---------
 gdb/mips-fbsd-tdep.c                |  4 +-
 gdb/mips-linux-tdep.c               |  5 +--
 gdb/mips-tdep.c                     | 30 ++++++---------
 gdb/msp430-tdep.c                   |  3 +-
 gdb/netbsd-tdep.c                   |  5 +--
 gdb/objc-lang.c                     | 34 ++++++++++-------
 gdb/objfiles.h                      |  9 ++---
 gdb/obsd-tdep.c                     |  5 +--
 gdb/p-exp.y                         |  5 +--
 gdb/p-lang.c                        | 11 +++---
 gdb/p-valprint.c                    |  4 +-
 gdb/parse.c                         |  7 ++--
 gdb/ppc-linux-tdep.c                |  7 +---
 gdb/ppc-sysv-tdep.c                 | 10 ++---
 gdb/printcmd.c                      | 14 +++----
 gdb/proc-service.c                  |  3 +-
 gdb/psymtab.c                       | 17 ++++-----
 gdb/psymtab.h                       | 13 +++----
 gdb/python/py-framefilter.c         |  4 +-
 gdb/quick-symbol.h                  |  4 +-
 gdb/ravenscar-thread.c              | 30 +++++++--------
 gdb/remote.c                        |  5 +--
 gdb/rs6000-tdep.c                   |  5 +--
 gdb/sol-thread.c                    |  9 ++---
 gdb/sol2-tdep.c                     |  5 +--
 gdb/solib-dsbt.c                    |  6 +--
 gdb/solib-frv.c                     | 12 +++---
 gdb/solib-svr4.c                    | 13 ++++---
 gdb/stack.c                         |  7 +---
 gdb/symfile-debug.c                 |  2 +-
 gdb/symfile.c                       | 12 +++---
 gdb/symtab.c                        | 29 ++++++++-------
 gdb/symtab.h                        |  2 +-
 gdb/tracepoint.c                    | 26 +++++++------
 gdb/tui/tui-disasm.c                | 14 +++----
 gdb/valops.c                        |  4 +-
 gdb/value.c                         |  8 ++--
 gdb/x86-tdep.c                      |  2 +-
 gdb/z80-tdep.c                      | 20 +++++-----
 103 files changed, 454 insertions(+), 490 deletions(-)


base-commit: d898e0855b34c00b6b31248f613d09ff080c272f

Comments

Keith Seitz Aug. 6, 2024, 8:06 p.m. UTC | #1 
On 7/16/24 8:51 PM, Simon Marchi wrote:
> Here's another batch of patches I had laying around.

I've looked through this series, and done some test builds,
and other than one comment on #5, this looks like a solid
step in the right direction.

Reviewed-by: Keith Seitz <keiths@redhat.com>

Keith
Andrew Burgess Aug. 8, 2024, 5:34 p.m. UTC | #2 
Simon Marchi <simon.marchi@polymtl.ca> writes:

> Here's another batch of patches I had laying around.
>
> Simon Marchi (7):
>   gdb: drop struct keyword when using bound_minimal_symbol
>   gdb: make lookup_minimal_symbol objf and sfile parameters optional
>   gdb: remove lookup_bound_minimal_symbol
>   gdb: add program_space parameter to lookup_minimal_symbol
>   gdb: add program_space parameter to get_symbol_leading_char
>   gdb: add program_space parameter to lookup_minimal_symbol_linkage
>   gdb: add program_space parameter to lookup_minimal_symbol_text

OK, so I've not gone through every line of these patches.  But these all
look like great clean up work.  Assuming everything still builds then I
say, lets check this lot in:

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew



>
>  gdb/ada-exp.y                       |  2 +-
>  gdb/ada-lang.c                      | 19 ++++++----
>  gdb/ada-lang.h                      |  3 +-
>  gdb/ada-tasks.c                     | 12 +++---
>  gdb/aix-thread.c                    |  8 ++--
>  gdb/amd64-windows-tdep.c            |  3 +-
>  gdb/arc-linux-tdep.c                |  4 +-
>  gdb/arm-tdep.c                      | 18 ++++-----
>  gdb/arm-wince-tdep.c                |  5 +--
>  gdb/auxv.c                          |  4 +-
>  gdb/avr-tdep.c                      |  4 +-
>  gdb/ax-gdb.c                        |  6 +--
>  gdb/block.c                         |  2 +-
>  gdb/blockframe.c                    |  5 +--
>  gdb/breakpoint.c                    | 33 ++++++++--------
>  gdb/bsd-uthread.c                   |  5 +--
>  gdb/btrace.c                        |  3 +-
>  gdb/c-exp.y                         |  4 +-
>  gdb/c-valprint.c                    |  3 +-
>  gdb/coff-pe-read.c                  |  9 +++--
>  gdb/coffread.c                      |  5 ++-
>  gdb/compile/compile-c-symbols.c     | 13 +++----
>  gdb/compile/compile-cplus-symbols.c |  7 ++--
>  gdb/compile/compile-object-load.c   |  4 +-
>  gdb/csky-tdep.c                     |  2 +-
>  gdb/ctfread.c                       |  5 +--
>  gdb/d-exp.y                         |  5 ++-
>  gdb/d-lang.c                        |  5 +--
>  gdb/dbxread.c                       | 33 ++++++++--------
>  gdb/dwarf2/ada-imported.c           |  4 +-
>  gdb/dwarf2/cooked-index.h           |  2 +-
>  gdb/dwarf2/loc.c                    | 35 ++++++++---------
>  gdb/dwarf2/read.c                   |  2 +-
>  gdb/dwarf2/read.h                   |  2 +-
>  gdb/elfread.c                       |  8 ++--
>  gdb/eval.c                          |  3 +-
>  gdb/fbsd-tdep.c                     |  6 ++-
>  gdb/findvar.c                       |  4 +-
>  gdb/frame.c                         |  2 +-
>  gdb/frv-tdep.c                      |  7 ++--
>  gdb/ft32-tdep.c                     |  5 ++-
>  gdb/gcore.c                         |  5 ++-
>  gdb/glibc-tdep.c                    | 14 ++++---
>  gdb/gnu-v2-abi.c                    |  3 +-
>  gdb/gnu-v3-abi.c                    | 11 +++---
>  gdb/go-exp.y                        |  5 +--
>  gdb/go-lang.c                       |  5 +--
>  gdb/hppa-tdep.c                     |  5 +--
>  gdb/i386-tdep.c                     |  3 +-
>  gdb/ia64-tdep.c                     |  4 +-
>  gdb/infcall.c                       |  2 +-
>  gdb/infcmd.c                        |  2 +-
>  gdb/jit.c                           |  2 +-
>  gdb/linespec.c                      |  4 +-
>  gdb/linux-fork.c                    | 15 ++++----
>  gdb/linux-thread-db.c               |  9 ++---
>  gdb/m32c-tdep.c                     | 22 +++++------
>  gdb/m32r-tdep.c                     |  4 +-
>  gdb/m68hc11-tdep.c                  |  9 ++---
>  gdb/machoread.c                     |  5 ++-
>  gdb/maint.c                         |  2 +-
>  gdb/mi/mi-symbol-cmds.c             |  3 +-
>  gdb/minsyms.c                       | 58 ++++++++++++++---------------
>  gdb/minsyms.h                       | 36 +++++++++---------
>  gdb/mips-fbsd-tdep.c                |  4 +-
>  gdb/mips-linux-tdep.c               |  5 +--
>  gdb/mips-tdep.c                     | 30 ++++++---------
>  gdb/msp430-tdep.c                   |  3 +-
>  gdb/netbsd-tdep.c                   |  5 +--
>  gdb/objc-lang.c                     | 34 ++++++++++-------
>  gdb/objfiles.h                      |  9 ++---
>  gdb/obsd-tdep.c                     |  5 +--
>  gdb/p-exp.y                         |  5 +--
>  gdb/p-lang.c                        | 11 +++---
>  gdb/p-valprint.c                    |  4 +-
>  gdb/parse.c                         |  7 ++--
>  gdb/ppc-linux-tdep.c                |  7 +---
>  gdb/ppc-sysv-tdep.c                 | 10 ++---
>  gdb/printcmd.c                      | 14 +++----
>  gdb/proc-service.c                  |  3 +-
>  gdb/psymtab.c                       | 17 ++++-----
>  gdb/psymtab.h                       | 13 +++----
>  gdb/python/py-framefilter.c         |  4 +-
>  gdb/quick-symbol.h                  |  4 +-
>  gdb/ravenscar-thread.c              | 30 +++++++--------
>  gdb/remote.c                        |  5 +--
>  gdb/rs6000-tdep.c                   |  5 +--
>  gdb/sol-thread.c                    |  9 ++---
>  gdb/sol2-tdep.c                     |  5 +--
>  gdb/solib-dsbt.c                    |  6 +--
>  gdb/solib-frv.c                     | 12 +++---
>  gdb/solib-svr4.c                    | 13 ++++---
>  gdb/stack.c                         |  7 +---
>  gdb/symfile-debug.c                 |  2 +-
>  gdb/symfile.c                       | 12 +++---
>  gdb/symtab.c                        | 29 ++++++++-------
>  gdb/symtab.h                        |  2 +-
>  gdb/tracepoint.c                    | 26 +++++++------
>  gdb/tui/tui-disasm.c                | 14 +++----
>  gdb/valops.c                        |  4 +-
>  gdb/value.c                         |  8 ++--
>  gdb/x86-tdep.c                      |  2 +-
>  gdb/z80-tdep.c                      | 20 +++++-----
>  103 files changed, 454 insertions(+), 490 deletions(-)
>
>
> base-commit: d898e0855b34c00b6b31248f613d09ff080c272f
> -- 
> 2.45.2
Simon Marchi Aug. 12, 2024, 2:34 p.m. UTC | #3 
On 8/6/24 4:06 PM, Keith Seitz wrote:
> On 7/16/24 8:51 PM, Simon Marchi wrote:
>> Here's another batch of patches I had laying around.
> 
> I've looked through this series, and done some test builds,
> and other than one comment on #5, this looks like a solid
> step in the right direction.
> 
> Reviewed-by: Keith Seitz <keiths@redhat.com>
> 
> Keith
> 

Thanks a lot for reviewing!

Simon
Simon Marchi Aug. 12, 2024, 2:35 p.m. UTC | #4 
On 8/8/24 1:34 PM, Andrew Burgess wrote:
> Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
>> Here's another batch of patches I had laying around.
>>
>> Simon Marchi (7):
>>   gdb: drop struct keyword when using bound_minimal_symbol
>>   gdb: make lookup_minimal_symbol objf and sfile parameters optional
>>   gdb: remove lookup_bound_minimal_symbol
>>   gdb: add program_space parameter to lookup_minimal_symbol
>>   gdb: add program_space parameter to get_symbol_leading_char
>>   gdb: add program_space parameter to lookup_minimal_symbol_linkage
>>   gdb: add program_space parameter to lookup_minimal_symbol_text
> 
> OK, so I've not gone through every line of these patches.  But these all
> look like great clean up work.  Assuming everything still builds then I
> say, lets check this lot in:
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks, will push.

Simon