mbox series

[00/14] Some random program space cleanups

Message ID 20240711195307.1544451-1-simon.marchi@polymtl.ca
Headers
Series Some random program space cleanups |

Message

Simon Marchi July 11, 2024, 7:51 p.m. UTC 
  I am working on a feature that touches solibs and program spaces.  I
accumulated a bunch of random cleanups in my branch, here's a batch.

Simon Marchi (14):
  gdb: use objfile::pspace in objfile::unlink
  gdb: pass program space to objfile_purge_solibs
  gdb: split no_shared_libraries, command vs implementation
  gdb: pass program space to no_shared_libraries
  gdb: make `program_space::free_all_objfiles` use `this`
  gdb: pass program space to clear_current_source_symtab_and_line
  gdb: bool-ify a few functions in objfiles.{c,h}
  gdb: pass program space to have_{full,partial}_symbols
  gdb: pass program space to get_current_source_symtab_and_line
  gdb: pass program space to objfiles_changed
  gdb: pass program space to entry_point_address_query
  gdb: pass program space to entry_point_address
  gdb: pass program space to objfile::objfile
  gdb: pass program space to objfile::make

 gdb/ada-exp.y           |   4 +-
 gdb/arc-tdep.c          |   2 +-
 gdb/arch-utils.c        |   2 +-
 gdb/breakpoint.c        |   5 +-
 gdb/c-exp.y             |   3 +-
 gdb/cli/cli-cmds.c      |  19 +++---
 gdb/compile/compile.c   |   4 +-
 gdb/d-exp.y             |   3 +-
 gdb/frame.c             |   2 +-
 gdb/go-exp.y            |   4 +-
 gdb/infcall.c           |   2 +-
 gdb/infcmd.c            |  13 ++--
 gdb/infrun.c            |   2 +-
 gdb/jit.c               |   4 +-
 gdb/linespec.c          |  18 +++---
 gdb/macroscope.c        |   6 +-
 gdb/mi/mi-cmd-file.c    |   4 +-
 gdb/objfiles.c          | 131 ++++++++++++++++++----------------------
 gdb/objfiles.h          |  52 +++++++++++-----
 gdb/p-exp.y             |   4 +-
 gdb/parse.c             |   7 ++-
 gdb/progspace.c         |   4 +-
 gdb/python/python.c     |   2 +-
 gdb/remote.c            |   2 +-
 gdb/solib-frv.c         |   2 +-
 gdb/solib.c             |  24 +++++---
 gdb/solib.h             |   4 +-
 gdb/source.c            |  18 +++---
 gdb/source.h            |   7 ++-
 gdb/symfile.c           |  19 +++---
 gdb/symtab.c            |   8 ++-
 gdb/target.c            |   6 +-
 gdb/target.h            |   2 +-
 gdb/tui/tui-disasm.c    |   6 +-
 gdb/tui/tui-hooks.c     |   3 +-
 gdb/tui/tui-source.c    |   5 +-
 gdb/tui/tui-winsource.c |  10 +--
 37 files changed, 227 insertions(+), 186 deletions(-)


base-commit: a79094915578872a0360c78a54accff994b883b1

Comments

Simon Marchi July 15, 2024, 2:42 p.m. UTC | #1 
On 7/11/24 3:51 PM, Simon Marchi wrote:
> I am working on a feature that touches solibs and program spaces.  I
> accumulated a bunch of random cleanups in my branch, here's a batch.

I made some fixups following Thiago's comments, but since they are quite
minor I don't think it's worth posting a new version of the series.
If there are additional comments, please let me know, otherwise I'll
push this... eventually.

Simon
Tom Tromey July 15, 2024, 4:17 p.m. UTC | #2 
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> On 7/11/24 3:51 PM, Simon Marchi wrote:
>> I am working on a feature that touches solibs and program spaces.  I
>> accumulated a bunch of random cleanups in my branch, here's a batch.

Simon> I made some fixups following Thiago's comments, but since they are quite
Simon> minor I don't think it's worth posting a new version of the series.
Simon> If there are additional comments, please let me know, otherwise I'll
Simon> push this... eventually.

FWIW this all seems fine to me.  Thanks for doing this.

Approved-By: Tom Tromey <tom@tromey.com>

Tom
Simon Marchi July 15, 2024, 6:38 p.m. UTC | #3 
On 7/15/24 12:17 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> On 7/11/24 3:51 PM, Simon Marchi wrote:
>>> I am working on a feature that touches solibs and program spaces.  I
>>> accumulated a bunch of random cleanups in my branch, here's a batch.
> 
> Simon> I made some fixups following Thiago's comments, but since they are quite
> Simon> minor I don't think it's worth posting a new version of the series.
> Simon> If there are additional comments, please let me know, otherwise I'll
> Simon> push this... eventually.
> 
> FWIW this all seems fine to me.  Thanks for doing this.
> 
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed.

Simon