From patchwork Tue May 14 17:16:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ijaz, Abdul B" X-Patchwork-Id: 56977 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 774DD384AB4B for ; Tue, 14 May 2024 17:16:51 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by sourceware.org (Postfix) with ESMTPS id AB16E3858D35 for ; Tue, 14 May 2024 17:16:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB16E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB16E3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.14 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715706981; cv=none; b=lcLXHq/l7u66PEsDaJaN7TdzLVOGHIwcBCrBlj7zVzaOTiusA6bpMXJygGjsnNd80VKmLg4NSm3XzFUsMnboHNduVN1mKML1FMR15wATaIeipKf8rlD6xb54RrC7NnbLB27v0aWHEV4wTRpHFkW6HKV7kpl3mIhCmJBfJOZcKaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715706981; c=relaxed/simple; bh=VrdI8S626IyY/N+5F36m48foHdz5TBulO0YALKMmkpY=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=KXkGBLftl+ldeChQaaHp9/sjwtjCz6pXBdhHzofSGu0BZmY00jXpzvCfFd8CQAy2HUlUjuPaC8nvgHfp7RpcMNAbQoGjf6VLJC8T8sLZiqu3x4vkrWtkHSKreo7N66csy/y2FpA8rlS7Cdg7+ID7xU+tvSftYJmEy/gnBx4svzU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715706979; x=1747242979; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=VrdI8S626IyY/N+5F36m48foHdz5TBulO0YALKMmkpY=; b=RYy7TSwN0BYUuQ9/xopNMFaILCEuu6nXm6T6XuGO5qbKSP3KxehRU/44 mjPCx1Q8HEPlYQJLhWPNUWI9j/rS5Pe2yIEiodRtrjMMuX1i96CHnwfCM X/VTFgxX/UlcXZwv7n4H/5/nN/wtLudKsup9eoMyAf1XiFzVKXgt2SPVp UdT5yZ8YAtX1VbZDx3UNg3Yolapchl0gaW6x7dYdJLDlt4DuwKvJuJwgd dGmFoMCjNfT7thGnzHb7pVM2XyKkfJw/sypJsZHA1BXh53wpHGfZPLpPJ s23AxkkNKq7MRYSMxmBe9HYA4zRsAHJjciyl/cnN0G0jxaqAgiXvFshUl Q==; X-CSE-ConnectionGUID: jUX6zh9eTQa4qyMnH2XPnA== X-CSE-MsgGUID: HHZMlGM9T0yRjSlRZEAC8A== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="11922614" X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="11922614" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2024 10:16:15 -0700 X-CSE-ConnectionGUID: qQ9jxCp0R7ioNVilI0OqGQ== X-CSE-MsgGUID: 8Zvfthi7S9uxzGkmn5UKnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="30690719" Received: from abijaz-mobl2.ger.corp.intel.com (HELO localhost) ([10.246.42.1]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2024 10:16:13 -0700 From: Abdul Basit Ijaz To: gdb-patches@sourceware.org Cc: abdul.b.ijaz@intel.com, christina.schimpe@intel.com, felix.willgerodt@intel.com, keiths@redhat.com Subject: [PATCH v2 0/1] gdb, testsuite: Handle unused compiler option fdiagnostics-color=never. Date: Tue, 14 May 2024 19:16:02 +0200 Message-Id: <20240514171603.18486-1-abdul.b.ijaz@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org From: "Ijaz, Abdul B" Hi All, This patch updates the handling of '-fdiagnostics-color=never' in the function 'univeral_compile_options' of gdb.exp file. Before this change it only verifies the support of '-fdiagnostics-color=never' for the "C" source file. So while running tests with assembly source file (.s), many of them are not able to run on icx/clang compilers because '-fdiagnostics-color=never' option is not supported. After this change, this function is split into multiple functions to check the support for different type of sources individually. Changes since V1: * Fix the feedback on V1 patch i.e remove sign off line in commit message and remove the changes not needed for the fix. * Use generic source file for checking the compile option support in .s assembly file. V1 patch: https://sourceware.org/pipermail/gdb-patches/2024-March/207477.html Thanks & Best Regards Abdul Basit Ijaz, Abdul B (1): gdb, testsuite: Handle unused compiler option fdiagnostics-color=never. gdb/testsuite/lib/gdb.exp | 52 +++++++++++++++++++++++++++++++-------- 1 file changed, 42 insertions(+), 10 deletions(-)