From patchwork Sun Mar 3 18:43:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 56751 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B348D385840F for ; Sun, 3 Mar 2024 18:43:58 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 246A43858C60 for ; Sun, 3 Mar 2024 18:43:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 246A43858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 246A43858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709491388; cv=none; b=kU8nlkTr+01ZomnDfKVIn0V1j9smURw6VxOkP0cHUUd6vzxFac/ekTErTUdyRhJPasTlHcHsJnSQFJQQ0u5KnPSYwjoVNBfOrznX1Tx5ma5r/se2iM+gVxJb+4A3x3kwAP3M/AurtlyDvjMn7rfU3zcQEt91Qw3AsXXt3f2WvhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709491388; c=relaxed/simple; bh=YStuzyGwEGhnSfDuLzGphmfdeALNGtqZKv7dWIbps6A=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=DMSDz8axvRvQygjH+1qj3WbzlYwnrmBEss1Wnq4Wx3wtnxIQxgntsm0P8d9wEVWlIfQh0fFSg7SuUQ7lgF/qFEWCw8ArqsmxpfSZogkWq5Smo8ez+7amiK3TeYFK+uYS3z9zeWu4DHG+cbqgKAAcjfUGocapI1aHq2PLqVxYR4k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id gnq0rC0m7tf2Qgqnhr4jv5; Sun, 03 Mar 2024 18:43:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id gqngreDNDZDIAgqnhr1FJL; Sun, 03 Mar 2024 18:43:05 +0000 X-Authority-Analysis: v=2.4 cv=QJVuRBLL c=1 sm=1 tr=0 ts=65e4c4b9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=EwQ0U1yehIFNlhT6KY0A:9 a=QEXdDO2ut3YA:10 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kpb4FL0Cuo1ODlTLeglUxDqds2fZ1bIA3JGoVa9PHqg=; b=EWwZSxUwM3SbjQ0maZBCqNGulV AkvFT5HQNfN8qtltd75hiCc1lgiTzETQvNLzM+yVvs5pBKGPAQ97uMBPYvGxmDC36swgKODwfzBv+ 3TeBPT87VZepOwrUDBkwRpAr5; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:40354 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rgqng-003gi2-1Z for gdb-patches@sourceware.org; Sun, 03 Mar 2024 11:43:04 -0700 From: Tom Tromey Subject: [PATCH v2 0/3] Use ui-out tables in a few spots Date: Sun, 03 Mar 2024 11:43:02 -0700 Message-Id: <20240303-info-proc-ui-out-v2-0-cf3d2013b33e@tromey.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIALbE5GUC/32NQQ6DIBBFr2JYdxpEbWhX3qNxATjWWQhmQFNjv HvRA3T5kvff30VEJoziVeyCcaVIwWdQt0K40fgPAvWZhZKqklo+gfwQYObgYCEISwKHurJ1rXS DTuTZzDjQ90q+u8zWRATLxrvxDE0mJuRTHCmmwNt1vZan/udlLUFC9ehrW1o9NFq1icOE292FS XTHcfwA71V2mcoAAAA= To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rgqng-003gi2-1Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net ([192.168.0.21]) [71.211.170.195]:40354 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfL+veaESsv8X+B6iR5xwfbcfpADVHbJcpzaT31Dcc4ACxYsdfUkP1OSdj+6Is60MlYs+QOOc9dTxcpeKsc4sz56sEV4i8CvYR+nEPXcd4Ni1Xk1iBC0v yNbjfuQ8V25uDBWn98UektrpokEE1qwkZQwDUQ2soFP3l2nG/93wFf1IS15tDZyTH+JP4XdQIAod+KkIVvfM7SDKRaYMdE0xpdU= X-Spam-Status: No, score=-3016.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This series changes a few spots to use ui-out tables rather than hand-aligned printf-based ones. I think ui-out tables should generally be preferred: * They are more flexible and easier to use * They sometimes provide automatic styling (like addresses in this series) * They allow the possibility of structured reuse via MI There are still a few such tables left in gdb after this series, but they are all in code I can't readily test: fbsd-tdep.c, darwin-nat-info.c, and netbsd-tdep.c. Regression tested on x86-64 Fedora 38. --- Changes in v2: - Rebased - Fixed test failure pointed out in review - Link to v1: https://inbox.sourceware.org/gdb-patches/20230809-info-proc-ui-out-v1-0-36d4b1b8f582@tromey.com --- Tom Tromey (3): Use ui-out in maintenance_print_user_registers Use ui-out in core_target::info_proc_mappings Use ui-out tables in linux-tdep.c gdb/corelow.c | 54 +++++++--------- gdb/linux-tdep.c | 114 ++++++++++++++-------------------- gdb/testsuite/gdb.base/completion.exp | 2 +- gdb/user-regs.c | 14 ++++- 4 files changed, 81 insertions(+), 103 deletions(-) --- base-commit: 90f8d97c8efa75f7f019b868eca9c626bc35203d change-id: 20230809-info-proc-ui-out-ce83b44285ec Best regards,