mbox series

[0/3] Fix ordering of configurationDone and launch

Message ID 20240124-dap-launch-fix-v1-0-0d47f87fa9f0@adacore.com
Headers
Series Fix ordering of configurationDone and launch |

Message

Tom Tromey Jan. 24, 2024, 3:48 p.m. UTC 
  This series is really just a couple of small preparatory patches
before patch #3, where the problem is described.  Anyway, gdb's
implementation of 'launch' is wrong -- it should really start the
inferior.  DAP, somewhat bizarrely IMO, wants the client to set
breakpoints and such before the debugger knows what executable to use.
This series fixes gdb to follow the spec here.

---
Tom Tromey (3):
      Export dap_initialize
      Clean up suppress_new_breakpoint_event
      Fix DAP launch and configurationDone requests

 gdb/python/lib/gdb/dap/breakpoint.py      | 135 ++++++++++++++++--------------
 gdb/python/lib/gdb/dap/launch.py          |  29 ++-----
 gdb/testsuite/gdb.dap/ada-arrays.exp      |   8 +-
 gdb/testsuite/gdb.dap/ada-nested.exp      |   7 +-
 gdb/testsuite/gdb.dap/ada-scopes.exp      |   7 +-
 gdb/testsuite/gdb.dap/args-env.exp        |   8 +-
 gdb/testsuite/gdb.dap/assign.exp          |   7 +-
 gdb/testsuite/gdb.dap/basic-dap.exp       |  63 +++++++-------
 gdb/testsuite/gdb.dap/bt-nodebug.exp      |   8 +-
 gdb/testsuite/gdb.dap/catch-exception.exp |   7 +-
 gdb/testsuite/gdb.dap/children.exp        |   7 +-
 gdb/testsuite/gdb.dap/cond-bp.exp         |  16 +++-
 gdb/testsuite/gdb.dap/cwd.exp             |   7 +-
 gdb/testsuite/gdb.dap/cxx-exception.exp   |   7 +-
 gdb/testsuite/gdb.dap/eof.exp             |   2 +-
 gdb/testsuite/gdb.dap/frameless.exp       |   9 +-
 gdb/testsuite/gdb.dap/hover.exp           |   8 +-
 gdb/testsuite/gdb.dap/lazy-string.exp     |   7 +-
 gdb/testsuite/gdb.dap/log-message.exp     |   8 +-
 gdb/testsuite/gdb.dap/memory.exp          |   8 +-
 gdb/testsuite/gdb.dap/modules.exp         |   7 +-
 gdb/testsuite/gdb.dap/pause.exp           |   8 +-
 gdb/testsuite/gdb.dap/ptrref.exp          |   8 +-
 gdb/testsuite/gdb.dap/rust-slices.exp     |   8 +-
 gdb/testsuite/gdb.dap/scopes.exp          |   8 +-
 gdb/testsuite/gdb.dap/sources.exp         |   4 +
 gdb/testsuite/gdb.dap/stack-format.exp    |   7 +-
 gdb/testsuite/gdb.dap/stop-at-main.exp    |   6 +-
 gdb/testsuite/gdb.dap/terminate.exp       |   6 +-
 gdb/testsuite/lib/dap-support.exp         |  25 +++---
 30 files changed, 260 insertions(+), 185 deletions(-)
---
base-commit: 7737b1336402cd4682538620ab996bdb7ad0ea79
change-id: 20240124-dap-launch-fix-6f4ac7637286

Best regards,

Comments

Tom Tromey Feb. 12, 2024, 5:41 p.m. UTC | #1 
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:

Tom> This series is really just a couple of small preparatory patches
Tom> before patch #3, where the problem is described.  Anyway, gdb's
Tom> implementation of 'launch' is wrong -- it should really start the
Tom> inferior.  DAP, somewhat bizarrely IMO, wants the client to set
Tom> breakpoints and such before the debugger knows what executable to use.
Tom> This series fixes gdb to follow the spec here.

I'm checking this in.

Tom