mbox series

[v2,00/14] Cleanups for the TUi register window

Message ID 20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com
Headers
Series Cleanups for the TUi register window |

Message

Tom Tromey Jan. 20, 2024, 6:23 p.m. UTC 
  This series is a grab-bag of cleanups to the TUI register window.

I've tried to untangle the code somewhat, with the goal being removing
the extra rerender overload.

This series also fixes the 'exit' bug and removes the hacky and
unnecessary recursion flag from tui-hooks.c.

More cleanups here are possible -- the register window is pretty old
code and pretty ugly.  In particular:

* the layout code is still pretty bad

* it doesn't really make sense for check_register_values to accept a
  frame, because the window can only really ever use the selected
  frame anyway

* there's no horizontal scrolling, but for vector registers this might
  be nice (there's a bug about this)

---
Changes in v2:
- Addressed review comments
- Link to v1: https://inbox.sourceware.org/gdb-patches/20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com

---
Tom Tromey (14):
      Use pop_back in tui_register_format
      Minor C++ cleanups in tui-regs.c
      Simplify tui_data_window::show_register_group
      Rename tui_data_item_window -> tui_register_info
      Change tui_register_info::visible to a method
      Move scrollok call in register window
      Simplify update_register_data
      Remove the TUI register window rerender overload
      Simplify tui_data_win::erase_data_content
      Remove tui_refreshing_registers
      Remove redundant check from tui_refresh_frame_and_register_information
      Return void from tui_show_frame_info
      Rename show_registers -> set_register_group
      Update TUI register window when the inferior exits

 gdb/testsuite/gdb.tui/regs.exp |   8 ++
 gdb/tui/tui-hooks.c            |  36 +++----
 gdb/tui/tui-regs.c             | 229 +++++++++++++++--------------------------
 gdb/tui/tui-regs.h             |  59 ++++++-----
 gdb/tui/tui-status.c           |  16 ++-
 gdb/tui/tui-status.h           |   2 +-
 6 files changed, 148 insertions(+), 202 deletions(-)
---
base-commit: 7ae24327467750c445733e40d840e502795dbdf3
change-id: 20231217-tui-regs-cleanup-36d8f390a65a

Best regards,

Comments

Andrew Burgess Feb. 8, 2024, 11:37 a.m. UTC | #1 
Tom Tromey <tom@tromey.com> writes:

> This series is a grab-bag of cleanups to the TUI register window.
>
> I've tried to untangle the code somewhat, with the goal being removing
> the extra rerender overload.
>
> This series also fixes the 'exit' bug and removes the hacky and
> unnecessary recursion flag from tui-hooks.c.
>
> More cleanups here are possible -- the register window is pretty old
> code and pretty ugly.  In particular:
>
> * the layout code is still pretty bad
>
> * it doesn't really make sense for check_register_values to accept a
>   frame, because the window can only really ever use the selected
>   frame anyway
>
> * there's no horizontal scrolling, but for vector registers this might
>   be nice (there's a bug about this)

This all looks great.  Spotted one typo in a commit message (see
separate email), but otherwise:

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


>
> ---
> Changes in v2:
> - Addressed review comments
> - Link to v1: https://inbox.sourceware.org/gdb-patches/20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com
>
> ---
> Tom Tromey (14):
>       Use pop_back in tui_register_format
>       Minor C++ cleanups in tui-regs.c
>       Simplify tui_data_window::show_register_group
>       Rename tui_data_item_window -> tui_register_info
>       Change tui_register_info::visible to a method
>       Move scrollok call in register window
>       Simplify update_register_data
>       Remove the TUI register window rerender overload
>       Simplify tui_data_win::erase_data_content
>       Remove tui_refreshing_registers
>       Remove redundant check from tui_refresh_frame_and_register_information
>       Return void from tui_show_frame_info
>       Rename show_registers -> set_register_group
>       Update TUI register window when the inferior exits
>
>  gdb/testsuite/gdb.tui/regs.exp |   8 ++
>  gdb/tui/tui-hooks.c            |  36 +++----
>  gdb/tui/tui-regs.c             | 229 +++++++++++++++--------------------------
>  gdb/tui/tui-regs.h             |  59 ++++++-----
>  gdb/tui/tui-status.c           |  16 ++-
>  gdb/tui/tui-status.h           |   2 +-
>  6 files changed, 148 insertions(+), 202 deletions(-)
> ---
> base-commit: 7ae24327467750c445733e40d840e502795dbdf3
> change-id: 20231217-tui-regs-cleanup-36d8f390a65a
>
> Best regards,
> -- 
> Tom Tromey <tom@tromey.com>