Message ID | 20231114094535.434194-1-ying.huang@oss.cipunited.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F0783857C4F for <patchwork@sourceware.org>; Tue, 14 Nov 2023 09:46:37 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from s02.bc.larksuite.com (s02.bc.larksuite.com [209.127.230.20]) by sourceware.org (Postfix) with UTF8SMTPS id C7317385697B for <gdb-patches@sourceware.org>; Tue, 14 Nov 2023 09:45:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7317385697B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7317385697B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.127.230.20 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699955158; cv=none; b=Qu+f/70Pl2WmX8u/hqlVIBdTBqxs98nZMkkg5VQH/caH3Fm/YrakrE8EXzhavucwQHyuYrEhuPG2Ixagoclkul015E1EOr38oKeQoqGo5s8XQrpzeIcRF+RHyWc3sDNBRds/FBegf73/BX86hJljlA3ajqzJ3GiSpbeWphOPRKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699955158; c=relaxed/simple; bh=9xkjQyn+919yFc8cz0j9sNqtdoH4EymTcEdrREvDPpY=; h=DKIM-Signature:Subject:To:From:Date:Message-Id:Mime-Version; b=x563HpWQMhBwgPxd+BC3SZ0tvOV9x9TDzTL1TriPaZO7h/y3WMsRtRm4JKgkQqVoohvXAAdeFJus5rGaIXWWJC+HrrNmWts9vuDWbun87G+D+p6vHvEUCcU7xYvvUHraksqboxfB3nZ8K+M/e1qvPDChRR5y1uVK0orB/0jPt4w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1699955145; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=9xkjQyn+919yFc8cz0j9sNqtdoH4EymTcEdrREvDPpY=; b=e/g/HiX092Hacugu3YowpIHyAQe8b4kpQxiz9cgxlRMyufFGteTjeU3/Iub8LZQmWuEcwV PFHY4i4RfFzxJTndC8FNX9mzjJ34V4T5RyPSLmU2ln3ROiiuZ/ZPixfFT/a9zksQ6L59PI 6aJAjJspDM132P8za33gN0fL8ULJKOEtCZKXe2z2rpQ0dRWderqDyuzZ00lFYonLxyrx3w 5xkI9WarK/6ajQRfAtUluMj1r3kSjdq2LOAYvHEWkyg/m2dhGw7kv699TpCynKYCWl6JsX 1QjqhTl6hJ5o9x/c71AsiWW6sWimWfGkDcH/jYgimLyHWwXVYQ/ZKOO47gVnLQ== Content-Type: text/plain; charset=UTF-8 Subject: [PATCH 0/2] Change all E_MIPS_* to EF_MIPS_* Content-Transfer-Encoding: 7bit X-Mailer: git-send-email 2.30.2 Cc: <yunqiang.su@oss.cipunited.com> X-Original-From: Ying Huang X-Lms-Return-Path: <lba+2655341c9+241550+sourceware.org+ying.huang@oss.cipunited.com> Received: from localhost.localdomain ([1.192.16.206]) by smtp.feishu.cn with ESMTPS; Tue, 14 Nov 2023 17:45:44 +0800 To: <gdb-patches@sourceware.org> From: "Ying Huang" <ying.huang@oss.cipunited.com> Date: Tue, 14 Nov 2023 17:45:33 +0800 Message-Id: <20231114094535.434194-1-ying.huang@oss.cipunited.com> Mime-Version: 1.0 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Change all E_MIPS_* to EF_MIPS_*
|
|
Message
Ying Huang
Nov. 14, 2023, 9:45 a.m. UTC
According to we have changed all E_MIPS_* to EF_MIPS_* in binutils and glibc, we also need to change it here to keep same style. We can refer to this commit record: https://sourceware.org/pipermail/binutils/2023-October/129904.html
Comments
On 2023-11-14 09:45, Ying Huang wrote: > According to we have changed all E_MIPS_* to EF_MIPS_* in binutils > and glibc, we also need to change it here to keep same style. > We can refer to this commit record: > https://sourceware.org/pipermail/binutils/2023-October/129904.html This is OK, but please put this information in the commit logs themselves, so that if someone in the future needs to "git blame" the touched lines isn't left with an empty rationale for the change. So, you can add my: Approved-By: Pedro Alves <pedro@palves.net> with that change.
Hi Pedro, 在 2023/11/14 19:43, Pedro Alves 写道: > On 2023-11-14 09:45, Ying Huang wrote: >> According to we have changed all E_MIPS_* to EF_MIPS_* in binutils >> and glibc, we also need to change it here to keep same style. >> We can refer to this commit record: >> https://sourceware.org/pipermail/binutils/2023-October/129904.html > This is OK, but please put this information in the commit logs themselves, so that > if someone in the future needs to "git blame" the touched lines isn't left with > an empty rationale for the change. > > So, you can add my: > > Approved-By: Pedro Alves <pedro@palves.net> > > with that change. > OK, I would send patch V2 with commit message. Thanks, Ying
On Tue, Nov 14, 2023 at 11:43:27AM +0000, Pedro Alves wrote: > On 2023-11-14 09:45, Ying Huang wrote: > > According to we have changed all E_MIPS_* to EF_MIPS_* in binutils > > and glibc, we also need to change it here to keep same style. > > We can refer to this commit record: > > https://sourceware.org/pipermail/binutils/2023-October/129904.html > > This is OK, but please put this information in the commit logs themselves, so that > if someone in the future needs to "git blame" the touched lines isn't left with > an empty rationale for the change. > > So, you can add my: > > Approved-By: Pedro Alves <pedro@palves.net> > > with that change. > Thank you. I have pushed Ying's v2 patchset.