From patchwork Mon Oct 16 09:17:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 56242 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F79C385B537 for ; Mon, 16 Oct 2023 09:18:47 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 7287A3858298 for ; Mon, 16 Oct 2023 09:17:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7287A3858298 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7287A3858298 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.220.28 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697447852; cv=none; b=OWTYEsr1P9LCrTcuxb0nz+QCrVLyOpNdnro47VM1yC8U/LqA/Z55GcmqslDMgByROQ3D9OZ/7nzYEs5V6mSOenDiNZrEyafE1WwoirIwOQqTGGwSICrgyTmhH8y9a69p9grSyTSDbt1r0onKauhO/iq+ilRz6AIakxXdIn/3onw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697447852; c=relaxed/simple; bh=S4dS4P6ipX1x//kWPWIUCTOBirwKw9mOnhyvzqe+a7Q=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=ASP6jWrBKL2uCnrEHwwTysHNhbcMAjKENKEDzI+fKcoAfFpjyzYewo0w0G2KMA7fT9JjS5AwWuw3M0tHXPYfGBXyPucs+vrxpUeX3NYaX8Hx4To5cCE5OhYmacX7pIf24b67ApkmWj0+bkXg2y97ctVt29kd5XGrdFPoubja4Rk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 29C0D21882 for ; Mon, 16 Oct 2023 09:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697447847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mua1xFCreRFykMVUVZM6fg6q+Xqtq+85zfLZQiOL8lg=; b=qYTxxz2olvjqMKNhVHfK2ZWJJ5yp08kJxbYCLZju9xleiCX/K6oQiWXofB8Yz6GClR00jX pPcHFVUydh6s8zISGFJBaPckVPUGxtisFaiVFV1zVXgRi1Q2O+e/yIpYiovtEFvi8wWtNv 0hmcoit8OkZv60+PnAd7yUQ9s1gkg6Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697447847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mua1xFCreRFykMVUVZM6fg6q+Xqtq+85zfLZQiOL8lg=; b=/+P0fdRItKhCiKyFXkFQ/C6vPQFnYuMRslJ6JZy/VQ+KuOnovG6k3R/StPbdw5JYV47QxA AHT84Nn+oAqFrVBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 18BE8138EF for ; Mon, 16 Oct 2023 09:17:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MrTaBKf/LGUXLQAAMHmgww (envelope-from ) for ; Mon, 16 Oct 2023 09:17:27 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v3 0/4] [gdb/cli] Allow source highlighting to be interrupted Date: Mon, 16 Oct 2023 11:17:44 +0200 Message-Id: <20231016091748.26247-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 6.90 X-Spamd-Result: default: False [6.90 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_MISSING_CHARSET(2.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.98)[-0.979]; NEURAL_SPAM_LONG(3.00)[1.000]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.02)[54.87%] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I wrote this patch series to fix PR cli/30934. The 1st patch is an unrelated optimization, which I added to this series because it touches the same code. The 2nd patch factors out a function. The 3rd patch adds a means to keep track of styling failures in the source cache, as suggested here ( https://sourceware.org/pipermail/gdb-patches/2023-October/203164.html ). The 4th patch fixes the PR cli/30934. Changes in v3: - dropped the "#if __cplusplus >= 202002L" in the first patch. - added a reset of the highlighter's EventListener to prevent a dangling pointer. Changes in v2: - fixed a build problem with --disable-source-highlight, reported by the linaro CI. - temporarily installs the default_quit_handler to be able to use QUIT - added a question whether to interrupt highlighting or not (in the RFC, I had a warning, in v1 I dropped it) - added "gdb_assert (target_terminal::is_ours ())" Adding the question was inspired by the v3 patch "gdb/debuginfod: Ctrl-C ask to cancel further downloads" ( https://sourceware.org/pipermail/gdb-patches/2023-March/197679.html ). Submission history: - RFC: https://sourceware.org/pipermail/gdb-patches/2023-October/203157.html - v1: https://sourceware.org/pipermail/gdb-patches/2023-October/203179.html - v2: https://sourceware.org/pipermail/gdb-patches/2023-October/203199.html Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30934 Tom de Vries (4): [gdb/cli] Skip string copy in source_cache::ensure [gdb/cli] Factor out try_source_highlight [gdb/cli] Keep track of styling failures in source_cache [gdb/cli] Allow source highlighting to be interrupted gdb/source-cache.c | 175 +++++++++++++++++++++++++++++++++++---------- gdb/source-cache.h | 4 ++ 2 files changed, 143 insertions(+), 36 deletions(-) base-commit: 6674b23fe6409e08de9c36f640bd58127eff9dda Reviewed-By: Lancelot Six