From patchwork Tue Oct 10 20:39:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 56222 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CA4083857706 for ; Tue, 10 Oct 2023 20:42:31 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 856F43858D28 for ; Tue, 10 Oct 2023 20:42:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 856F43858D28 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3A6D51E091; Tue, 10 Oct 2023 16:42:15 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 00/24] C++ification of struct so_list Date: Tue, 10 Oct 2023 16:39:55 -0400 Message-ID: <20231010204213.111285-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3490.9 required=5.0 tests=BAYES_00, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This series modernizes the struct so_list area by C++ifying it a little bit and replacing the manual linked list implementation with intrusive_list. It also contains a few other cleanups written along the way. Simon Marchi (24): gdb: remove empty clear_solib functions gdb: add program_space parameter to target_so_ops::clear_solib gdb: make interps_notify work with references gdb: replace some so_list parameters to use references gdbsupport: use "reference" and "pointer" type aliases in intrusive_list gdbsupport: make intrusive_list's disposer accept a reference gdb: make get_cbfd_soname_build_id static gdb: allocate so_list with new, deallocate with delete gdb: rename lm_info_base to lm_info gdb: remove target_so_ops::free_so gdb: use gdb::checked_static_cast when casting lm_info gdb: make solib-svr4 not use so_list internally gdb: make solib-rocm not use so_list internally gdb: remove lm_info_vector typedef gdb: make so_list::lm_info a unique_ptr gdb: make clear_so a method of struct so_list gdb: remove target_section_table typedef gdb: make so_list::sections not a pointer gdb: make so_list::abfd a gdb_bfd_ref_ptr gdb: make so_list::{so_original_name,so_name} std::strings gdb: link so_list using intrusive_list gdb: don't call so_list::clear in free_so gdb: remove free_so function gdb: rename struct so_list to so gdb/bfd-target.c | 6 +- gdb/break-catch-load.c | 4 +- gdb/breakpoint.c | 6 +- gdb/bsd-uthread.c | 18 +- gdb/corelow.c | 7 +- gdb/exec.c | 24 +- gdb/exec.h | 6 +- gdb/hppa-tdep.c | 2 +- gdb/hppa-tdep.h | 4 +- gdb/inferior.c | 10 +- gdb/interps.c | 10 +- gdb/interps.h | 10 +- gdb/maint.c | 2 +- gdb/mi/mi-cmd-file.c | 6 +- gdb/mi/mi-interp.c | 26 +- gdb/mi/mi-interp.h | 6 +- gdb/nto-tdep.c | 6 +- gdb/nto-tdep.h | 3 +- gdb/observable.h | 7 +- gdb/progspace.c | 4 +- gdb/progspace.h | 26 +- gdb/record-full.c | 2 +- gdb/remote.c | 3 +- gdb/solib-aix.c | 69 +--- gdb/solib-darwin.c | 84 ++--- gdb/solib-dsbt.c | 73 ++-- gdb/solib-frv.c | 58 ++-- gdb/solib-rocm.c | 122 +++---- gdb/solib-svr4.c | 421 ++++++++--------------- gdb/solib-svr4.h | 4 +- gdb/solib-target.c | 121 +++---- gdb/solib.c | 309 ++++++++--------- gdb/solib.h | 13 +- gdb/solist.h | 77 ++--- gdb/symfile.c | 2 +- gdb/symfile.h | 2 +- gdb/target-debug.h | 4 +- gdb/target-delegates.c | 14 +- gdb/target-section.h | 6 +- gdb/target.c | 10 +- gdb/target.h | 6 +- gdb/unittests/intrusive_list-selftests.c | 4 +- gdbsupport/intrusive_list.h | 30 +- 43 files changed, 658 insertions(+), 969 deletions(-) base-commit: 635b2dd919b8c58e164b77c396041935fca1d66a Reviewed-By: Lancelot Six