From patchwork Thu Oct 5 11:35:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinevere Larsen X-Patchwork-Id: 56205 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32F163887F78 for ; Thu, 5 Oct 2023 11:45:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32F163887F78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696506349; bh=K32jzL5G23flMtmd1rlls2nmxwggvLcr1FI9w5y3O8w=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=n7XAiZ7YrKML3dT2QfFzSdhCb4VB+ALrsLzH6Yh5TnqHVQYxVgLagCqP9PW1uxh2E GExpHjDA6lHwLKls+92SgHjoD6dc7tajl+e48ZdoQOO2MmMCUG1Zyk1F5fkkE3spa5 zV291IuEMib5ryVYCEPYVqERiHxOSmVdU1Pt/YsA= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 699463830B6A for ; Thu, 5 Oct 2023 11:45:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 699463830B6A Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-644-M_cHFYNSNt6nRpoZHavmDw-1; Thu, 05 Oct 2023 07:45:18 -0400 X-MC-Unique: M_cHFYNSNt6nRpoZHavmDw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF65F2815E2E; Thu, 5 Oct 2023 11:45:17 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.225.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AE8840C6EA8; Thu, 5 Oct 2023 11:45:16 +0000 (UTC) To: gdb-patches@sourceware.org Cc: eliz@gnu.org, Guinevere Larsen Subject: [PATCH v5 0/1] update MAINTAINERS file with git trailers Date: Thu, 5 Oct 2023 13:35:33 +0200 Message-ID: <20231005113533.86112-2-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Guinevere Larsen via Gdb-patches From: Guinevere Larsen Reply-To: Guinevere Larsen Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Some private chats highlighted that the currently in use git trailers aren't explained well enough. This patch aims to fix that by adding the information in a more verbose way to guarantee that everyone is on the same page about them and refine anything that might still need work. I forgot that Kevin had given a soft approval of this, so I kept his review tag, but further chatter on the latest cauldron conference had people agreeing that Acked-by should be used as partial approval, so I reworded that section of the patch to be more inline with how other projects use it. One concern that was raised in the conference is how b4 reacts to trailing parenthesis. It seems that newer b4 versions (at least on 0.12.3) drop that, while older versions (0.10.1) keep it. I'm not sure if this change was intentional or not, and I have informed the b4 project of the regression, but this raises the question: Do we want to have the trailing parenthesis saying which areas were approved by an ack, or is it ok to just have it in regular text? Personally I like adding it either way in replies, but not making it a requirement when pushing code, so its easy to see in old emails and no one gets inconvenienced, but I'm not dead set on this. Guinevere Larsen (1): [gdb]: add git trailer information on gdb/MAINTAINERS gdb/MAINTAINERS | 72 +++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 64 insertions(+), 8 deletions(-)