mbox series

[00/13,gdb/symtab,cc-with-dwz] Fix gdb.cp/breakpoint-locs.exp

Message ID 20231002125051.29911-1-tdevries@suse.de
Headers
Series Fix gdb.cp/breakpoint-locs.exp |

Message

Tom de Vries Oct. 2, 2023, 12:50 p.m. UTC 
  [ Submitted an earlier RFC version at
https://sourceware.org/pipermail/gdb-patches/2023-September/202443.html. ]

When running test-case gdb.cp/breakpoint-locs.exp with target board
cc-with-dwz, we occasionally run into:
...
FAIL: gdb.cp/breakpoint-locs.exp: break N1::C1::baz
...
due to the breakpoint having one instead of two locations.

This is PR symtab/30728.  This series fixes it.

The fix is dependent on the fix for PR symtab/30846, which is about incorrect
parent entries in the cooked index, due to inter-cu (intra-shard and
inter-shard) references.

The series consists of three parts:
- patches that fix PR symtab/30846.
- patches that add two optimizations to the fix for PR symtab/30846
  (one preparation patch, and two optimization patches),
- the last patch, that fixes PR symtab/30728.

The fix for PR symtab/30728 consists of adding entries to the cooked index for
DW_TAG_inlined_subroutine DIEs, with correct parent entries.

Tested on x86_64-linux, with target boards unix, cc-with-dwz and
cc-with-dwz-m.

I've split out the two added test-cases into separate patches.  Unfortunately
the patch "[gdb/symtab] Resolve deferred entries, inter-shard case" is still
somewhat large due to moving code about.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30728
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30846

Tom de Vries (13):
  [gdb/symtab] Factor out m_die_range_map usage
  [gdb/symtab] Check effect in parent_map::set_parent
  [gdb/symtab] Handle nullptr parent in parent_map::set_parent
  [gdb/symtab] Add parent_map::dump
  [gdb/symtab] Factor out m_deferred_entries usage
  [gdb/symtab] Add debug_handle_deferred_entries
  [gdb/symtab] Resolve deferred entries, inter-shard case
  [gdb/testsuite] Add gdb.dwarf2/forward-spec-inter-cu.exp
  [gdb/symtab] Keep track of processed DIEs in shard
  [gdb/symtab] Resolve deferred entries, intra-shard case
  [gdb/symtab] Don't defer backward refs, inter-cu intra-shard case
  [gdb/testsuite] Add gdb.dwarf2/backward-spec-inter-cu.exp
  [gdb/symtab] Add DW_TAG_inlined_subroutine entries in the cooked index
    for c++

 gdb/addrmap.c                                 |  19 +-
 gdb/addrmap.h                                 |   7 +-
 gdb/dwarf2/cooked-index.c                     | 141 ++++++++++++++
 gdb/dwarf2/cooked-index.h                     | 145 +++++++++++++-
 gdb/dwarf2/read.c                             | 178 +++++++++++++-----
 .../gdb.dwarf2/backward-spec-inter-cu.exp     | 111 +++++++++++
 .../gdb.dwarf2/forward-spec-inter-cu.exp      | 107 +++++++++++
 7 files changed, 657 insertions(+), 51 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/backward-spec-inter-cu.exp
 create mode 100644 gdb/testsuite/gdb.dwarf2/forward-spec-inter-cu.exp


base-commit: 6a6117ab0ffe18ea984abca84869eae799c1b346