mbox series

[v2,0/7] Rewrite gdb_bfd_openr_iovec to be type-safe

Message ID 20230918-gdb-bfd-vec-v2-0-162c0e9a2bc9@adacore.com
Headers
Series Rewrite gdb_bfd_openr_iovec to be type-safe |

Message

Tom Tromey Sept. 18, 2023, 2:52 p.m. UTC 
  This series rewrites gdb_bfd_openr_iovec to be type-safe.

Note that I can't really test the solib-rocm.c changes, this was done
as a best effort.

Regression tested on x86-64 Fedora 36.

---
Changes in v2:
- Use static_cast
- Applied fix to the rocm patch
- Link to v1: https://inbox.sourceware.org/gdb-patches/20230824-gdb-bfd-vec-v1-0-850e4e907ed1@adacore.com

---
Tom Tromey (7):
      Introduce type-safe variant of gdb_bfd_openr_iovec
      Small constructor change to target_buffer
      Convert mem_bfd_iovec to new type-safe gdb_bfd_openr_iovec
      Convert target fileio to new type-safe gdb_bfd_openr_iovec
      Convert minidebug to new type-safe gdb_bfd_openr_iovec
      Convert solib-rocm to new type-safe gdb_bfd_openr_iovec
      Remove old gdb_bfd_openr_iovec

 gdb/gdb_bfd.c    | 211 +++++++++++++++++++++++++++----------------------------
 gdb/gdb_bfd.h    |  43 ++++++++----
 gdb/minidebug.c  |  98 +++++++++++---------------
 gdb/solib-rocm.c |  66 +++++------------
 4 files changed, 191 insertions(+), 227 deletions(-)
---
base-commit: cf2ab5ef0b716dea512d85276c484fce758fa5d4
change-id: 20230824-gdb-bfd-vec-ba7f6c1139bb

Best regards,

Comments

Lancelot SIX Sept. 28, 2023, 10:02 a.m. UTC | #1 
Hi Tom,

I went through the series and tested it locally (native boald against
master and downstream ROCgdb).

Reviewed-By: Lancelot Six <lancelot.six@amd.com>

Best,
Lancelot.
Tom Tromey Sept. 28, 2023, 4:45 p.m. UTC | #2 
>>>>> "Lancelot" == Lancelot SIX <lancelot.six@amd.com> writes:

Lancelot> Hi Tom,
Lancelot> I went through the series and tested it locally (native boald against
Lancelot> master and downstream ROCgdb).

Lancelot> Reviewed-By: Lancelot Six <lancelot.six@amd.com>

Thank you, I'm going to check this in.

Tom