From patchwork Thu Aug 3 00:56:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Buettner X-Patchwork-Id: 55964 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81D3E3858002 for ; Thu, 3 Aug 2023 01:12:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81D3E3858002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691025161; bh=mFIYB0o0il8fbuaBKQjkctNsMa56mSwtWKiUbTrfi2M=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=jaQb+tJzIgwyWU001nwV5ugVRKkBKg646BVBacRE+MaeZnPEeOVAd/n2pjSvfFqAl 8v1bzVZYPYkjSeNSUl4XnqJPKR7bKteiXLNQIcsg4jIBKz+gtHBgDj+SH/rcReoHAu KcjgRAg5q1dXBXtytDgb8X5kZPYttr6bP9SXHv38= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7CF7A385843E for ; Thu, 3 Aug 2023 01:12:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CF7A385843E Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-668-ODY3rgmSM4qG1GIvdyGLnQ-1; Wed, 02 Aug 2023 21:12:13 -0400 X-MC-Unique: ODY3rgmSM4qG1GIvdyGLnQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A9F3B1C03D95; Thu, 3 Aug 2023 01:12:12 +0000 (UTC) Received: from f38-1.lan (unknown [10.22.16.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC8362166B25; Thu, 3 Aug 2023 01:12:11 +0000 (UTC) To: gdb-patches@sourceware.org Cc: zhiyong.yan@windriver.com, simon.marchi@polymtl.ca, Kevin Buettner Subject: [PATCH 0/1] gdbserver: Reinstall software single-step breakpoints in resume_stopped_resumed_lwps Date: Wed, 2 Aug 2023 17:56:00 -0700 Message-ID: <20230803011146.2093194-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kevin Buettner via Gdb-patches From: Kevin Buettner Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This patch fixes a problem with software single-stepping in gdbserver. See the 1/1 patch for the details. The fix proper is based on the work of Zhiyong Yan, who I've credited with a Co-Authored-By tag in the 1/1 patch. The test case was also partly Zhiyong's work since I adapted the C file from the reproducer in the bug that was filed for this problem. Zhiyong, please check to make sure that this revised change to gdbserver/linux-low.c still fixes the bug on your board. I've added Simon as a CC since the .exp file for the new test is based on gdb.threads/next-fork-other-thread.exp, which he authored. Also, from my reading of the commit log for that test, I gather that Simon has looked at a related problem in the past. Kevin Buettner (1): gdbserver: Reinstall software single-step breakpoints in resume_stopped_resumed_lwps .../gdb.threads/next-fork-exec-other-thread.c | 82 +++++++++++ .../next-fork-exec-other-thread.exp | 131 ++++++++++++++++++ gdbserver/linux-low.cc | 7 +- 3 files changed, 219 insertions(+), 1 deletion(-) create mode 100644 gdb/testsuite/gdb.threads/next-fork-exec-other-thread.c create mode 100644 gdb/testsuite/gdb.threads/next-fork-exec-other-thread.exp