From patchwork Tue May 30 10:53:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 55802 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6942D3855885 for ; Tue, 30 May 2023 10:53:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6942D3855885 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685444033; bh=4NSOs5hfY5UqL8DZ7ABL3krnQqhXuLGsdHxQ0xC2w5M=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=FKB2NBY7QUD6xSajSoRdgNVDsOhVUHXar2sUZrZ/zPhBCLPmVDX5lu/kJ37lJNNRt 9zaRvzoh+lD0zFlugGRXy/jCHWBc96IU2jYBBkfSymciaxtC5/E5+/q5Py9aODDS7s UjkFGvAsVUtU55wEtZagG5K0NSrNrZddQ3l18Tmk= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id EF42C3858D20 for ; Tue, 30 May 2023 10:53:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF42C3858D20 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3132E219FE; Tue, 30 May 2023 10:53:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 19E4013478; Tue, 30 May 2023 10:53:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8tQaBabVdWTNZgAAMHmgww (envelope-from ); Tue, 30 May 2023 10:53:26 +0000 To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 0/3] [gdb/tui] Improve handling of inferior output Date: Tue, 30 May 2023 12:53:21 +0200 Message-Id: <20230530105324.23089-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When inferior output in TUI causes scrolling, the TUI screen is garbled. This is a known issue, PR tui/14332. This can be fixed manually by doing ^L. I noticed though that doing ^L removes the inferior output. The first patch fixes this. The third patch automates doing ^L when the gdb_tty_state changes to target_terminal_state::is_ours, such what we no longer have to do ^L. The second patch is an infrastructure patch used by the third patch. Tested on x86_64-linux. Tom de Vries (3): [gdb/tui] Keep inferior output in cmd window with ^L [gdb] Add observable terminal_owner_changed [gdb/tui] Refresh on target_terminal_state::is_ours gdb/inflow.c | 176 ++++++++++++++++++-------------- gdb/observable.c | 1 + gdb/observable.h | 5 + gdb/testsuite/gdb.tui/hello.c | 25 +++++ gdb/testsuite/gdb.tui/hello.exp | 54 ++++++++++ gdb/tui/tui-hooks.c | 11 ++ gdb/tui/tui-io.c | 2 +- gdb/tui/tui-win.c | 18 +++- gdb/tui/tui-win.h | 2 +- gdb/tui/tui-wingeneral.c | 5 +- gdb/tui/tui-wingeneral.h | 2 +- 11 files changed, 214 insertions(+), 87 deletions(-) create mode 100644 gdb/testsuite/gdb.tui/hello.c create mode 100644 gdb/testsuite/gdb.tui/hello.exp base-commit: 796029320e75a141570220224731c8151311f8d9