From patchwork Mon May 8 14:10:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 55741 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3305E3856091 for ; Mon, 8 May 2023 14:11:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3305E3856091 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683555063; bh=XxHRD0MZMiEf7+DhwU8vpQCFR0VQo0mF4YxCZ1TCdEU=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=GCwA+qNv0ckEi6X8YwRenFsOO5BuT9aXdCJFNvcAaIzGcc3uW6u2h4t1bUn75OLU9 8Zz8kdjzOa1mWpeikUa3Zwe5NAqEHR/UU/ri3XjAPRDbSnHfOLgvtHyORHc8BrGkzk D0DPs/u0tRiKZwsXj947TrMBK103+jwwC4C4ZVRU= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 9B04D3858C2C for ; Mon, 8 May 2023 14:10:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B04D3858C2C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D08B41FF40; Mon, 8 May 2023 14:10:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 819491346B; Mon, 8 May 2023 14:10:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IUlNG94CWWSpAwAAMHmgww (envelope-from ); Mon, 08 May 2023 14:10:38 +0000 To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 0/3] [gdb/tui] Add tui border-kind active-ascii Date: Mon, 8 May 2023 16:10:33 +0200 Message-Id: <20230508141036.22723-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I wrote a patch that adds a new tui border-kind: active-ascii. That patch makes changes in function tui_update_variables, and I ended up writing a patch that simplifies it by factoring out some functions, to make subsequent changes in the function easier. While factoring out one of the functions, I noticed a pre-existing buglet in one of them, so I wrote a separate patch to fix this. Tested on x86_64-linux, by rebuilding and running test-cases gdb.tui/*.exp and gdb.python/tui*.exp for each patch. Tom de Vries (3): [gdb/tui] Make tui_update_variables more readable [gdb/tui] Fix buglet in set_border_kind_item [gdb/tui] Add tui border-kind active-ascii gdb/doc/gdb.texinfo | 4 + gdb/testsuite/gdb.tui/tui-focus.exp | 7 +- gdb/testsuite/lib/tuiterm.exp | 49 +++++----- gdb/tui/tui-win.c | 139 +++++++++++++++++++++------- gdb/tui/tui-win.h | 6 ++ gdb/tui/tui-wingeneral.c | 17 +++- 6 files changed, 163 insertions(+), 59 deletions(-) base-commit: c239019c9f649867c686204d1ac8947a963784d8