From patchwork Sat Apr 15 15:13:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 55687 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FC5438555A8 for ; Sat, 15 Apr 2023 15:14:03 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 1145F3857736 for ; Sat, 15 Apr 2023 15:13:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1145F3857736 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id B34C010047E19 for ; Sat, 15 Apr 2023 15:13:43 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id nhaxpszDUJHDXnhaxpGcuq; Sat, 15 Apr 2023 15:13:43 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BLZ2EHcG c=1 sm=1 tr=0 ts=643abf27 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=Q6yEJI1MePsnTHaXwd0A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lSxf2Q+EB1WEZFjE2QQ50jGixY6KpJtCCRMMwzoybpk=; b=lMXqQ7xRmROnTAth3R+sm7iTLo ASdn2Q2VC6FswBTABv8C3Vl62OsmHC4p/hqSnJWaZhY+pQnrGb2bgHNtRp3BZ+uwNjya/tjQGwtae 1uUQuT3T8WvGc/KNRp5naSakg; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:43720 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pnhax-0021Ms-CO for gdb-patches@sourceware.org; Sat, 15 Apr 2023 09:13:43 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [RFC 0/5] Add new "critical" command to test suite Date: Sat, 15 Apr 2023 09:13:31 -0600 Message-Id: <20230415151336.4104455-1-tom@tromey.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pnhax-0021Ms-CO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (localhost.localdomain) [71.211.191.82]:43720 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This introduces a new "critical" command to the test suite. The idea here is to replace typical uses of "if ... { return }" with a simpler notation. Centralizing this also lets us decide -- like "require" -- whether to use untested or unsupported. This command has a bit of a conceptual overlap with "require". I tend to think of "require" as expressing static properties of the test, whereas "critical" is used to early abort if certain runtime operations fail; but this isn't enforced. Anyway, unlike require, "critical" can handle multiple arguments and a variety of return value conventions. It is implemented as a Tcl namespace ensemble for this reason. In this series, I converted gdb.rust to the new scheme, just to show how it works. I'm sending it as an RFC for discussion. If it seems ok, I thought I'd write some scripts to mass convert the rest of the test suite. Tom