mbox series

[0/6] Use unrelocate_addr in more places

Message ID 20230321-submit-unrelocated-type-v1-0-2a1fb6117abf@tromey.com
Headers
Series Use unrelocate_addr in more places |

Message

Tom Tromey March 21, 2023, 7:18 p.m. UTC 
  Minimal symbols, partial symbols, and partial symtabs all use
unrelocated addresses right now.  This series converts these to use
the unrelocated_addr type, revealing (I believe) a few latent bugs.

Regression tested on x86-64 Fedora 36.

Tom

---
Tom Tromey (6):
      Use function_view in gdb_bfd_lookup_symbol
      Move definition of unrelocated_addr earlier
      Use unrelocated_addr in partial symbol tables
      Use unrelocated_addr in psymbols
      Use unrelocated_addr in minimal symbols
      Rename "raw" to "unrelocated"

 gdb/coff-pe-read.c |  13 +++---
 gdb/coffread.c     |  12 +++---
 gdb/ctfread.c      |  27 +++++++------
 gdb/dbxread.c      | 114 ++++++++++++++++++++++++++++++++---------------------
 gdb/elfread.c      |  22 ++++++-----
 gdb/findvar.c      |   4 +-
 gdb/machoread.c    |   4 +-
 gdb/mdebugread.c   | 104 +++++++++++++++++++++++++++++-------------------
 gdb/minsyms.c      |  68 ++++++++++++++++----------------
 gdb/minsyms.h      |   6 +--
 gdb/mips-tdep.c    |   6 ++-
 gdb/mipsread.c     |   2 +-
 gdb/parse.c        |   2 +-
 gdb/printcmd.c     |   2 +-
 gdb/psympriv.h     |  42 ++++++++++----------
 gdb/psymtab.c      |  11 +++---
 gdb/solib-dsbt.c   |  17 ++++----
 gdb/solib-frv.c    |  15 +++----
 gdb/solib-svr4.c   |  20 +++++-----
 gdb/solib.c        |  31 ++++++---------
 gdb/solib.h        |  14 +++----
 gdb/stabsread.h    |   2 +-
 gdb/symmisc.c      |   2 +-
 gdb/symtab.c       |   2 +-
 gdb/symtab.h       |  43 ++++++++++++++++----
 gdb/xcoffread.c    |  55 +++++++++++++++-----------
 26 files changed, 358 insertions(+), 282 deletions(-)
---
base-commit: 70ea5a46bd926149fb4a9c3da32c2fc14f6e83c3
change-id: 20230321-submit-unrelocated-type-c256e0e7da50

Best regards,

Comments

Alexandra Petlanova Hajkova March 28, 2023, 12:36 p.m. UTC | #1 
On Tue, Mar 21, 2023 at 8:18 PM Tom Tromey <tom@tromey.com> wrote:

> Minimal symbols, partial symbols, and partial symtabs all use
> unrelocated addresses right now.  This series converts these to use
> the unrelocated_addr type, revealing (I believe) a few latent bugs.
>
> Regression tested on x86-64 Fedora 36.
>
> Tom
>
> ---
> Tom Tromey (6):
>       Use function_view in gdb_bfd_lookup_symbol
>       Move definition of unrelocated_addr earlier
>       Use unrelocated_addr in partial symbol tables
>       Use unrelocated_addr in psymbols
>       Use unrelocated_addr in minimal symbols
>       Rename "raw" to "unrelocated"
>
> I can confirm the series show no regressions on Fedora 38, x86_64 machine.
>
Tom Tromey March 28, 2023, 9:23 p.m. UTC | #2 
>>>>> Alexandra Petlanova Hajkova <ahajkova@redhat.com> writes:

>  I can confirm the series show no regressions on Fedora 38, x86_64 machine.

Thank you.

Tom