From patchwork Thu Mar 9 17:50:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 55565 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3ECF83858408 for ; Thu, 9 Mar 2023 17:51:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3ECF83858408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678384298; bh=FNe8w9iIy527HaNX4HsdwDYWtUNQqx5QDGRvzOEGQ9E=; h=Subject:Date:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=v5jk6KWPCxbt+aKe5LK+AteG7HhMgYhOrkZPvWfiw/62SvrY4G0UihSrQHJWDyYJd MwjQ6U9s1TtXsrTdw1xOZqQbNbEK2McAIp+8qXvNDK7UtIsJIGksg9vofKKrE/gVlm DP1drexJNF0704yxfM0LqwqEfNUz7nWdIpu2Bqcc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 314B53858D20 for ; Thu, 9 Mar 2023 17:51:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 314B53858D20 Received: by mail-il1-x12b.google.com with SMTP id l2so1462960ilg.7 for ; Thu, 09 Mar 2023 09:51:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678384274; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FNe8w9iIy527HaNX4HsdwDYWtUNQqx5QDGRvzOEGQ9E=; b=jN2taUW+V1aRJRicE6B+qbJBo37cVugRrMID9NDFyS64uKO0qFoiyFZJfL9xVQT8lT WEB3vWcGGQ4USDk7JEDQoLR39PE0G9I4FlR5w7T1/EyfgjC0238/kGiRYroV02IpQEdI UIwXziNq3xvumgN1sUOr/zwIC5tgzq7KWH2OsppltI3QKRzB/+Lp0ETdpBCsPbMzc2Qv CuWItt903l2BLiM5bPg3TMXq1uF187hN6RLM72M6ntX2A/C+n2lZ0pYuaI7gc0ypLufH JDPEY98U4w7uLM6MsbCW9HXVbYl9/yvPG+j0xlXYjojgWHV2WI0KlACq4GSMg+SEYIg7 EfbQ== X-Gm-Message-State: AO0yUKVUpxKpKbyFxj2/CgroPik5YDYA5qvnMc0txPN/y2x1tkhEcnFE 2pRFscoJsltA9hnk60wBAYdpwoRCbG+YNLzsqU8= X-Google-Smtp-Source: AK7set84pBKcoIUq4CET+5dmYmkdl48YS6b83RB04DgmHPsQnNyXJ2AWRp1LIWfA4GMjsWOrsy0tiQ== X-Received: by 2002:a92:b30f:0:b0:315:9a7e:fb03 with SMTP id p15-20020a92b30f000000b003159a7efb03mr13175919ilh.29.1678384274384; Thu, 09 Mar 2023 09:51:14 -0800 (PST) Received: from localhost.localdomain (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id j5-20020a056e020ee500b00315785bfabfsm5572276ilk.47.2023.03.09.09.51.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 09:51:13 -0800 (PST) Subject: [PATCH 0/3] Handle dynamic properties and static link Date: Thu, 09 Mar 2023 10:50:54 -0700 Message-Id: <20230309-submit-static-link-fix-v1-0-23af27781fd2@adacore.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAH4cCmQC/x2NQQrCQAxFr1KyNjDTFrReRVxkYmqDdpRkKkLp3 Z26fLz/+Cu4mIrDuVnB5KOur1whHhrgifJdUG+VoQ1tF7owoC9p1oJeqCjjU/MDR/1i4vEYe+5 PYYhQ40QumIwyT3s+kxexXbxN6v7/eLlu2w8JgzsJgQAAAA== To: gdb-patches@sourceware.org X-Mailer: b4 0.12.1 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Ada uses static links and dynamic properties more than most other languages. A user found a bug when the two are combined, and this series fixes the problem. Regression tested on x86-64 Fedora 36. Tom --- Tom Tromey (3): Add frame parameter to resolve_dynamic_type Pass a frame to value_at_lazy and value_from_contents_and_address Use the correct frame when evaluating a dynamic property gdb/dwarf2/expr.c | 4 +- gdb/gdbtypes.c | 71 ++++++++++++++++++------------ gdb/gdbtypes.h | 6 ++- gdb/testsuite/gdb.ada/static-link.exp | 33 ++++++++++++++ gdb/testsuite/gdb.ada/static-link/pck.ads | 18 ++++++++ gdb/testsuite/gdb.ada/static-link/prog.adb | 35 +++++++++++++++ gdb/valops.c | 11 ++--- gdb/value.c | 6 ++- gdb/value.h | 14 ++++-- 9 files changed, 156 insertions(+), 42 deletions(-) --- base-commit: 093b56776fcf31ecc9342382341c1455fd397b16 change-id: 20230309-submit-static-link-fix-bcf714c48091 Best regards,