mbox series

[0/2] doc: MPFR is now a necessary requirement

Message ID 20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com
Headers
Series doc: MPFR is now a necessary requirement |

Message

Philippe Blain March 10, 2023, 5:46 p.m. UTC 
  This short series moves the "MPFR" requirement in the doc under the
"Tools/Packages Necessary for Building GDB" heading and uniformizes the wording
between the GMP and MPFR entries.

I tested the HTML doc build.

---
Philippe Blain (2):
      gdb/doc: MPFR is now a necessary requirement
      gdb/doc: uniformize wording for GMP and MPFR entries

 gdb/doc/gdb.texinfo | 31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)
---
base-commit: 4c9066e322f46faf9d753be6ff3e6a09ae668f86
change-id: 20230306-doc-require-mpfr-fix-65e7105fc410
--
b4

Comments

Philippe Blain March 25, 2023, 10:04 p.m. UTC | #1 
Le 2023-03-10 à 12:46, Philippe Blain a écrit :
> This short series moves the "MPFR" requirement in the doc under the
> "Tools/Packages Necessary for Building GDB" heading and uniformizes the wording
> between the GMP and MPFR entries.
> 
> I tested the HTML doc build.
> 
> ---
> Philippe Blain (2):
>       gdb/doc: MPFR is now a necessary requirement
>       gdb/doc: uniformize wording for GMP and MPFR entries
> 
>  gdb/doc/gdb.texinfo | 31 +++++++++++++++----------------
>  1 file changed, 15 insertions(+), 16 deletions(-)
> ---
> base-commit: 4c9066e322f46faf9d753be6ff3e6a09ae668f86
> change-id: 20230306-doc-require-mpfr-fix-65e7105fc410
> --
> b4 
> 

A small ping.

If nobody else has an opinion on 2/2, maybe someone with push access
could push 1/2 which is already approved ?

Thank you,

Philippe.
Philippe Blain April 7, 2023, 1:19 p.m. UTC | #2 
Hi Eli,

Le 2023-04-05 à 09:31, Eli Zaretskii a écrit :
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>> Date: Mon, 03 Apr 2023 12:47:34 -0400
>>
>> This short series moves the "MPFR" requirement in the doc under the
>> "Tools/Packages Necessary for Building GDB" heading and uniformizes the wording
>> between the GMP and MPFR entries.
>>
>> I tested the HTML doc build.
>> 
>> ---
>> Changes in v2:
>> - removed "now" from the first sentence in both the GMP and MPFR entries,
>>   as suggested by Simon
>> - Link to v1: https://inbox.sourceware.org/20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com
> 
> Thanks for working on this.
> 
> I've eventually concluded that a much deeper surgery is needed in
> these two sections:
> 
>   . the text was repetitive, basically repeating the same boilerplate
>     stuff for each library/package
>   . the arrangement was not very logical (probably alphabetical), so
>     Python was near the end and Expat was the first one
>   . some of the data was outdated (e.g., the minimum supported Python
>     version) and some URLs used non-Texinfo markup
> 
> etc.
> 
> So I've rearranged and rewritten the text, including all the fixes
> that your patches provided.  Please take a look (commit 3401f94), and
> if I left something incorrect or unhandled, please tell.

Thanks, I took a look at your commit and it is indeed a nice cleanup of the whole
section. I've just realized that I forgot to CC the list in my v2.

I've found a few things that seem to have slipped through the cracks in your 
commit, so I'll send a fixup series later today.

Thanks for acknowledging me in the commit message. Just a side note, some projects 
use special trailers for this, like 'Suggested-by', 'Original-patch-by:', etc.

Cheers,

Philippe.