From patchwork Tue Feb 7 13:27:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lancelot SIX X-Patchwork-Id: 55467 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EEE5C385B51D for ; Tue, 7 Feb 2023 13:28:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEE5C385B51D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675776540; bh=fkqrE35bphbV95q+oMFnXlO7x2XgFONa37i3yv1XQmg=; h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Ywgo7hRwz/Q+YDFBsbHvdYvBaqIjfa8BC1yC4bshcF6zzTbf4z6O8ozwaw+mAk73V p/8meMnCrDJS5GXkknUq+z1zw4l1R1rzrUhX3KFVJNjxDIfkUma6kmWo0E9SgMOZ2H s26Tsx0y64CUz5B+ledH4YVYR6/6NmxoolS6Gsic= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2088.outbound.protection.outlook.com [40.107.101.88]) by sourceware.org (Postfix) with ESMTPS id B434A3858D35 for ; Tue, 7 Feb 2023 13:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B434A3858D35 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R4+/cc+MbsWendCBCAuS6G0nSfG1lEELkooB+MN3r+3FYV4IdLMIFeCHDOCuYYqYr0UNKHGmF9hdvORyOq3JATusoOjZ/UFI2sOlDqidgmF1/jK4TdXK0YKQsdeRDM0Af5xogYudV++5/hboYRtVJAFe68pOE+09JR6C3b4/VR2xf3gg9TnOiJTne4PqH18a8hJuqtiQlE/G674Zqywct/7u8Lz20iwFcbbXi/RXeXwX+gnJPXkbx0EGS9nHDEtD94jNmdCQRibrLI36N0Rqo1+dU3cXpCFccO7qoWrDDpfSdn8sZ3R+7c6xya2aViJbMhQfqfno3dnAUjRSL6ISkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fkqrE35bphbV95q+oMFnXlO7x2XgFONa37i3yv1XQmg=; b=YO+Z+qhNfBLFqZP+EZRL8HHKAxS5nHxAqlpz3W7Hw9U6eNOnnfJs83sGQxiDkhPHQJgQmW4FpdsiSVKGNybOrUTOsjEggJnv1C4p2APmBFcDeYb1cTriAPmeCGBlDKy1zp98zXg+dMnCSzF0iJbk0MN86gthRGcA+4rj4rapk4hzwIbb1wMyTqX0fuWGKNaUvojDj3a6DabD0ZDMmjs+qLcrqHo8XvdvPyS43fmG61EQs5GzDfm+wxTReyb2F/NGG8koZh8dhdK2T8WddfH0xsiDB5hxits3Ir/YQw4yLI/tkR4kRUMSncevz1mS+ziCnzDjH1hv1v1e/5udM9vwug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from DS7PR06CA0044.namprd06.prod.outlook.com (2603:10b6:8:54::20) by CH2PR12MB4889.namprd12.prod.outlook.com (2603:10b6:610:68::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 13:28:29 +0000 Received: from DM6NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:8:54:cafe::bf) by DS7PR06CA0044.outlook.office365.com (2603:10b6:8:54::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Tue, 7 Feb 2023 13:28:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT078.mail.protection.outlook.com (10.13.173.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 13:28:29 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 07:28:28 -0600 To: CC: , Lancelot SIX Subject: [PATCH 0/4] Fix gdb.rocm/simple.exp on hosts without ROCm Date: Tue, 7 Feb 2023 13:27:58 +0000 Message-ID: <20230207132802.223510-1-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT078:EE_|CH2PR12MB4889:EE_ X-MS-Office365-Filtering-Correlation-Id: 49272770-93af-4013-967a-08db090f33a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NIGGHXRL3oujmDwIyJBhZfhLoNL4IK4GzF5bqBtnQGWx97Kq94q9i2A+glMqV5iukZpBAqWvceOMnQIglRkCuuhvNattrovpz/kWIQDB05EWdYd3bCHyGZo4vOQHMA26t3aNG/MjwT0faHlqrCme5HzxExXG+8npUVPuvREMEAoduBqI+WwpncPDRBFEufVYPEppbps19d1EH8kHdSf0McSOKbkc180LlCx/rNtMpEqYrEvo7Hk6Sm8df9n6Vl0zYo0mXPsY8ssZXnjnbgnnc52yytCgmN8q73WkISshWMZQXL9J4B1ku261qAZZjCsbquyRFfpvYxlksgwyw/JCxT0CSQntnvpVToFKYJc4nd5Gh7Siw4UbaiheZ4coBA8ZCRzQlJHAgBH/q0Yr6RokkFEEjY1XtZkNfkH48UHadTEjgSUAtXsFqrKKWx0BjiCiaidZ59NURPjDy5I12CNlARJcs/SIbekAP0nw6LcwnAVh9WLu4lBw+DwIJ//tNw2C4PI1KSBY5Jf75Gce8Ue6Yd+qAY/PNKyYABaiPfb7+NvkkMJPHheNE+LevVttDyvDqYEArzsbPrjWL+w3AD61NLh8NjbEzya6RRwOkhKqgKXXAynzXz/Nj3fVWs3hg3+DfflOPa7VXC6hDVwUpM0mH2eyWERkTP3lHnkgEso/jPdWP969UP5SgAtNDxvhfZexqzCNzenAfnysjLrNQOl4y3JCoZ8PjONaZ6N3hiG6soatFWG3/jIV74uCEhABJl10GcPieIZCB408FmcPz2PW6AkJm6VVyyiCNFe8WtOup1C0ISlTkBaayOZ7rF2X6V1r X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199018)(36840700001)(46966006)(40470700004)(36756003)(81166007)(40460700003)(86362001)(70206006)(6916009)(70586007)(316002)(8676002)(478600001)(7696005)(4326008)(54906003)(2906002)(40480700001)(5660300002)(41300700001)(8936002)(36860700001)(426003)(82310400005)(47076005)(82740400003)(1076003)(186003)(16526019)(26005)(83380400001)(966005)(336012)(2616005)(6666004)(356005)(66899018)(84970400001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 13:28:29.7597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49272770-93af-4013-967a-08db090f33a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4889 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lancelot SIX via Gdb-patches From: Lancelot SIX Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Hi, Tom De Vries reported that the gdb.rocm/simple.exp test (recently introduced with the AMDGPU support) can fails[1]. I can reproduce this problem (and variations of it) on systems where GDB is not build with the AMDGPU support, or which do not have the ROCm stack installed. This series fixes this test failure by only running the test if: - GDB is build with AMDGPU support (patch 1 and 3) - if the hipcc compiler is installed and can compile a simple HIP program which offloads a task to an AMDGPU device (patch 4). Patch 3 is a small refactoring to use "require" in gdb.rocm/*.exp. All feedbacks are welcome. Best, Lancelot. [1] https://sourceware.org/pipermail/gdb-patches/2023-February/196624.html Lancelot SIX (4): gdb: 'show config' shows --with[out]-amd-dbgapi gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests gdb/testsuite: require amd-dbgapi support to run rocm tests gdb/testsuite: allow_hipcc_tests tests the hipcc compiler gdb/config.in | 3 ++ gdb/configure | 3 ++ gdb/configure.ac | 1 + gdb/testsuite/gdb.rocm/simple.exp | 5 +- gdb/testsuite/lib/gdb.exp | 4 ++ gdb/testsuite/lib/rocm.exp | 80 +++++++++++++++++++++++++++++-- gdb/top.c | 10 ++++ 7 files changed, 99 insertions(+), 7 deletions(-) base-commit: ca2f51c6960d65c2d3adbc4095aa8a9d02759376