Message ID | 20230125224614.1006886-1-tom@tromey.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1529338493EC for <patchwork@sourceware.org>; Wed, 25 Jan 2023 22:46:49 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 0ACE03858D28 for <gdb-patches@sourceware.org>; Wed, 25 Jan 2023 22:46:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0ACE03858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 5328E1004022B for <gdb-patches@sourceware.org>; Wed, 25 Jan 2023 22:46:25 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KoXBpqnSzNX2aKoXBpdcKm; Wed, 25 Jan 2023 22:46:25 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63d1b141 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=Uczi9Sk4F-Ghc_IlkAAA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JQSa+PUxWzRYMtN/t/PVCpLX3+p6Y2M7bJgRs4BP/nY=; b=RYUWyWMO2QLjT655G2AiJvqBK4 w//JaEgq+lwBUnM/pzBa05ItJ7s2C4pK2CiD8eq/VyXEsKh4oA88IkuxEnc40/UVAH+B/2EF5SIwf mVcS7X6bm8Z0jiT31UVHTyuvw; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:44138 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <tom@tromey.com>) id 1pKoXB-000gXg-1K for gdb-patches@sourceware.org; Wed, 25 Jan 2023 15:46:25 -0700 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Subject: [PATCH 00/27] Many small testsuite cleanups Date: Wed, 25 Jan 2023 15:45:47 -0700 Message-Id: <20230125224614.1006886-1-tom@tromey.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pKoXB-000gXg-1K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:44138 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Many small testsuite cleanups
|
|
Message
Tom Tromey
Jan. 25, 2023, 10:45 p.m. UTC
I noticed a few things in the test suite that looked off, so I wrote some patches to clean it up. Each patch should be reasonably self-explanatory. I started this because I was vaguely considering changing code like this: if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug}]} { return -1 } to some kind of require-like thing. The idea here is that there are a number of things that "shouldn't fail" -- gdb_compile, prepare_for_testing, clean_restart, runto, runto_main -- each with their own error return convention, where existing tests take failure to mean immediately stop. Instead of this, we could have a namespace that knows the conventions for each supported proc and then works a bit like require, so: critical prepare_for_testing ... This could then be a central spot to issue an unsupported (or untested if we go that way). Tested on x86-64 Fedora 36. Tom
Comments
On 2023-01-25 10:45 p.m., Tom Tromey wrote: > I noticed a few things in the test suite that looked off, so I wrote > some patches to clean it up. Each patch should be reasonably > self-explanatory. > I read the whole thing, and the only thing that jumped out at me was the gdb_file_cmd vs gdb_load issue I pointed out in another email. Everything else looked OK. Thanks for doing this.