[00/27] Many small testsuite cleanups

Message ID	20230125224614.1006886-1-tom@tromey.com
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0ACE03858D28 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Subject: [PATCH 00/27] Many small testsuite cleanups Date: Wed, 25 Jan 2023 15:45:47 -0700 Message-Id: <20230125224614.1006886-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Many small testsuite cleanups \| [00/27] Many small testsuite cleanups [01/27] Use ordinary calling convention for clean_restart [02/27] Use clean_restart in gdb.dlang [03/27] Eliminate spurious returns from the test suite [04/27] Remove some dead code in gdb.fortran/info-types.exp [05/27] Minor "require" fixups [06/27] Remove unnecessary call to standard_testfile [07/27] Start gdb after building executable in mi-basics.exp [08/27] Use mi_clean_restart more [09/27] Use clean_restart in gdb.pascal [10/27] Use clean_restart in gdb.linespec [11/27] Use clean_restart in gdb.opencl [12/27] Use clean_restart in gdb.trace [13/27] Use clean_restart in gdb.objc [14/27] Use clean_restart in gdb.threads [15/27] Use clean_restart in gdb.guile [16/27] Use clean_restart in gdb.arch [17/27] Use clean_restart in gdb.reverse [18/27] Use clean_restart in gdb.dwarf2 [19/27] Use clean_restart in gdb.ada [20/27] Use clean_restart in gdb.fortran [21/27] Use clean_restart in gdb.stabs [22/27] Use clean_restart in gdb.go [23/27] Use clean_restart in gdb.perf [24/27] Use clean_restart in gdb.disasm [25/27] Use clean_restart in gdb.cp [26/27] Use clean_restart in gdb.python [27/27] Use clean_restart in gdb.base

Message ID

20230125224614.1006886-1-tom@tromey.com

Headers

DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0ACE03858D28
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 00/27] Many small testsuite cleanups
Date: Wed, 25 Jan 2023 15:45:47 -0700
Message-Id: <20230125224614.1006886-1-tom@tromey.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org
Sender: "Gdb-patches"
 <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>

Series

Many small testsuite cleanups |

Message

Tom Tromey Jan. 25, 2023, 10:45 p.m. UTC

  I noticed a few things in the test suite that looked off, so I wrote
some patches to clean it up.  Each patch should be reasonably
self-explanatory.

I started this because I was vaguely considering changing code like
this:

    if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug}]} {
	return -1
    }

to some kind of require-like thing.  The idea here is that there are a
number of things that "shouldn't fail" -- gdb_compile,
prepare_for_testing, clean_restart, runto, runto_main -- each with
their own error return convention, where existing tests take failure
to mean immediately stop.

Instead of this, we could have a namespace that knows the conventions
for each supported proc and then works a bit like require, so:

    critical prepare_for_testing ...

This could then be a central spot to issue an unsupported (or untested
if we go that way).

Tested on x86-64 Fedora 36.

Tom

Comments

Pedro Alves Jan. 26, 2023, 5:37 p.m. UTC | #1

On 2023-01-25 10:45 p.m., Tom Tromey wrote:
> I noticed a few things in the test suite that looked off, so I wrote
> some patches to clean it up.  Each patch should be reasonably
> self-explanatory.
> 

I read the whole thing, and the only thing that jumped out at me was
the gdb_file_cmd vs gdb_load issue I pointed out in another email.

Everything else looked OK.

Thanks for doing this.