mbox series

[0/9] Fix gdb.dap/basic-dap.exp for PIE

Message ID 20230106185729.42372-1-simon.marchi@efficios.com
Headers
Series Fix gdb.dap/basic-dap.exp for PIE |

Message

Simon Marchi Jan. 6, 2023, 6:57 p.m. UTC 
  The last patch of this series fixes a FAIL I get in
gdb.dap/basic-dap.exp.  The rest of the patches are small improvements I
made to lib/dap-support.exp that helped me get there.

Simon Marchi (9):
  gdb/testsuite/dap: use gdb_assert in gdb.dap/basic-dap.exp
  gdb/testsuite/dap: prefix some procs with _
  gdb/testsuite/dap: write requests to gdb.log
  gdb/testsuite/dap: make dap_request_and_response not catch / issue
    test result
  gdb/testsuite/dap: remove catch from dap_read_event
  gdb/testsuite/dap: pass around dicts instead of ton objects
  gdb/testsuite/dap: rename dap_read_event to
    dap_wait_for_event_and_check
  gdb/testsuite/dap: make dap_wait_for_event_and_check return preceding
    messages
  gdb/testsuite/dap: fix gdb.dap/basic-dap.exp disassembly test for PIE

 gdb/testsuite/gdb.dap/basic-dap.exp |  73 ++++++++++-------
 gdb/testsuite/lib/dap-support.exp   | 121 ++++++++++++++--------------
 2 files changed, 102 insertions(+), 92 deletions(-)

Comments

Simon Marchi Jan. 16, 2023, 4:07 p.m. UTC | #1 
Ping.

On 1/6/23 13:57, Simon Marchi via Gdb-patches wrote:
> The last patch of this series fixes a FAIL I get in
> gdb.dap/basic-dap.exp.  The rest of the patches are small improvements I
> made to lib/dap-support.exp that helped me get there.
> 
> Simon Marchi (9):
>   gdb/testsuite/dap: use gdb_assert in gdb.dap/basic-dap.exp
>   gdb/testsuite/dap: prefix some procs with _
>   gdb/testsuite/dap: write requests to gdb.log
>   gdb/testsuite/dap: make dap_request_and_response not catch / issue
>     test result
>   gdb/testsuite/dap: remove catch from dap_read_event
>   gdb/testsuite/dap: pass around dicts instead of ton objects
>   gdb/testsuite/dap: rename dap_read_event to
>     dap_wait_for_event_and_check
>   gdb/testsuite/dap: make dap_wait_for_event_and_check return preceding
>     messages
>   gdb/testsuite/dap: fix gdb.dap/basic-dap.exp disassembly test for PIE
> 
>  gdb/testsuite/gdb.dap/basic-dap.exp |  73 ++++++++++-------
>  gdb/testsuite/lib/dap-support.exp   | 121 ++++++++++++++--------------
>  2 files changed, 102 insertions(+), 92 deletions(-)
>
Tom Tromey Jan. 25, 2023, 10:10 p.m. UTC | #2 
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Ping.

I sent all my comments.  Nothing major, thank you very much for doing this.

Tom
Simon Marchi Jan. 26, 2023, 8:22 p.m. UTC | #3 
On 1/25/23 17:10, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Ping.
> 
> I sent all my comments.  Nothing major, thank you very much for doing this.
> 
> Tom

Ok, thanks.  I will push the series now.

Simon