Message ID | 20221221133958.2111768-1-christina.schimpe@intel.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD4423857026 for <patchwork@sourceware.org>; Wed, 21 Dec 2022 13:40:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD4423857026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1671630042; bh=yGOsJVkAPEhTb3qU00g45cGItka4+Jx+sDEDj9A7MOI=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=M8zRbz5P8K6Sup4k8+WIdP9TpBJiA9M+DUuCNnNkyfoQd6daicurwmZ81efSdj1Bv dRf2ey2SaSJQdcfwX94hfBzgohZsjD3THMdotCHeKK+AnPmJubmlFfXgm5eX/K2mMF pPaqVjlQGY7fzYUfHj2Fw0EoOqylt8hcjE5oZUag= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id B4BC43858D1E for <gdb-patches@sourceware.org>; Wed, 21 Dec 2022 13:40:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4BC43858D1E X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="303297925" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="303297925" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 05:40:16 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="682032238" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="682032238" Received: from labpc2315.iul.intel.com (HELO localhost) ([172.28.50.57]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 05:40:14 -0800 To: gdb-patches@sourceware.org Cc: tom@tromey.com, pedro@palves.net, aburgess@redhat.com, eliz@gnu.org, Christina Schimpe <christina.schimpe@intel.com> Subject: [PATCH v4 0/3] Apply fixme notes for multi-target support Date: Wed, 21 Dec 2022 14:39:55 +0100 Message-Id: <20221221133958.2111768-1-christina.schimpe@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Christina Schimpe <christina.schimpe@intel.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Apply fixme notes for multi-target support
|
|
Message
Christina Schimpe
Dec. 21, 2022, 1:39 p.m. UTC
Hi all, this is the V4 for the series "Apply fixme notes for multi-target support". It addresses Pedro's and Eli's latest comments. V3 of this series can be found here: https://sourceware.org/pipermail/gdb-patches/2022-September/191763.html. Changes for patch #1: * Split the struct packet_config into two structs packet_config and packet_description to avoid unnecessary copies of a packet's name and title for each new target. This requires a number of interface changes. * Remove unnecessary show_cmd/set_cmd. * Fix some nits. Changes for patch #2: * Fix documentation. I did not make any changes to patch #3 of this series, as it was already approved. Thanks, Christina Christina Schimpe (3): gdb: Make global feature array a per-remote target array gdb: Add per-remote target variables for memory read and write config gdb: Remove workaround for the vCont packet gdb/NEWS | 21 + gdb/doc/gdb.texinfo | 25 +- gdb/remote.c | 1841 +++++++++-------- gdb/testsuite/gdb.base/cond-eval-mode.exp | 9 +- gdb/testsuite/gdb.base/dprintf.exp | 5 +- gdb/testsuite/gdb.base/find-unmapped.exp | 5 +- .../gdb.base/hbreak-in-shr-unsupported.exp | 4 +- gdb/testsuite/gdb.base/remote.exp | 47 +- .../gdb.multi/multi-target-info-inferiors.exp | 6 +- gdb/testsuite/gdb.multi/multi-target.exp.tcl | 8 +- .../connect-without-multi-process.exp | 4 +- .../gdb.server/exit-multiple-threads.exp | 9 +- gdb/testsuite/gdb.server/ext-restart.exp | 5 +- gdb/testsuite/gdb.server/ext-wrapper.exp | 5 +- gdb/testsuite/gdb.server/server-exec-info.exp | 5 +- gdb/testsuite/gdb.server/server-kill.exp | 4 +- .../gdb.server/stop-reply-no-thread-multi.exp | 8 +- .../gdb.server/stop-reply-no-thread.exp | 9 +- .../process-dies-while-handling-bp.exp | 9 +- gdb/testsuite/gdb.trace/change-loc.exp | 4 +- gdb/testsuite/gdb.trace/qtro.exp | 6 +- 21 files changed, 1136 insertions(+), 903 deletions(-)
Comments
Kindly pinging. Thanks, Christina > -----Original Message----- > From: Schimpe, Christina <christina.schimpe@intel.com> > Sent: Wednesday, December 21, 2022 2:40 PM > To: gdb-patches@sourceware.org > Cc: tom@tromey.com; pedro@palves.net; aburgess@redhat.com; > eliz@gnu.org; Schimpe, Christina <christina.schimpe@intel.com> > Subject: [PATCH v4 0/3] Apply fixme notes for multi-target support > > Hi all, > > this is the V4 for the series "Apply fixme notes for multi-target support". > It addresses Pedro's and Eli's latest comments. > > V3 of this series can be found here: > https://sourceware.org/pipermail/gdb-patches/2022- > September/191763.html. > > Changes for patch #1: > * Split the struct packet_config into two structs packet_config and > packet_description to avoid unnecessary copies of a packet's name and title > for each new target. This requires a number of interface changes. > * Remove unnecessary show_cmd/set_cmd. > * Fix some nits. > > Changes for patch #2: > * Fix documentation. > > I did not make any changes to patch #3 of this series, as it was already > approved. > > Thanks, > > Christina > > Christina Schimpe (3): > gdb: Make global feature array a per-remote target array > gdb: Add per-remote target variables for memory read and write config > gdb: Remove workaround for the vCont packet > > gdb/NEWS | 21 + > gdb/doc/gdb.texinfo | 25 +- > gdb/remote.c | 1841 +++++++++-------- > gdb/testsuite/gdb.base/cond-eval-mode.exp | 9 +- > gdb/testsuite/gdb.base/dprintf.exp | 5 +- > gdb/testsuite/gdb.base/find-unmapped.exp | 5 +- > .../gdb.base/hbreak-in-shr-unsupported.exp | 4 +- > gdb/testsuite/gdb.base/remote.exp | 47 +- > .../gdb.multi/multi-target-info-inferiors.exp | 6 +- > gdb/testsuite/gdb.multi/multi-target.exp.tcl | 8 +- > .../connect-without-multi-process.exp | 4 +- > .../gdb.server/exit-multiple-threads.exp | 9 +- > gdb/testsuite/gdb.server/ext-restart.exp | 5 +- > gdb/testsuite/gdb.server/ext-wrapper.exp | 5 +- > gdb/testsuite/gdb.server/server-exec-info.exp | 5 +- > gdb/testsuite/gdb.server/server-kill.exp | 4 +- > .../gdb.server/stop-reply-no-thread-multi.exp | 8 +- > .../gdb.server/stop-reply-no-thread.exp | 9 +- > .../process-dies-while-handling-bp.exp | 9 +- > gdb/testsuite/gdb.trace/change-loc.exp | 4 +- > gdb/testsuite/gdb.trace/qtro.exp | 6 +- > 21 files changed, 1136 insertions(+), 903 deletions(-) > > -- > 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928