[v4,0/3] Apply fixme notes for multi-target support

Message ID 20221221133958.2111768-1-christina.schimpe@intel.com
Headers
Series Apply fixme notes for multi-target support |

Message

Schimpe, Christina Dec. 21, 2022, 1:39 p.m. UTC
  Hi all, 

this is the V4 for the series "Apply fixme notes for multi-target support".
It addresses Pedro's and Eli's latest comments.

V3 of this series can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-September/191763.html.

Changes for patch #1:
* Split the struct packet_config into two structs packet_config and 
packet_description to avoid unnecessary copies of a packet's name and title for
each new target. This requires a number of interface changes.
* Remove unnecessary show_cmd/set_cmd.
* Fix some nits.

Changes for patch #2:
* Fix documentation.

I did not make any changes to patch #3 of this series, as it was already approved.

Thanks,

Christina

Christina Schimpe (3):
  gdb: Make global feature array a per-remote target array
  gdb: Add per-remote target variables for memory read and write config
  gdb: Remove workaround for the vCont packet

 gdb/NEWS                                      |   21 +
 gdb/doc/gdb.texinfo                           |   25 +-
 gdb/remote.c                                  | 1841 +++++++++--------
 gdb/testsuite/gdb.base/cond-eval-mode.exp     |    9 +-
 gdb/testsuite/gdb.base/dprintf.exp            |    5 +-
 gdb/testsuite/gdb.base/find-unmapped.exp      |    5 +-
 .../gdb.base/hbreak-in-shr-unsupported.exp    |    4 +-
 gdb/testsuite/gdb.base/remote.exp             |   47 +-
 .../gdb.multi/multi-target-info-inferiors.exp |    6 +-
 gdb/testsuite/gdb.multi/multi-target.exp.tcl  |    8 +-
 .../connect-without-multi-process.exp         |    4 +-
 .../gdb.server/exit-multiple-threads.exp      |    9 +-
 gdb/testsuite/gdb.server/ext-restart.exp      |    5 +-
 gdb/testsuite/gdb.server/ext-wrapper.exp      |    5 +-
 gdb/testsuite/gdb.server/server-exec-info.exp |    5 +-
 gdb/testsuite/gdb.server/server-kill.exp      |    4 +-
 .../gdb.server/stop-reply-no-thread-multi.exp |    8 +-
 .../gdb.server/stop-reply-no-thread.exp       |    9 +-
 .../process-dies-while-handling-bp.exp        |    9 +-
 gdb/testsuite/gdb.trace/change-loc.exp        |    4 +-
 gdb/testsuite/gdb.trace/qtro.exp              |    6 +-
 21 files changed, 1136 insertions(+), 903 deletions(-)
  

Comments

Terekhov, Mikhail via Gdb-patches Jan. 16, 2023, 8:58 a.m. UTC | #1
Kindly pinging.

Thanks,
Christina

> -----Original Message-----
> From: Schimpe, Christina <christina.schimpe@intel.com>
> Sent: Wednesday, December 21, 2022 2:40 PM
> To: gdb-patches@sourceware.org
> Cc: tom@tromey.com; pedro@palves.net; aburgess@redhat.com;
> eliz@gnu.org; Schimpe, Christina <christina.schimpe@intel.com>
> Subject: [PATCH v4 0/3] Apply fixme notes for multi-target support
> 
> Hi all,
> 
> this is the V4 for the series "Apply fixme notes for multi-target support".
> It addresses Pedro's and Eli's latest comments.
> 
> V3 of this series can be found here:
> https://sourceware.org/pipermail/gdb-patches/2022-
> September/191763.html.
> 
> Changes for patch #1:
> * Split the struct packet_config into two structs packet_config and
> packet_description to avoid unnecessary copies of a packet's name and title
> for each new target. This requires a number of interface changes.
> * Remove unnecessary show_cmd/set_cmd.
> * Fix some nits.
> 
> Changes for patch #2:
> * Fix documentation.
> 
> I did not make any changes to patch #3 of this series, as it was already
> approved.
> 
> Thanks,
> 
> Christina
> 
> Christina Schimpe (3):
>   gdb: Make global feature array a per-remote target array
>   gdb: Add per-remote target variables for memory read and write config
>   gdb: Remove workaround for the vCont packet
> 
>  gdb/NEWS                                      |   21 +
>  gdb/doc/gdb.texinfo                           |   25 +-
>  gdb/remote.c                                  | 1841 +++++++++--------
>  gdb/testsuite/gdb.base/cond-eval-mode.exp     |    9 +-
>  gdb/testsuite/gdb.base/dprintf.exp            |    5 +-
>  gdb/testsuite/gdb.base/find-unmapped.exp      |    5 +-
>  .../gdb.base/hbreak-in-shr-unsupported.exp    |    4 +-
>  gdb/testsuite/gdb.base/remote.exp             |   47 +-
>  .../gdb.multi/multi-target-info-inferiors.exp |    6 +-
>  gdb/testsuite/gdb.multi/multi-target.exp.tcl  |    8 +-
>  .../connect-without-multi-process.exp         |    4 +-
>  .../gdb.server/exit-multiple-threads.exp      |    9 +-
>  gdb/testsuite/gdb.server/ext-restart.exp      |    5 +-
>  gdb/testsuite/gdb.server/ext-wrapper.exp      |    5 +-
>  gdb/testsuite/gdb.server/server-exec-info.exp |    5 +-
>  gdb/testsuite/gdb.server/server-kill.exp      |    4 +-
>  .../gdb.server/stop-reply-no-thread-multi.exp |    8 +-
>  .../gdb.server/stop-reply-no-thread.exp       |    9 +-
>  .../process-dies-while-handling-bp.exp        |    9 +-
>  gdb/testsuite/gdb.trace/change-loc.exp        |    4 +-
>  gdb/testsuite/gdb.trace/qtro.exp              |    6 +-
>  21 files changed, 1136 insertions(+), 903 deletions(-)
> 
> --
> 2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928