From patchwork Wed Nov 23 18:39:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 55319 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1BE553861832 for ; Wed, 23 Nov 2022 18:40:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1BE553861832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669228834; bh=oMsfCdH5mhtopqybc1BOkSVN/zhPJfSnw6QDi3dO09I=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=TX0WwabDzmbW9p52S2wcLOri+XYmbFt499accTpH3r6OXviB9nHeLdYp4vLtbRr2u AkQRnUCe8MrwtQm7tTKDIUjCpgHA2BA58KPf2J1lJP5TOXee51MWsSGMk7ixt/tyYp zikC01gu+qTVa3bvVZxmfZtRWsWMVfwY1RhnY5vI= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5735438518A3 for ; Wed, 23 Nov 2022 18:40:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5735438518A3 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2ANIe2A8026637 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 13:40:07 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2ANIe2A8026637 Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7D7811E0CB; Wed, 23 Nov 2022 13:40:02 -0500 (EST) To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 00/14] Break up gdb.base/break.exp in multiple procs Date: Wed, 23 Nov 2022 13:39:45 -0500 Message-Id: <20221123183959.2476477-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 23 Nov 2022 18:40:02 +0000 X-Spam-Status: No, score=-3183.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Simon Marchi via Gdb-patches From: Simon Marchi Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The test gdb.base/break.exp feels like a big house of cards that will crumble the second you touch it. It is very long and it's really not clear which test depends on the state left by which previous test. This series aims at making it more manageable by breaking it up into many procs, each starting with a fresh GDB. So you can be confident that the tests in a proc only depends on the state of GDB resulting of other tests in the same proc. Simon Marchi (14): gdb/testsuite/gdb.base/break.exp: split test_break_commands_clear gdb/testsuite/gdb.base/break.exp: split test_break_file_line_convenience_var gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib gdb/testsuite/gdb.base/break.exp: split test_break_optimized_prologue gdb/testsuite/gdb.base/break.exp: use proc_with_prefix for test_next_with_recursion gdb/testsuite/gdb.base/break.exp: split test_finish_arguments gdb/testsuite/gdb.base/break.exp: split test_break_user_call gdb/testsuite/gdb.base/break.exp: split test_break_line_convenience_var gdb/testsuite/gdb.base/break.exp: split test_break_silent_and_more gdb/testsuite/gdb.base/break.exp: split test_break_default gdb/testsuite/gdb.base/break.exp: split test_break_nonexistent_line gdb/testsuite/gdb.base/break.exp: split test_no_break_on_catchpoint gdb/testsuite/gdb.base/break.exp: split test_tbreak gdb/testsuite/gdb.base/break.exp: split test_break gdb/testsuite/gdb.base/break.exp | 1191 +++++++++++++++--------------- 1 file changed, 615 insertions(+), 576 deletions(-) base-commit: 8db533e7d6d28db1be0ae4c95ddea7aa3a6224c8