mbox series

[0/8] Fix some commit_resumed_state assertion failures (PR 28275)

Message ID 20221117194241.1776125-1-simon.marchi@efficios.com
Headers
Series Fix some commit_resumed_state assertion failures (PR 28275) |

Message

Simon Marchi Nov. 17, 2022, 7:42 p.m. UTC 
  This series fixes some assertion failures related to the
commit_resumed_state flag being set while target_{wait,kill,stop} is
called.

Patch 3 comes from Andrew Burgess, it fixes the case where GDB detaches
an inferior while quitting, while the inferior is doing a step-over.

Patch 8 fixes the main issue reported by PR 28275.

The other patches are cleanups or fixes for other problems found while
working on this.

Andrew Burgess (2):
  gdb/testsuite: refactor gdb.threads/detach-step-over.exp
  gdb: fix assert when quitting GDB while a thread is stepping

Simon Marchi (6):
  gdb/testsuite: remove global declarations in
    gdb.threads/detach-step-over.exp
  gdbserver/linux: take condition out of callback in find_lwp_pid
  gdbserver/linux-x86: make is_64bit_tdesc accept thread as a parameter
  gdbserver: use current_process in ps_getpid
  gdbserver: switch to right process in find_one_thread
  gdb: disable commit resumed in target_kill

 gdb/target.c                                  |  13 +-
 .../gdb.base/run-control-while-bg-execution.c |  33 ++
 .../run-control-while-bg-execution.exp        | 118 +++++++
 .../gdb.threads/detach-step-over.exp          | 322 +++++++++++-------
 gdbserver/linux-low.cc                        |   4 +-
 gdbserver/linux-x86-low.cc                    |  27 +-
 gdbserver/proc-service.cc                     |   2 +-
 gdbserver/thread-db.cc                        |  29 +-
 8 files changed, 400 insertions(+), 148 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/run-control-while-bg-execution.c
 create mode 100644 gdb/testsuite/gdb.base/run-control-while-bg-execution.exp