From patchwork Mon Nov 7 16:23:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 55272 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 64F2E3858C33 for ; Mon, 7 Nov 2022 16:24:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64F2E3858C33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667838273; bh=gDG9GrTCfhlmqr8OyxKeDzGbfzg0TwWUBvRMzJL/K1M=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=X1w179N68u7o7QuqezrF3xx6rqx4NdnmRHz02VSabgcRtQEiUmCQhI1Ly4vbqtzDS rd7XTz96w9wBPp07Rjuom4YBjNiiP2l1qWMas5G7Xt575bgsxC9fTTN1/Y2RM3Z8Q9 XA+NZ4rk1cW28KoWLszh4MLYZOktIlFQrA0KoQd8= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id CBA493858D20 for ; Mon, 7 Nov 2022 16:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBA493858D20 Received: by mail-io1-xd36.google.com with SMTP id p141so9275424iod.6 for ; Mon, 07 Nov 2022 08:24:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gDG9GrTCfhlmqr8OyxKeDzGbfzg0TwWUBvRMzJL/K1M=; b=OOLKUhqeK9wJO/ty3SWsw72d+rwzQqgKbbHGPN7wm1Dz4l9/oFBkwMzoLqN94aZL7Z CzqGjiPa9eL0gK1dMNU9KdN3TKIQG2v2XhsvlGH0s1MFdtz0BHvYV97P4gRkxsW+PYu4 dAqT8UmFyksEL97nMf4COuG+Q875Db6JT36SUlVJc9GSncWJUyxyyB1ITkoMZlBW/o+8 NVQhqkPLnYdDr55MVqg5cHF0lnmgpe36y3xm665pZte8ep19p6da1MlPB3rvoYaLXj1D x/0xp73Rb6ahviokxhi6NwXdjBV+C1nc7fXUwQfK99qLXYR/JdflDs8y54KaenDalome ITuA== X-Gm-Message-State: ACrzQf0z3t0+ePxYDHtJMNnO7aTeIWz/ZH1NN7fUrH8RtnCrQCOByKiu WD7wkGbEnavaZ955k6y1n3278kU3dq/GzA== X-Google-Smtp-Source: AMsMyM5LRuR8DGmSA1jh31B6N3kvycU1aOIAsI+yOZ1IpvqokU8I5JHlQNDhw6ovMuBq+1eOl17B6g== X-Received: by 2002:a02:3406:0:b0:375:930d:fa17 with SMTP id x6-20020a023406000000b00375930dfa17mr12629048jae.211.1667838247944; Mon, 07 Nov 2022 08:24:07 -0800 (PST) Received: from localhost.localdomain (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id i12-20020a023b4c000000b003750aa3c5c1sm2790492jaf.31.2022.11.07.08.24.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 08:24:07 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH 0/3] Fix over-eager CU expansion with new DWARF reader Date: Mon, 7 Nov 2022 09:23:53 -0700 Message-Id: <20221107162356.3175221-1-tromey@adacore.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" PR symtab/29105 concerns an over-eager CU expansion bug with the new DWARF reader. This short series fixes the bug. The first two patches are tiny refactorings to make the final patch more understandable. I don't know how to write a good test for this. In order to try it, what I had to do on my machine was to install the glibc debuginfo, disable the use of the gdb index by hacking dwarf2_initialize_objfile (Fedora uses .gdb_index in the system debuginfo), and finally run the sizeof.exp test and try it out by hand, with "set debug symtab-create 1". Regression tested on x86-64 Fedora 34. Let me know what you think. Tom